Commit 4a344c168360e9494fa2e33f85833e5fee80a5f8
1 parent
68d146b4
Exists in
master
and in
4 other branches
Move search to separate layout
Showing
5 changed files
with
14 additions
and
11 deletions
Show diff stats
app/assets/stylesheets/common.scss
app/views/layouts/nav/_dashboard.html.haml
| @@ -13,8 +13,6 @@ | @@ -13,8 +13,6 @@ | ||
| 13 | = link_to merge_requests_dashboard_path do | 13 | = link_to merge_requests_dashboard_path do |
| 14 | Merge Requests | 14 | Merge Requests |
| 15 | %span.count= current_user.cared_merge_requests.opened.count | 15 | %span.count= current_user.cared_merge_requests.opened.count |
| 16 | - = nav_link(path: 'search#show') do | ||
| 17 | - = link_to "Search", search_path | ||
| 18 | = nav_link(controller: :help) do | 16 | = nav_link(controller: :help) do |
| 19 | = link_to "Help", help_path | 17 | = link_to "Help", help_path |
| 20 | 18 |
features/dashboard/active_tab.feature
| @@ -17,11 +17,6 @@ Feature: Dashboard active tab | @@ -17,11 +17,6 @@ Feature: Dashboard active tab | ||
| 17 | Then the active main tab should be Merge Requests | 17 | Then the active main tab should be Merge Requests |
| 18 | And no other main tabs should be active | 18 | And no other main tabs should be active |
| 19 | 19 | ||
| 20 | - Scenario: On Dashboard Search | ||
| 21 | - Given I visit dashboard search page | ||
| 22 | - Then the active main tab should be Search | ||
| 23 | - And no other main tabs should be active | ||
| 24 | - | ||
| 25 | Scenario: On Dashboard Help | 20 | Scenario: On Dashboard Help |
| 26 | Given I visit dashboard help page | 21 | Given I visit dashboard help page |
| 27 | Then the active main tab should be Help | 22 | Then the active main tab should be Help |
features/steps/dashboard/dashboard_active_tab.rb
| @@ -15,10 +15,6 @@ class DashboardActiveTab < Spinach::FeatureSteps | @@ -15,10 +15,6 @@ class DashboardActiveTab < Spinach::FeatureSteps | ||
| 15 | ensure_active_main_tab('Merge Requests') | 15 | ensure_active_main_tab('Merge Requests') |
| 16 | end | 16 | end |
| 17 | 17 | ||
| 18 | - Then 'the active main tab should be Search' do | ||
| 19 | - ensure_active_main_tab('Search') | ||
| 20 | - end | ||
| 21 | - | ||
| 22 | Then 'the active main tab should be Help' do | 18 | Then 'the active main tab should be Help' do |
| 23 | ensure_active_main_tab('Help') | 19 | ensure_active_main_tab('Help') |
| 24 | end | 20 | end |