Commit 4a55c6987703717fd63b7884f2c9695ccac8c010
1 parent
135418dc
Exists in
master
and in
4 other branches
Data converting migrations was wrong. Fixed
Showing
3 changed files
with
9 additions
and
9 deletions
Show diff stats
db/migrate/20130218141258_convert_closed_to_state_in_issue.rb
1 | 1 | class ConvertClosedToStateInIssue < ActiveRecord::Migration |
2 | 2 | def up |
3 | 3 | Issue.transaction do |
4 | - Issue.where(closed: true).update_all("state = 'closed'") | |
5 | - Issue.where(closed: false).update_all("state = 'opened'") | |
4 | + Issue.where(closed: true).update_all(state: :closed) | |
5 | + Issue.where(closed: false).update_all(state: :opened) | |
6 | 6 | end |
7 | 7 | end |
8 | 8 | |
9 | 9 | def down |
10 | 10 | Issue.transaction do |
11 | - Issue.where(state: :closed).update_all("closed = 1") | |
11 | + Issue.where(state: :closed).update_all(closed: true) | |
12 | 12 | end |
13 | 13 | end |
14 | 14 | end | ... | ... |
db/migrate/20130218141327_convert_closed_to_state_in_merge_request.rb
1 | 1 | class ConvertClosedToStateInMergeRequest < ActiveRecord::Migration |
2 | 2 | def up |
3 | 3 | MergeRequest.transaction do |
4 | - MergeRequest.where(closed: true, merged: true).update_all("state = 'merged'") | |
5 | - MergeRequest.where(closed: true, merged: true).update_all("state = 'closed'") | |
6 | - MergeRequest.where(closed: false).update_all("state = 'opened'") | |
4 | + MergeRequest.where(closed: true, merged: true).update_all(state: :merged) | |
5 | + MergeRequest.where(closed: true, merged: false).update_all(state: :closed) | |
6 | + MergeRequest.where(closed: false).update_all(state: :opened) | |
7 | 7 | end |
8 | 8 | end |
9 | 9 | ... | ... |
db/migrate/20130218141344_convert_closed_to_state_in_milestone.rb
1 | 1 | class ConvertClosedToStateInMilestone < ActiveRecord::Migration |
2 | 2 | def up |
3 | 3 | Milestone.transaction do |
4 | - Milestone.where(closed: false).update_all("state = 'opened'") | |
5 | - Milestone.where(closed: false).update_all("state = 'active'") | |
4 | + Milestone.where(closed: true).update_all(state: :closed) | |
5 | + Milestone.where(closed: false).update_all(state: :active) | |
6 | 6 | end |
7 | 7 | end |
8 | 8 | |
9 | 9 | def down |
10 | 10 | Milestone.transaction do |
11 | - Milestone.where(state: :closed).update_all("closed = 1") | |
11 | + Milestone.where(state: :closed).update_all(closed: true) | |
12 | 12 | end |
13 | 13 | end |
14 | 14 | end | ... | ... |