Comment gzip: off be default

Dmitriy Zaporozhets
1 parent 563fec73
Showing 1 changed file with 4 additions and 4 deletions Show diff stats
lib/support/nginx/gitlab
@@ -42,8 +42,9 @@ server {
   # if a file, which is not found in the root folder is requested,
   # then the proxy pass the request to the upsteam (gitlab unicorn)
   location @gitlab {
-    # We need this to prevent BREACH attack
-    gzip off;
+    # If you use https make sure you disable gzip compression 
+    # to be safe against BREACH attack
+    # gzip off;
  
     proxy_read_timeout 300; # Some requests take more than 30 seconds.
     proxy_connect_timeout 300; # Some requests take more than 30 seconds.
@@ -66,5 +67,4 @@ server {
   }
  
   error_page 502 /502.html;
-}
-
+}
 \ No newline at end of file
...	...	@@ -42,8 +42,9 @@ server {
42	42	# if a file, which is not found in the root folder is requested,
43	43	# then the proxy pass the request to the upsteam (gitlab unicorn)
44	44	location @gitlab {
45		- # We need this to prevent BREACH attack
46		- gzip off;
	45	+ # If you use https make sure you disable gzip compression
	46	+ # to be safe against BREACH attack
	47	+ # gzip off;
47	48
48	49	proxy_read_timeout 300; # Some requests take more than 30 seconds.
49	50	proxy_connect_timeout 300; # Some requests take more than 30 seconds.
...	...	@@ -66,5 +67,4 @@ server {
66	67	}
67	68
68	69	error_page 502 /502.html;
69		-}
70		-
	70	+}
71	71	\ No newline at end of file
...	...