Fix specs

Riyad Preukschas
1 parent a85e11fa
Showing 6 changed files with 39 additions and 36 deletions Show diff stats
app/assets/javascripts/issues.js
app/models/milestone.rb
features/steps/project/project_browse_commits.rb
spec/models/issue_spec.rb
spec/requests/issues_spec.rb
spec/roles/issue_commonality_spec.rb
@@ -39,10 +39,10 @@ function backToIssues(){
 }
 function initIssuesSearch() { 
-  var href       = $('.issue_search').parent().attr('action');
+  var href       = $('#issue_search_form').attr('action');
   var last_terms = '';
-  $('.issue_search').keyup(function() {
+  $('#issue_search').keyup(function() {
     var terms       = $(this).val();
     var milestone_id  = $('#milestone_id').val();
     var status      = $('#status').val();
@@ -57,10 +57,6 @@ function initIssuesSearch() {
       }
     }
   });
-
-  $('.delete-issue').live('ajax:success', function() {
-    $(this).closest('tr').fadeOut(); updatePage();
-  });
 }
 /**
@@ -7,6 +7,7 @@ class Milestone &lt; ActiveRecord::Base
   validates :title, presence: true
   validates :project, presence: true
+  validates :closed, inclusion: { in: [true, false] }
   def self.active
     where("due_date > ? OR due_date IS NULL", Date.today)
@@ -53,8 +53,9 @@ class ProjectBrowseCommits &lt; Spinach::FeatureSteps
   end
   Then 'I see commits stats' do
-    page.should have_content 'Stats for master'
+    page.should have_content 'Stats'
     page.should have_content 'Committers'
     page.should have_content 'Total commits'
+    page.should have_content 'Authors'
   end
 end
@@ -30,7 +30,6 @@ describe Issue do
   describe "Validation" do
     it { should ensure_length_of(:description).is_within(0..2000) }
-    it { should ensure_inclusion_of(:closed).in_array([true, false]) }
   end
   describe 'modules' do
@@ -5,24 +5,27 @@ describe &quot;Issues&quot; do
   before do
     login_as :user
-    @user2 = create(:user)
+    user2 = create(:user)
     project.add_access(@user, :read, :write)
-    project.add_access(@user2, :read, :write)
+    project.add_access(user2, :read, :write)
   end
   describe "Edit issue", js: true do
+    let!(:issue) do
+      create(:issue,
+             author: @user,
+             assignee: @user,
+             project: project)
+    end
+
     before do
-      @issue = create(:issue,
-                      author: @user,
-                      assignee: @user,
-                      project: project)
       visit project_issues_path(project)
       click_link "Edit"
     end
     it "should open new issue popup" do
-      page.should have_content("Issue ##{@issue.id}")
+      page.should have_content("Issue ##{issue.id}")
     end
     describe "fill in" do
@@ -46,19 +49,18 @@ describe &quot;Issues&quot; do
   describe "Search issue", js: true do
     before do
       ['foobar', 'foobar2', 'gitlab'].each do |title|
-        @issue = create(:issue,
-                        author: @user,
-                        assignee: @user,
-                        project: project,
-                        title: title)
-        @issue.save
+        create(:issue,
+               author: @user,
+               assignee: @user,
+               project: project,
+               title: title)
       end
     end
     it "should be able to search on different statuses" do
-      @issue = Issue.first
-      @issue.closed = true
-      @issue.save
+      issue = Issue.first # with title 'foobar'
+      issue.closed = true
+      issue.save
       visit project_issues_path(project)
       click_link 'Closed'
@@ -81,8 +83,9 @@ describe &quot;Issues&quot; do
     it "should return all results if term has been cleared" do
       visit project_issues_path(project)
       fill_in "issue_search", with: "foobar"
-      # Because fill_in, with: "" triggers nothing we need to trigger a keyup event
-      page.execute_script("$('.issue_search').val('').keyup();");
+      # Reset the search field and trigger loading the issues
+      fill_in "issue_search", with: ""
+      page.execute_script("$('#issue_search').keyup();");
       page.should have_content 'foobar'
       page.should have_content 'foobar2'
@@ -93,19 +96,21 @@ describe &quot;Issues&quot; do
   describe "Filter issue" do
     before do
       ['foobar', 'barbaz', 'gitlab'].each do |title|
-        @issue = create(:issue,
-                        author: @user,
-                        assignee: @user,
-                        project: project,
-                        title: title)
+        create(:issue,
+               author: @user,
+               assignee: @user,
+               project: project,
+               title: title)
       end
-      @issue = Issue.first
-      @issue.milestone = create(:milestone, project: project)
-      @issue.assignee = nil
-      @issue.save
+      issue = Issue.first # with title 'foobar'
+      issue.milestone = create(:milestone, project: project)
+      issue.assignee = nil
+      issue.save
     end
+    let(:issue) { Issue.first }
+
     it "should allow filtering by issues with no specified milestone" do
       visit project_issues_path(project, milestone_id: '0')
@@ -115,7 +120,7 @@ describe &quot;Issues&quot; do
     end
     it "should allow filtering by a specified milestone" do
-      visit project_issues_path(project, milestone_id: @issue.milestone.id)
+      visit project_issues_path(project, milestone_id: issue.milestone.id)
       page.should have_content 'foobar'
       page.should_not have_content 'barbaz'
@@ -15,6 +15,7 @@ describe Issue, &quot;IssueCommonality&quot; do
     it { should validate_presence_of(:author) }
     it { should validate_presence_of(:title) }
     it { should ensure_length_of(:title).is_at_least(0).is_at_most(255) }
+    it { should ensure_inclusion_of(:closed).in_array([true, false]) }
   end
   describe "Scope" do
	@@ -7,6 +7,7 @@ class Milestone < ActiveRecord::Base		@@ -7,6 +7,7 @@ class Milestone < ActiveRecord::Base
7		7
8	validates :title, presence: true	8	validates :title, presence: true
9	validates :project, presence: true	9	validates :project, presence: true
		10	+ validates :closed, inclusion: { in: [true, false] }
10		11
11	def self.active	12	def self.active
12	where("due_date > ? OR due_date IS NULL", Date.today)	13	where("due_date > ? OR due_date IS NULL", Date.today)
	@@ -30,7 +30,6 @@ describe Issue do		@@ -30,7 +30,6 @@ describe Issue do
30		30
31	describe "Validation" do	31	describe "Validation" do
32	it { should ensure_length_of(:description).is_within(0..2000) }	32	it { should ensure_length_of(:description).is_within(0..2000) }
33	- it { should ensure_inclusion_of(:closed).in_array([true, false]) }
34	end	33	end
35		34
36	describe 'modules' do	35	describe 'modules' do
	@@ -15,6 +15,7 @@ describe Issue, "IssueCommonality" do		@@ -15,6 +15,7 @@ describe Issue, "IssueCommonality" do
15	it { should validate_presence_of(:author) }	15	it { should validate_presence_of(:author) }
16	it { should validate_presence_of(:title) }	16	it { should validate_presence_of(:title) }
17	it { should ensure_length_of(:title).is_at_least(0).is_at_most(255) }	17	it { should ensure_length_of(:title).is_at_least(0).is_at_most(255) }
		18	+ it { should ensure_inclusion_of(:closed).in_array([true, false]) }
18	end	19	end
19		20
20	describe "Scope" do	21	describe "Scope" do