remove notify checkboxes from note forms

Dmitriy Zaporozhets
1 parent 70947fed
Showing 5 changed files with 12 additions and 30 deletions Show diff stats
app/assets/stylesheets/sections/notes.scss
app/contexts/notes/create_context.rb
app/models/note.rb
app/views/notes/_form.html.haml
app/views/walls/show.html.haml
@@ -274,6 +274,15 @@ ul.notes {
 }
+.common-note-form {
+  margin: 0;
+  height: 140px;
+  background: #F9F9F9;
+  padding: 3px;
+  padding-bottom: 25px;
+  border: 1px solid #DDD;
+}
+
 .note-form-actions {
   background: #F9F9F9;
@@ -281,8 +290,8 @@ ul.notes {
   padding: 0 5px;
   .note-form-option {
-    margin-top: 8px;
-    margin-left: 15px;
+    margin-top: 10px;
+    margin-left: 30px;
     @extend .pull-left;
   }
@@ -3,8 +3,6 @@ module Notes
     def execute
       note = project.notes.new(params[:note])
       note.author = current_user
-      note.notify = params[:notify].present?
-      note.notify_author = params[:notify_author].present?
       note.save
       note
     end
@@ -22,9 +22,6 @@ class Note &lt; ActiveRecord::Base
   attr_accessible :note, :noteable, :noteable_id, :noteable_type, :project_id,
                   :attachment, :line_code, :commit_id
-  attr_accessor :notify
-  attr_accessor :notify_author
-
   belongs_to :project
   belongs_to :noteable, polymorphic: true
   belongs_to :author, class_name: "User"
@@ -143,14 +140,6 @@ class Note &lt; ActiveRecord::Base
     nil
   end
-  def notify
-    @notify ||= false
-  end
-
-  def notify_author
-    @notify_author ||= false
-  end
-
   # Returns true if this is an upvote note,
   # otherwise false is returned
   def upvote?
-= form_for [@project, @note], remote: true, html: { multipart: true, id: nil, class: "new_note js-new-note-form" } do |f|
+= form_for [@project, @note], remote: true, html: { multipart: true, id: nil, class: "new_note js-new-note-form common-note-form" } do |f|
   = note_target_fields
   = f.hidden_field :commit_id
@@ -27,15 +27,6 @@
       %a.btn.grouped.js-close-discussion-note-form Cancel
     .note-form-option
-      = label_tag :notify do
-        = check_box_tag :notify, 1, false
-        %span.light Notify team via email
-
-      .js-notify-commit-author
-        = label_tag :notify_author do
-          = check_box_tag :notify_author, 1 , false
-          %span.light Notify commit author
-    .note-form-option
       %a.choose-btn.btn.btn-small.js-choose-note-attachment-button
         %i.icon-paper-clip
         %span Choose File ...
@@ -12,11 +12,6 @@
             = f.submit 'Add Comment', class: "btn comment-btn grouped js-comment-button"
           .note-form-option
-            = label_tag :notify do
-              = check_box_tag :notify, 1, false
-              %span.light Notify team via email
-
-          .note-form-option
             %a.choose-btn.btn.btn-small.js-choose-note-attachment-button
               %i.icon-paper-clip
                 %span Choose File ...
	@@ -22,9 +22,6 @@ class Note < ActiveRecord::Base		@@ -22,9 +22,6 @@ class Note < ActiveRecord::Base
22	attr_accessible :note, :noteable, :noteable_id, :noteable_type, :project_id,	22	attr_accessible :note, :noteable, :noteable_id, :noteable_type, :project_id,
23	:attachment, :line_code, :commit_id	23	:attachment, :line_code, :commit_id
24		24
25	- attr_accessor :notify
26	- attr_accessor :notify_author
27	-
28	belongs_to :project	25	belongs_to :project
29	belongs_to :noteable, polymorphic: true	26	belongs_to :noteable, polymorphic: true
30	belongs_to :author, class_name: "User"	27	belongs_to :author, class_name: "User"
	@@ -143,14 +140,6 @@ class Note < ActiveRecord::Base		@@ -143,14 +140,6 @@ class Note < ActiveRecord::Base
143	nil	140	nil
144	end	141	end
145		142
146	- def notify
147	- @notify \|\|= false
148	- end
149	-
150	- def notify_author
151	- @notify_author \|\|= false
152	- end
153	-
154	# Returns true if this is an upvote note,	143	# Returns true if this is an upvote note,
155	# otherwise false is returned	144	# otherwise false is returned
156	def upvote?	145	def upvote?