Download as
Browse Code »

Commit 653f7ec4fb57f84f471c8f2078c7534b1c085cc9

Authored by Riyad Preukschas
1 parent 20e009a4
Exists in master and in 4 other branches 6-8-stable, 7-0-stable, 7-0-stable-spb, spb-stable

Update links for inline comments to use data-* attributes

Showing 2 changed files with 2 additions and 2 deletions   Show diff stats
app/views/commits/_text_file.html.haml
  Diff comments   View file @653f7ec
@@ -13,7 +13,7 @@ @@ -13,7 +13,7 @@
13 %td.old_line 13 %td.old_line
14 = link_to raw(type == "new" ? " " : line_old), "##{line_code}", id: line_code 14 = link_to raw(type == "new" ? " " : line_old), "##{line_code}", id: line_code
15 - if @comments_allowed 15 - if @comments_allowed
16 - = link_to "", "#", class: "line_note_link", "line_code" => line_code, title: "Add note for this line" 16 + = link_to "", "#", class: "line_note_link", data: { line_code: line_code }, title: "Add note for this line"
17 %td.new_line= link_to raw(type == "old" ? " " : line_new) , "##{line_code}", id: line_code 17 %td.new_line= link_to raw(type == "old" ? " " : line_new) , "##{line_code}", id: line_code
18 %td.line_content{class: "noteable_line #{type} #{line_code}", "line_code" => line_code}= raw "#{line}  " 18 %td.line_content{class: "noteable_line #{type} #{line_code}", "line_code" => line_code}= raw "#{line}  "
19 19
app/views/notes/_reply_button.html.haml
  Diff comments   View file @653f7ec
1 %tr.line_notes_row.reply 1 %tr.line_notes_row.reply
2 %td{colspan: 3} 2 %td{colspan: 3}
3 %i.icon-comment 3 %i.icon-comment
4 - = link_to "Reply", "#", class: "line_note_reply_link", "line_code" => line_code, title: "Add note for this line" 4 + = link_to "Reply", "#", class: "line_note_reply_link", data: { line_code: line_code }, title: "Add note for this line"