Commit 65989141dcc58eaa3cecfe98bc97a10075cf4f7e
1 parent
70c6b48e
Exists in
master
and in
4 other branches
Protect IssueObserver#send_reassigned_email method.
Showing
2 changed files
with
5 additions
and
3 deletions
Show diff stats
app/models/issue_observer.rb
| @@ -11,6 +11,8 @@ class IssueObserver < ActiveRecord::Observer | @@ -11,6 +11,8 @@ class IssueObserver < ActiveRecord::Observer | ||
| 11 | Note.create_status_change_note(issue, current_user, 'reopened') if issue.is_being_reopened? | 11 | Note.create_status_change_note(issue, current_user, 'reopened') if issue.is_being_reopened? |
| 12 | end | 12 | end |
| 13 | 13 | ||
| 14 | + protected | ||
| 15 | + | ||
| 14 | def send_reassigned_email(issue) | 16 | def send_reassigned_email(issue) |
| 15 | recipient_ids = [issue.assignee_id, issue.assignee_id_was].keep_if {|id| id != current_user.id } | 17 | recipient_ids = [issue.assignee_id, issue.assignee_id_was].keep_if {|id| id != current_user.id } |
| 16 | 18 |
spec/models/issue_observer_spec.rb
| @@ -121,7 +121,7 @@ describe IssueObserver do | @@ -121,7 +121,7 @@ describe IssueObserver do | ||
| 121 | it_sends_a_reassigned_email_to assignee.id | 121 | it_sends_a_reassigned_email_to assignee.id |
| 122 | it_sends_a_reassigned_email_to previous_assignee.id | 122 | it_sends_a_reassigned_email_to previous_assignee.id |
| 123 | 123 | ||
| 124 | - subject.send_reassigned_email(issue) | 124 | + subject.send(:send_reassigned_email, issue) |
| 125 | end | 125 | end |
| 126 | 126 | ||
| 127 | context 'does not send an email to the user who made the reassignment' do | 127 | context 'does not send an email to the user who made the reassignment' do |
| @@ -130,14 +130,14 @@ describe IssueObserver do | @@ -130,14 +130,14 @@ describe IssueObserver do | ||
| 130 | it_sends_a_reassigned_email_to previous_assignee.id | 130 | it_sends_a_reassigned_email_to previous_assignee.id |
| 131 | it_does_not_send_a_reassigned_email_to assignee.id | 131 | it_does_not_send_a_reassigned_email_to assignee.id |
| 132 | 132 | ||
| 133 | - subject.send_reassigned_email(issue) | 133 | + subject.send(:send_reassigned_email, issue) |
| 134 | end | 134 | end |
| 135 | it 'if the user is the previous assignee' do | 135 | it 'if the user is the previous assignee' do |
| 136 | subject.stub(:current_user).and_return(previous_assignee) | 136 | subject.stub(:current_user).and_return(previous_assignee) |
| 137 | it_sends_a_reassigned_email_to assignee.id | 137 | it_sends_a_reassigned_email_to assignee.id |
| 138 | it_does_not_send_a_reassigned_email_to previous_assignee.id | 138 | it_does_not_send_a_reassigned_email_to previous_assignee.id |
| 139 | 139 | ||
| 140 | - subject.send_reassigned_email(issue) | 140 | + subject.send(:send_reassigned_email, issue) |
| 141 | end | 141 | end |
| 142 | end | 142 | end |
| 143 | end | 143 | end |