Commit 6aebb76b5d05bf7668a8f389a00648fdb405af7d
1 parent
b8113334
Exists in
master
and in
4 other branches
Update votes when creating or refreshing notes
Showing
1 changed file
with
40 additions
and
3 deletions
Show diff stats
app/assets/javascripts/notes.js
@@ -21,15 +21,18 @@ var NoteList = { | @@ -21,15 +21,18 @@ var NoteList = { | ||
21 | this.getContent(); | 21 | this.getContent(); |
22 | 22 | ||
23 | $("#notes-list, #new-notes-list").on("ajax:success", ".delete-note", function() { | 23 | $("#notes-list, #new-notes-list").on("ajax:success", ".delete-note", function() { |
24 | - $(this).closest('li').fadeOut(); | 24 | + $(this).closest('li').fadeOut(function() { |
25 | + $(this).remove(); | ||
26 | + NoteList.updateVotes(); | ||
27 | + }); | ||
25 | }); | 28 | }); |
26 | 29 | ||
27 | $(".note-form-holder").on("ajax:before", function(){ | 30 | $(".note-form-holder").on("ajax:before", function(){ |
28 | - $(".submit_note").disable() | 31 | + $(".submit_note").disable(); |
29 | }) | 32 | }) |
30 | 33 | ||
31 | $(".note-form-holder").on("ajax:complete", function(){ | 34 | $(".note-form-holder").on("ajax:complete", function(){ |
32 | - $(".submit_note").enable() | 35 | + $(".submit_note").enable(); |
33 | }) | 36 | }) |
34 | 37 | ||
35 | disableButtonIfEmptyField(".note-text", ".submit_note"); | 38 | disableButtonIfEmptyField(".note-text", ".submit_note"); |
@@ -154,6 +157,8 @@ var NoteList = { | @@ -154,6 +157,8 @@ var NoteList = { | ||
154 | if (!this.reversed) { | 157 | if (!this.reversed) { |
155 | this.initRefreshNew(); | 158 | this.initRefreshNew(); |
156 | } | 159 | } |
160 | + // make sure we are up to date | ||
161 | + this.updateVotes(); | ||
157 | }, | 162 | }, |
158 | 163 | ||
159 | 164 | ||
@@ -193,6 +198,7 @@ var NoteList = { | @@ -193,6 +198,7 @@ var NoteList = { | ||
193 | replaceNewNotes: | 198 | replaceNewNotes: |
194 | function(html) { | 199 | function(html) { |
195 | $("#new-notes-list").html(html); | 200 | $("#new-notes-list").html(html); |
201 | + this.updateVotes(); | ||
196 | }, | 202 | }, |
197 | 203 | ||
198 | /** | 204 | /** |
@@ -205,6 +211,37 @@ var NoteList = { | @@ -205,6 +211,37 @@ var NoteList = { | ||
205 | } else { | 211 | } else { |
206 | $("#new-notes-list").append(html); | 212 | $("#new-notes-list").append(html); |
207 | } | 213 | } |
214 | + this.updateVotes(); | ||
215 | + }, | ||
216 | + | ||
217 | + /** | ||
218 | + * Recalculates the votes and updates them (if they are displayed at all). | ||
219 | + * | ||
220 | + * Assumes all relevant notes are displayed (i.e. there are no more notes to | ||
221 | + * load via getMore()). | ||
222 | + * Might produce inaccurate results when not all notes have been loaded and a | ||
223 | + * recalculation is triggered (e.g. when deleting a note). | ||
224 | + */ | ||
225 | + updateVotes: | ||
226 | + function() { | ||
227 | + var votes = $("#votes .votes"); | ||
228 | + var notes = $("#notes-list, #new-notes-list").find(".note.vote"); | ||
229 | + | ||
230 | + // only update if there is a vote display | ||
231 | + if (votes.size()) { | ||
232 | + var upvotes = notes.filter(".upvote").size(); | ||
233 | + var downvotes = notes.filter(".downvote").size(); | ||
234 | + var votesCount = upvotes + downvotes; | ||
235 | + var upvotesPercent = votesCount ? (100.0 / votesCount * upvotes) : 0; | ||
236 | + var downvotesPercent = votesCount ? (100.0 - upvotesPercent) : 0; | ||
237 | + | ||
238 | + // change vote bar lengths | ||
239 | + votes.find(".bar-success").css("width", upvotesPercent+"%"); | ||
240 | + votes.find(".bar-danger").css("width", downvotesPercent+"%"); | ||
241 | + // replace vote numbers | ||
242 | + votes.find(".upvotes").text(votes.find(".upvotes").text().replace(/\d+/, upvotes)); | ||
243 | + votes.find(".downvotes").text(votes.find(".downvotes").text().replace(/\d+/, downvotes)); | ||
244 | + } | ||
208 | } | 245 | } |
209 | }; | 246 | }; |
210 | 247 |