Commit 715eaed6aecc77512d5c3f99c9cb26c143380fdd
1 parent
73f780d6
Exists in
master
and in
4 other branches
Refactor API: project hooks
Showing
1 changed file
with
1 additions
and
5 deletions
Show diff stats
lib/api/project_hooks.rb
| ... | ... | @@ -2,6 +2,7 @@ module API |
| 2 | 2 | # Projects API |
| 3 | 3 | class ProjectHooks < Grape::API |
| 4 | 4 | before { authenticate! } |
| 5 | + before { authorize_admin_project } | |
| 5 | 6 | |
| 6 | 7 | resource :projects do |
| 7 | 8 | helpers do |
| ... | ... | @@ -20,7 +21,6 @@ module API |
| 20 | 21 | # Example Request: |
| 21 | 22 | # GET /projects/:id/hooks |
| 22 | 23 | get ":id/hooks" do |
| 23 | - authorize! :admin_project, user_project | |
| 24 | 24 | @hooks = paginate user_project.hooks |
| 25 | 25 | present @hooks, with: Entities::Hook |
| 26 | 26 | end |
| ... | ... | @@ -33,7 +33,6 @@ module API |
| 33 | 33 | # Example Request: |
| 34 | 34 | # GET /projects/:id/hooks/:hook_id |
| 35 | 35 | get ":id/hooks/:hook_id" do |
| 36 | - authorize! :admin_project, user_project | |
| 37 | 36 | @hook = user_project.hooks.find(params[:hook_id]) |
| 38 | 37 | present @hook, with: Entities::Hook |
| 39 | 38 | end |
| ... | ... | @@ -47,7 +46,6 @@ module API |
| 47 | 46 | # Example Request: |
| 48 | 47 | # POST /projects/:id/hooks |
| 49 | 48 | post ":id/hooks" do |
| 50 | - authorize! :admin_project, user_project | |
| 51 | 49 | required_attributes! [:url] |
| 52 | 50 | |
| 53 | 51 | @hook = user_project.hooks.new({"url" => params[:url]}) |
| ... | ... | @@ -71,7 +69,6 @@ module API |
| 71 | 69 | # PUT /projects/:id/hooks/:hook_id |
| 72 | 70 | put ":id/hooks/:hook_id" do |
| 73 | 71 | @hook = user_project.hooks.find(params[:hook_id]) |
| 74 | - authorize! :admin_project, user_project | |
| 75 | 72 | required_attributes! [:url] |
| 76 | 73 | |
| 77 | 74 | attrs = attributes_for_keys [:url] |
| ... | ... | @@ -93,7 +90,6 @@ module API |
| 93 | 90 | # Example Request: |
| 94 | 91 | # DELETE /projects/:id/hooks/:hook_id |
| 95 | 92 | delete ":id/hooks/:hook_id" do |
| 96 | - authorize! :admin_project, user_project | |
| 97 | 93 | required_attributes! [:hook_id] |
| 98 | 94 | |
| 99 | 95 | begin | ... | ... |