Refactor: grouping parent and their space by including array.

Sato Hiroyuki
1 parent 2f7f46b2
Showing 3 changed files with 7 additions and 5 deletions Show diff stats
app/assets/javascripts/branch-graph.js
app/helpers/graph_helper.rb
app/views/graph/show.json.erb
@@ -117,7 +117,7 @@
       // Draw lines
       for (var j = 0, jj = this.commits[i].parents.length; j < jj; j++) {
         c = this.preparedCommits[this.commits[i].parents[j][0]];
-        ps = this.commits[i].parent_spaces[j];
+        ps = this.commits[i].parents[j][1];
         if (c) {
           var cx = offsetX + 20 * c.time
             , cy = offsetY + 10 * c.space
@@ -2,4 +2,9 @@ module GraphHelper
   def join_with_space(ary)
     ary.collect{|r|r.name}.join(" ") unless ary.nil?
   end
+
+  def parents_zip_spaces(parents, parent_spaces)
+    ids = parents.map { |p| p.id }
+    ids.zip(parent_spaces)
+  end
 end
@@ -5,9 +5,7 @@
     days: @graph.days.compact.map { |d| [d.day, d.strftime("%b")] },
     commits: @graph.commits.map do |c|
       {
-        parents: c.parents.collect do |p|
-          [p.id,0,0]
-        end,
+        parents: parents_zip_spaces(c.parents, c.parent_spaces),
         author: {
           name: c.author.name,
           email: c.author.email,
@@ -15,7 +13,6 @@
         },
         time: c.time,
         space: c.spaces.first,
-        parent_spaces: c.parent_spaces,
         refs: join_with_space(c.refs),
         id: c.sha,
         date: c.date,
	@@ -117,7 +117,7 @@		@@ -117,7 +117,7 @@
117	// Draw lines	117	// Draw lines
118	for (var j = 0, jj = this.commits[i].parents.length; j < jj; j++) {	118	for (var j = 0, jj = this.commits[i].parents.length; j < jj; j++) {
119	c = this.preparedCommits[this.commits[i].parents[j][0]];	119	c = this.preparedCommits[this.commits[i].parents[j][0]];
120	- ps = this.commits[i].parent_spaces[j];	120	+ ps = this.commits[i].parents[j][1];
121	if (c) {	121	if (c) {
122	var cx = offsetX + 20 * c.time	122	var cx = offsetX + 20 * c.time
123	, cy = offsetY + 10 * c.space	123	, cy = offsetY + 10 * c.space
	@@ -2,4 +2,9 @@ module GraphHelper		@@ -2,4 +2,9 @@ module GraphHelper
2	def join_with_space(ary)	2	def join_with_space(ary)
3	ary.collect{\|r\|r.name}.join(" ") unless ary.nil?	3	ary.collect{\|r\|r.name}.join(" ") unless ary.nil?
4	end	4	end
		5	+
		6	+ def parents_zip_spaces(parents, parent_spaces)
		7	+ ids = parents.map { \|p\| p.id }
		8	+ ids.zip(parent_spaces)
		9	+ end
5	end	10	end