Auto-merge: checking via AJAX

Valery Sizov
1 parent f1454504
Showing 6 changed files with 43 additions and 10 deletions Show diff stats
app/assets/javascripts/merge_requests.js
app/controllers/merge_requests_controller.rb
app/models/merge_request.rb
app/views/merge_requests/show.html.haml
config/routes.rb
lib/gitlab_merge.rb
 var MergeRequest = { 
   diffs_loaded: false,
   commits_loaded: false,
+  opts: false,
   init:
-    function() { 
+    function(opts) {
+      this.opts = opts;
+
+      if($(".automerge_widget").lenght){
+        $.get(opts.url_to_automerge_check, function(data){
+          $(".automerge_widget").hide();
+          $(".automerge_widget." + data.state).show();
+        }, "json");
+      }
+
       $(".tabs a").live("click", function() { 
         $(".tabs a").parent().removeClass("active");
         $(this).parent().addClass("active");
@@ -2,7 +2,7 @@ class MergeRequestsController &lt; ApplicationController
   before_filter :authenticate_user!
   before_filter :project
   before_filter :module_enabled
-  before_filter :merge_request, :only => [:edit, :update, :destroy, :show, :commits, :diffs, :automerge]
+  before_filter :merge_request, :only => [:edit, :update, :destroy, :show, :commits, :diffs, :automerge, :automerge_check]
   layout "project"
   # Authorize
@@ -45,10 +45,6 @@ class MergeRequestsController &lt; ApplicationController
     # or from cache if already merged
     @commits = @merge_request.commits
-    if @merge_request.unchecked? 
-      @merge_request.check_if_can_be_merged
-    end
-
     respond_to do |format|
       format.html
       format.js
@@ -100,6 +96,13 @@ class MergeRequestsController &lt; ApplicationController
     end
   end
+  def automerge_check
+    if @merge_request.unchecked? 
+      @merge_request.check_if_can_be_merged
+    end
+    render :json => {:state => @merge_request.human_state}
+  end
+
   def automerge
     render_404 unless @merge_request.open? && @merge_request.can_be_merged?
     return access_denied! unless can?(current_user, :accept_mr, @project)
@@ -49,6 +49,15 @@ class MergeRequest &lt; ActiveRecord::Base
     where("source_branch like :branch or target_branch like :branch", :branch => branch_name)
   end
+  def human_state
+    states = {
+      CAN_BE_MERGED =>  "can_be_merged",
+      CANNOT_BE_MERGED => "cannot_be_merged",
+      UNCHECKED => "unchecked"
+    }
+    states[self.state]
+  end
+
   def validate_branches
     if target_branch == source_branch
       errors.add :base, "You can not use same branch for source and target branches"
@@ -54,18 +54,25 @@
 - if @merge_request.open? && @commits.any? && can?(current_user, :accept_mr, @project)
-  - if @merge_request.can_be_merged?
+  .automerge_widget.can_be_merged{:style => "display:none"}
     .ui-box.padded
       %p 
         You can accept this request automatically. If you still want to do it manually - #{link_to "click here", "#", :class => "how_to_merge_link vlink", :title => "How To Merge"} for instructions
       = link_to "Accept Merge Request", automerge_project_merge_request_path(@project, @merge_request), :class => "btn small info accept_merge_request", :remote => true
       &nbsp;
-        
-  - else
+      
+  .automerge_widget.cannot_be_merged{:style => "display:none"}
     .alert-message
       %p
         %strong This request cant be merged with GitLab. You should do it manually &nbsp;
         = link_to "Show how to merge", "#", :class => "how_to_merge_link btn small padded", :title => "How To Merge"
+  
+  .automerge_widget.unchecked
+    .alert-message
+      %p
+        %strong Checking for ability to automatically merge… 
+
+
 = render "merge_requests/commits"
@@ -87,7 +94,9 @@
 :javascript
   $(function(){
-    MergeRequest.init();
+    MergeRequest.init({
+      url_to_automerge_check: "#{automerge_check_project_merge_request_path(@project, @merge_request)}",
+    });
     $(".accept_merge_request").live("ajax:beforeSend", function() {
       $(this).replaceWith('#{image_tag "ajax_loader.gif"}');
@@ -103,6 +103,7 @@ Gitlab::Application.routes.draw do
       member do 
         get :diffs
         get :automerge
+        get :automerge_check
       end
       collection do 
@@ -29,6 +29,7 @@ class GitlabMerge
   def pull
     self.project.repo.git.clone({:branch => merge_request.target_branch}, project.url_to_repo, merge_path)
+    #TODO When user do not have permissions then raise exception
     Dir.chdir(merge_path) do
       merge_repo = Grit::Repo.new('.')
       merge_repo.git.sh "git config user.name \"#{user.name}\""
1	var MergeRequest = {	1	var MergeRequest = {
2	diffs_loaded: false,	2	diffs_loaded: false,
3	commits_loaded: false,	3	commits_loaded: false,
		4	+ opts: false,
4		5
5	init:	6	init:
6	- function() {	7	+ function(opts) {
		8	+ this.opts = opts;
		9	+
		10	+ if($(".automerge_widget").lenght){
		11	+ $.get(opts.url_to_automerge_check, function(data){
		12	+ $(".automerge_widget").hide();
		13	+ $(".automerge_widget." + data.state).show();
		14	+ }, "json");
		15	+ }
		16	+
7	$(".tabs a").live("click", function() {	17	$(".tabs a").live("click", function() {
8	$(".tabs a").parent().removeClass("active");	18	$(".tabs a").parent().removeClass("active");
9	$(this).parent().addClass("active");	19	$(this).parent().addClass("active");
	@@ -49,6 +49,15 @@ class MergeRequest < ActiveRecord::Base		@@ -49,6 +49,15 @@ class MergeRequest < ActiveRecord::Base
49	where("source_branch like :branch or target_branch like :branch", :branch => branch_name)	49	where("source_branch like :branch or target_branch like :branch", :branch => branch_name)
50	end	50	end
51		51
		52	+ def human_state
		53	+ states = {
		54	+ CAN_BE_MERGED => "can_be_merged",
		55	+ CANNOT_BE_MERGED => "cannot_be_merged",
		56	+ UNCHECKED => "unchecked"
		57	+ }
		58	+ states[self.state]
		59	+ end
		60	+
52	def validate_branches	61	def validate_branches
53	if target_branch == source_branch	62	if target_branch == source_branch
54	errors.add :base, "You can not use same branch for source and target branches"	63	errors.add :base, "You can not use same branch for source and target branches"
	@@ -103,6 +103,7 @@ Gitlab::Application.routes.draw do		@@ -103,6 +103,7 @@ Gitlab::Application.routes.draw do
103	member do	103	member do
104	get :diffs	104	get :diffs
105	get :automerge	105	get :automerge
		106	+ get :automerge_check
106	end	107	end
107		108
108	collection do	109	collection do
	@@ -29,6 +29,7 @@ class GitlabMerge		@@ -29,6 +29,7 @@ class GitlabMerge
29		29
30	def pull	30	def pull
31	self.project.repo.git.clone({:branch => merge_request.target_branch}, project.url_to_repo, merge_path)	31	self.project.repo.git.clone({:branch => merge_request.target_branch}, project.url_to_repo, merge_path)
		32	+ #TODO When user do not have permissions then raise exception
32	Dir.chdir(merge_path) do	33	Dir.chdir(merge_path) do
33	merge_repo = Grit::Repo.new('.')	34	merge_repo = Grit::Repo.new('.')
34	merge_repo.git.sh "git config user.name \"#{user.name}\""	35	merge_repo.git.sh "git config user.name \"#{user.name}\""