Merge pull request #1323 from tsigo/factory_girl

FactoryGirl and spec cleanup

Merge pull request #1323 from tsigo/factory_girl
FactoryGirl and spec cleanup
Dmitriy Zaporozhets
2 parents b03ee466 1dda0848
Showing 23 changed files with 326 additions and 284 deletions Show diff stats
Gemfile
Gemfile.lock
db/fixtures/test/001_repo.rb
db/pkey.example
features/step_definitions/dashboard_steps.rb
features/support/env.rb
spec/factories.rb
spec/factories_spec.rb
spec/factory.rb
spec/helpers/gitlab_flavored_markdown_spec.rb
spec/models/issue_spec.rb
spec/models/key_spec.rb
spec/models/merge_request_spec.rb
spec/models/milestone_spec.rb
spec/models/note_spec.rb
spec/models/project_spec.rb
spec/models/system_hook_spec.rb
spec/models/user_spec.rb
spec/requests/admin/admin_projects_spec.rb
spec/requests/atom/dashboard_issues_spec.rb
@@ -107,6 +107,7 @@ group :development, :test do
   gem "awesome_print"
   gem "database_cleaner"
   gem "launchy"
+  gem 'factory_girl_rails'
 end
 group :test do
@@ -166,6 +166,11 @@ GEM
     eventmachine (0.12.10)
     execjs (1.4.0)
       multi_json (~> 1.0)
+    factory_girl (4.0.0)
+      activesupport (>= 3.0.0)
+    factory_girl_rails (4.0.0)
+      factory_girl (~> 4.0.0)
+      railties (>= 3.0.0)
     ffaker (1.14.0)
     ffi (1.0.11)
     foreman (0.47.0)
@@ -388,6 +393,7 @@ DEPENDENCIES
   devise (~> 2.1.0)
   draper
   email_spec
+  factory_girl_rails
   ffaker
   foreman
   git
-# create tmp dir if not exist
-tmp_dir = File.join(Rails.root, "tmp")
-Dir.mkdir(tmp_dir) unless File.exists?(tmp_dir)
-
-# Create dir for test repo
-repo_dir = File.join(Rails.root, "tmp", "tests")
-Dir.mkdir(repo_dir) unless File.exists?(repo_dir)
-
-`cp spec/seed_project.tar.gz tmp/tests/`
-Dir.chdir(repo_dir)
-`tar -xf seed_project.tar.gz`
-3.times do |i|
-`cp -r gitlabhq/ gitlabhq_#{i}/`
-puts "Unpacked seed repo - tmp/tests/gitlabhq_#{i}"
+require 'fileutils'
+
+print "Unpacking seed repository..."
+
+SEED_REPO = 'seed_project.tar.gz'
+REPO_PATH = File.join(Rails.root, 'tmp', 'repositories')
+
+# Make whatever directories we need to make
+FileUtils.mkdir_p(REPO_PATH)
+
+# Copy the archive to the repo path
+FileUtils.cp(File.join(Rails.root, 'spec', SEED_REPO), REPO_PATH)
+
+# chdir to the repo path
+FileUtils.cd(REPO_PATH) do
+  # Extract the archive
+  `tar -xf #{SEED_REPO}`
+
+  # Remove the copy
+  FileUtils.rm(SEED_REPO)
 end
+
+puts ' done.'
@@ -1,3 +0,0 @@
-AAAAB3NzaC1yc2EAAAABJQAAAIEAiPWx6WM4lhHNedGfBpPJNPpZ7yKu+dnn1SJejgt4
-596k6YjzGGphH2TUxwKzxcKDKKezwkpfnxPkSMkuEspGRt/aZZ9wa++Oi7Qkr8prgHc4
-soW6NUlfDzpvZK2H5E7eQaSeP3SAwGmQKUFHCddNaP0L+hM7zhFNzjFvpaMgJw0=
@@ -106,13 +106,9 @@ Given /^I have assigned issues$/ do
 end
 Given /^I have authored merge requests$/ do
-  project1 = Factory :project,
-   :path => "gitlabhq_1",
-   :code => "gitlabhq_1"
+  project1 = Factory :project
-  project2 = Factory :project,
-   :path => "gitlabhq_2",
-   :code => "gitlabhq_2"
+  project2 = Factory :project
   project1.add_access(@user, :read, :write)
   project2.add_access(@user, :read, :write)
@@ -8,9 +8,8 @@ require &#39;webmock/cucumber&#39;
 WebMock.allow_net_connect!
-require Rails.root.join 'spec/factories'
-require Rails.root.join 'spec/support/monkeypatch'
 require Rails.root.join 'spec/support/gitolite_stub'
+require Rails.root.join 'spec/support/stubbed_repository'
 require Rails.root.join 'spec/support/login_helpers'
 require Rails.root.join 'spec/support/valid_commit'
@@ -53,6 +52,8 @@ require &#39;cucumber/rspec/doubles&#39;
 include GitoliteStub
-Before do 
+Before do
   stub_gitolite!
 end
+
+World(FactoryGirl::Syntax::Methods)
-require File.join(Rails.root, 'spec', 'factory')
-
-Factory.add(:project, Project) do |obj|
-  obj.name = Faker::Internet.user_name
-  obj.path = 'gitlabhq'
-  obj.owner = Factory(:user)
-  obj.code = 'LGT'
-end
-
-Factory.add(:project_without_owner, Project) do |obj|
-  obj.name = Faker::Internet.user_name
-  obj.path = 'gitlabhq'
-  obj.code = 'LGT'
-end
-
-Factory.add(:public_project, Project) do |obj|
-  obj.name = Faker::Internet.user_name
-  obj.path = 'gitlabhq'
-  obj.private_flag = false
-  obj.owner = Factory(:user)
-  obj.code = 'LGT'
-end
-
-Factory.add(:user, User) do |obj|
-  obj.email = Faker::Internet.email
-  obj.password = "123456"
-  obj.name = Faker::Name.name
-  obj.password_confirmation = "123456"
-end
-
-Factory.add(:admin, User) do |obj|
-  obj.email = Faker::Internet.email
-  obj.password = "123456"
-  obj.name = Faker::Name.name
-  obj.password_confirmation = "123456"
-  obj.admin = true
-end
-
-Factory.add(:issue, Issue) do |obj|
-  obj.title = Faker::Lorem.sentence
-  obj.author = Factory :user
-  obj.assignee = Factory :user
-end
-
-Factory.add(:merge_request, MergeRequest) do |obj|
-  obj.title = Faker::Lorem.sentence
-  obj.author = Factory :user
-  obj.assignee = Factory :user
-  obj.source_branch = "master"
-  obj.target_branch = "stable"
-  obj.closed = false
-end
-
-Factory.add(:snippet, Snippet) do |obj|
-  obj.title = Faker::Lorem.sentence
-  obj.file_name = Faker::Lorem.sentence
-  obj.content = Faker::Lorem.sentences
-end
-
-Factory.add(:note, Note) do |obj|
-  obj.note = Faker::Lorem.sentence
-end
-
-Factory.add(:key, Key) do |obj|
-  obj.title = "Example key"
-  obj.key = File.read(File.join(Rails.root, "db", "pkey.example"))
-end
-
-Factory.add(:project_hook, ProjectHook) do |obj|
-  obj.url = Faker::Internet.uri("http")
-end
-
-Factory.add(:system_hook, SystemHook) do |obj|
-  obj.url = Faker::Internet.uri("http")
-end
-
-Factory.add(:wiki, Wiki) do |obj|
-  obj.title = Faker::Lorem.sentence
-  obj.content = Faker::Lorem.sentence
-  obj.user = Factory(:user)
-  obj.project = Factory(:project)
-end
-
-Factory.add(:event, Event) do |obj|
-  obj.title = Faker::Lorem.sentence
-  obj.project = Factory(:project)
-end
-
-Factory.add(:milestone, Milestone) do |obj|
-  obj.title = Faker::Lorem.sentence
-  obj.due_date = Date.today + 1.month
-end
-
-Factory.add(:users_project, UsersProject) do |obj|
-  obj.user = Factory :user
-  obj.project = Factory :project
+# Backwards compatibility with the old method
+def Factory(type, *args)
+  FactoryGirl.create(type, *args)
+end
+
+module Factory
+  def self.create(type, *args)
+    FactoryGirl.create(type, *args)
+  end
+
+  def self.new(type, *args)
+    FactoryGirl.build(type, *args)
+  end
+end
+
+FactoryGirl.define do
+  sequence :sentence, aliases: [:title, :content] do
+    Faker::Lorem.sentence
+  end
+
+  sequence(:url) { Faker::Internet.uri('http') }
+
+  factory :user, aliases: [:author, :assignee, :owner] do
+    email { Faker::Internet.email }
+    name  { Faker::Name.name }
+    password "123456"
+    password_confirmation "123456"
+
+    trait :admin do
+      admin true
+    end
+
+    factory :admin, traits: [:admin]
+  end
+
+  factory :project do
+    sequence(:name) { |n| "project#{n}" }
+    path { name }
+    code { name }
+    owner
+  end
+
+  factory :users_project do
+    user
+    project
+  end
+
+  factory :issue do
+    title
+    author
+    project
+
+    trait :closed do
+      closed true
+    end
+
+    factory :closed_issue, traits: [:closed]
+  end
+
+  factory :merge_request do
+    title
+    author
+    project
+    source_branch "master"
+    target_branch "stable"
+  end
+
+  factory :note do
+    project
+    note "Note"
+  end
+
+  factory :event do
+  end
+
+  factory :key do
+    title
+    key do
+      """
+      AAAAB3NzaC1yc2EAAAABJQAAAIEAiPWx6WM4lhHNedGfBpPJNPpZ7yKu+dnn1SJejgt4
+      596k6YjzGGphH2TUxwKzxcKDKKezwkpfnxPkSMkuEspGRt/aZZ9wa++Oi7Qkr8prgHc4
+      soW6NUlfDzpvZK2H5E7eQaSeP3SAwGmQKUFHCddNaP0L+hM7zhFNzjFvpaMgJw0=
+      """
+    end
+
+    factory :deploy_key do
+      project
+    end
+
+    factory :personal_key do
+      user
+    end
+  end
+
+  factory :milestone do
+    title
+    project
+  end
+
+  factory :system_hook do
+    url
+  end
+
+  factory :project_hook do
+    url
+  end
+
+  factory :wiki do
+    title
+    content
+    user
+  end
+
+  factory :snippet do
+    project
+    author
+    title
+    content
+    file_name { Faker::Lorem.sentence }
+  end
 end
@@ -0,0 +1,91 @@
+require 'spec_helper'
+
+describe "Factories" do
+  describe 'User' do
+    it "builds a valid instance" do
+      build(:user).should be_valid
+    end
+
+    it "builds a valid admin instance" do
+      build(:admin).should be_valid
+    end
+  end
+
+  describe 'Project' do
+    it "builds a valid instance" do
+      build(:project).should be_valid
+    end
+  end
+
+  describe 'Issue' do
+    it "builds a valid instance" do
+      build(:issue).should be_valid
+    end
+
+    it "builds a valid closed instance" do
+      build(:closed_issue).should be_valid
+    end
+  end
+
+  describe 'MergeRequest' do
+    it "builds a valid instance" do
+      build(:merge_request).should be_valid
+    end
+  end
+
+  describe 'Note' do
+    it "builds a valid instance" do
+      build(:note).should be_valid
+    end
+  end
+
+  describe 'Event' do
+    it "builds a valid instance" do
+      build(:event).should be_valid
+    end
+  end
+
+  describe 'Key' do
+    it "builds a valid instance" do
+      build(:key).should be_valid
+    end
+
+    it "builds a valid deploy key instance" do
+      build(:deploy_key).should be_valid
+    end
+
+    it "builds a valid personal key instance" do
+      build(:personal_key).should be_valid
+    end
+  end
+
+  describe 'Milestone' do
+    it "builds a valid instance" do
+      build(:milestone).should be_valid
+    end
+  end
+
+  describe 'SystemHook' do
+    it "builds a valid instance" do
+      build(:system_hook).should be_valid
+    end
+  end
+
+  describe 'ProjectHook' do
+    it "builds a valid instance" do
+      build(:project_hook).should be_valid
+    end
+  end
+
+  describe 'Wiki' do
+    it "builds a valid instance" do
+      build(:wiki).should be_valid
+    end
+  end
+
+  describe 'Snippet' do
+    it "builds a valid instance" do
+      build(:snippet).should be_valid
+    end
+  end
+end
@@ -1,29 +0,0 @@
-class Factory
-  @factories = {}
-
-  class << self
-    def add(name, klass, &block)
-      @factories[name] = [klass, block]
-    end
-
-    def create(name, opts = {})
-      new(name, opts).tap(&:save!)
-    end
-
-    def new(name, opts = {})
-      factory= @factories[name]
-      factory[0].new.tap do |obj|
-        factory[1].call(obj)
-      end.tap do |obj|
-        opts.each do |k, opt|
-          obj.send("#{k}=", opt)
-        end
-      end
-    end
-  end
-end
-
-def Factory(name, opts={})
-  Factory.create name, opts
-end
-
@@ -2,7 +2,7 @@ require &quot;spec_helper&quot;
 describe GitlabMarkdownHelper do
   before do
-    @project = Project.find_by_path("gitlabhq") || Factory(:project)
+    @project = Factory(:project)
     @commit = @project.repo.commits.first.parents.first
     @commit = CommitDecorator.decorate(Commit.new(@commit))
     @other_project = Factory :project, path: "OtherPath", code: "OtherCode"
@@ -157,7 +157,7 @@ describe GitlabMarkdownHelper do
       gfm("Let @#{user.name} fix the *mess* in #{@commit.id}").should == "Let #{link_to "@#{user.name}", project_team_member_path(@project, member), class: "gfm gfm-team_member "} fix the *mess* in #{link_to @commit.id, project_commit_path(@project, id: @commit.id), title: "Commit: #{@commit.author_name} - #{@commit.title}", class: "gfm gfm-commit "}"
     end
-    it "should not trip over other stuff", focus: true do
+    it "should not trip over other stuff" do
       gfm("_Please_ *stop* 'helping' and all the other b*$#%' you do.").should == "_Please_ *stop* 'helping' and all the other b*$#%' you do."
     end
@@ -19,11 +19,7 @@ describe Issue do
     it { Issue.should respond_to :opened }
   end
-  subject { Factory.create(:issue,
-                           author: Factory(:user),
-                           assignee: Factory(:user),
-                           project: Factory.create(:project)) }
-  it { should be_valid }
+  subject { Factory.create(:issue) }
   describe '#is_being_reassigned?' do
     it 'returns true if the issue assignee has changed' do
@@ -41,11 +37,7 @@ describe Issue do
       subject.is_being_closed?.should be_true
     end
     it 'returns false if the closed attribute has changed and is now false' do
-      issue = Factory.create(:issue,
-                             closed: true,
-                             author: Factory(:user),
-                             assignee: Factory(:user),
-                             project: Factory.create(:project))
+      issue = Factory.create(:closed_issue)
       issue.closed = false
       issue.is_being_closed?.should be_false
     end
@@ -57,11 +49,7 @@ describe Issue do
   describe '#is_being_reopened?' do
     it 'returns true if the closed attribute has changed and is now false' do
-      issue = Factory.create(:issue,
-                             closed: true,
-                             author: Factory(:user),
-                             assignee: Factory(:user),
-                             project: Factory.create(:project))
+      issue = Factory.create(:closed_issue)
       issue.closed = false
       issue.is_being_reopened?.should be_true
     end
@@ -75,40 +63,33 @@ describe Issue do
   end
   describe "plus 1" do
-    let(:project) { Factory(:project) }
-    subject {
-      Factory.create(:issue,
-                     author: Factory(:user),
-                     assignee: Factory(:user),
-                     project: project)
-    }
+    subject { Factory.create(:issue) }
     it "with no notes has a 0/0 score" do
       subject.upvotes.should == 0
     end
     it "should recognize non-+1 notes" do
-      subject.notes << Factory(:note, note: "No +1 here", project: Factory(:project, path: 'plusone', code: 'plusone'))
+      subject.notes << Factory(:note, note: "No +1 here")
       subject.should have(1).note
       subject.notes.first.upvote?.should be_false
       subject.upvotes.should == 0
     end
     it "should recognize a single +1 note" do
-      subject.notes << Factory(:note, note: "+1 This is awesome", project: Factory(:project, path: 'plusone', code: 'plusone'))
+      subject.notes << Factory(:note, note: "+1 This is awesome")
       subject.upvotes.should == 1
     end
     it "should recognize a multiple +1 notes" do
-      subject.notes << Factory(:note, note: "+1 This is awesome", project: Factory(:project, path: 'plusone', code: 'plusone'))
-      subject.notes << Factory(:note, note: "+1 I want this", project: Factory(:project, path: 'plustwo', code: 'plustwo'))
+      subject.notes << Factory(:note, note: "+1 This is awesome")
+      subject.notes << Factory(:note, note: "+1 I want this")
       subject.upvotes.should == 2
     end
   end
   describe ".search" do
-    let!(:issue) { Factory.create(:issue, title: "Searchable issue",
-                                 project: Factory.create(:project)) }
+    let!(:issue) { Factory.create(:issue, title: "Searchable issue") }
     it "matches by title" do
       Issue.search('able').all.should == [issue]
@@ -17,20 +17,15 @@ describe Key do
   context "validation of uniqueness" do
     context "as a deploy key" do
-      let(:project) { Factory.create(:project, path: 'alpha', code: 'alpha') }
-      let(:another_project) { Factory.create(:project, path: 'beta', code: 'beta') }
-
-      before do
-        deploy_key = Factory.create(:key, project: project)
-      end
+      let!(:deploy_key) { create(:deploy_key) }
       it "does not accept the same key twice for a project" do
-        key = Factory.new(:key, project: project)
+        key = build(:key, project: deploy_key.project)
         key.should_not be_valid
       end
       it "does accept the same key for another project" do
-        key = Factory.new(:key, project: another_project)
+        key = build(:key, project_id: 0)
         key.should be_valid
       end
     end
@@ -39,12 +34,12 @@ describe Key do
       let(:user) { Factory.create(:user) }
       it "accepts the key once" do
-        Factory.new(:key, user: user).should be_valid
+        build(:key, user: user).should be_valid
       end
       it "does not accepts the key twice" do
-        Factory.create(:key, user: user)
-        Factory.new(:key, user: user).should_not be_valid
+        create(:key, user: user)
+        build(:key, user: user).should_not be_valid
       end
     end
   end
@@ -20,46 +20,34 @@ describe MergeRequest do
     it { MergeRequest.should respond_to :opened }
   end
-  it { Factory.create(:merge_request,
-                      author: Factory(:user),
-                      assignee: Factory(:user),
-                      project: Factory.create(:project)).should be_valid }
-
   describe "plus 1" do
-    let(:project) { Factory(:project) }
-    subject {
-      Factory.create(:merge_request,
-                     author: Factory(:user),
-                     assignee: Factory(:user),
-                     project: project)
-    }
+    subject { Factory.create(:merge_request) }
     it "with no notes has a 0/0 score" do
       subject.upvotes.should == 0
     end
     it "should recognize non-+1 notes" do
-      subject.notes << Factory(:note, note: "No +1 here", project: Factory(:project, path: 'plusone', code: 'plusone'))
+      subject.notes << Factory(:note, note: "No +1 here")
       subject.should have(1).note
       subject.notes.first.upvote?.should be_false
       subject.upvotes.should == 0
     end
     it "should recognize a single +1 note" do
-      subject.notes << Factory(:note, note: "+1 This is awesome", project: Factory(:project, path: 'plusone', code: 'plusone'))
+      subject.notes << Factory(:note, note: "+1 This is awesome")
       subject.upvotes.should == 1
     end
     it "should recognize a multiple +1 notes" do
-      subject.notes << Factory(:note, note: "+1 This is awesome", project: Factory(:project, path: 'plusone', code: 'plusone'))
-      subject.notes << Factory(:note, note: "+1 I want this", project: Factory(:project, path: 'plustwo', code: 'plustwo'))
+      subject.notes << Factory(:note, note: "+1 This is awesome")
+      subject.notes << Factory(:note, note: "+1 I want this")
       subject.upvotes.should == 2
     end
   end
   describe ".search" do
-    let!(:issue) { Factory.create(:issue, title: "Searchable issue",
-                                 project: Factory.create(:project)) }
+    let!(:issue) { Factory.create(:issue, title: "Searchable issue") }
     it "matches by title" do
       Issue.search('able').all.should == [issue]
@@ -25,11 +25,8 @@ describe Milestone do
     it { should validate_presence_of(:project_id) }
   end
-  let(:project) { Factory :project }
-  let(:milestone) { Factory :milestone, project: project }
-  let(:issue) { Factory :issue, project: project }
-
-  it { milestone.should be_valid }
+  let(:milestone) { Factory :milestone }
+  let(:issue) { Factory :issue }
   describe "#percent_complete" do
     it "should not count open issues" do
 require 'spec_helper'
 describe Note do
-  let(:project) { Factory :project }
-  let!(:commit) { project.commit }
-
   describe "Associations" do
     it { should belong_to(:project) }
   end
@@ -13,8 +10,6 @@ describe Note do
     it { should validate_presence_of(:project) }
   end
-  it { Factory.create(:note,
-                      project: project).should be_valid }
   describe "Scopes" do
     it "should have a today named scope that returns ..." do
       Note.today.where_values.should == ["created_at >= '#{Date.today}'"]
@@ -25,26 +20,27 @@ describe Note do
     let(:project) { Factory(:project) }
     it "recognizes a neutral note" do
-      note = Factory(:note, project: project, note: "This is not a +1 note")
+      note = Factory(:note, note: "This is not a +1 note")
       note.should_not be_upvote
     end
     it "recognizes a +1 note" do
-      note = Factory(:note, project: project, note: "+1 for this")
+      note = Factory(:note, note: "+1 for this")
       note.should be_upvote
     end
     it "recognizes a -1 note as no vote" do
-      note = Factory(:note, project: project, note: "-1 for this")
+      note = Factory(:note, note: "-1 for this")
       note.should_not be_upvote
     end
   end
-  describe "Commit notes" do
+  let(:project) { create(:project) }
+  let(:commit) { project.commit }
+  describe "Commit notes" do
     before do
       @note = Factory :note,
-        project: project,
         noteable_id: commit.id,
         noteable_type: "Commit"
     end
@@ -58,7 +54,6 @@ describe Note do
   describe "Pre-line commit notes" do
     before do
       @note = Factory :note,
-        project: project,
         noteable_id: commit.id,
         noteable_type: "Commit",
         line_code: "0_16_1"
@@ -91,8 +86,8 @@ describe Note do
   describe :authorization do
     before do
-      @p1 = project
-      @p2 = Factory :project, code: "alien", path: "gitlabhq_1"
+      @p1 = create(:project)
+      @p2 = Factory :project
       @u1 = Factory :user
       @u2 = Factory :user
       @u3 = Factory :user
@@ -85,7 +85,7 @@ describe Project do
   it "should return path to repo" do
     project = Project.new(path: "somewhere")
-    project.path_to_repo.should == File.join(Rails.root, "tmp", "tests", "somewhere")
+    project.path_to_repo.should == File.join(Rails.root, "tmp", "repositories", "somewhere")
   end
   it "returns the full web URL for this repo" do
@@ -10,13 +10,12 @@ describe SystemHook do
     end
     it "project_create hook" do
-      user = Factory :user
       with_resque do
-        project = Factory :project_without_owner, owner: user
+        project = Factory :project
       end
       WebMock.should have_requested(:post, @system_hook.url).with(body: /project_create/).once
     end
-    
+
     it "project_destroy hook" do
       project = Factory :project
       with_resque do
@@ -31,7 +30,7 @@ describe SystemHook do
       end
       WebMock.should have_requested(:post, @system_hook.url).with(body: /user_create/).once
     end
-    
+
     it "user_destroy hook" do
       user = Factory :user
       with_resque do
@@ -39,7 +38,7 @@ describe SystemHook do
       end
       WebMock.should have_requested(:post, @system_hook.url).with(body: /user_destroy/).once
     end
-    
+
     it "project_create hook" do
       user = Factory :user
       project = Factory :project
@@ -48,7 +47,7 @@ describe SystemHook do
       end
       WebMock.should have_requested(:post, @system_hook.url).with(body: /user_add_to_team/).once
     end
-    
+
     it "project_destroy hook" do
       user = Factory :user
       project = Factory :project
@@ -3,11 +3,12 @@ require &#39;spec_helper&#39;
 describe User do
   describe "Associations" do
     it { should have_many(:projects) }
-    it { should have_many(:users_projects) }
-    it { should have_many(:issues) }
-    it { should have_many(:assigned_issues) }
-    it { should have_many(:merge_requests) }
-    it { should have_many(:assigned_merge_requests) }
+    it { should have_many(:users_projects).dependent(:destroy) }
+    it { should have_many(:issues).dependent(:destroy) }
+    it { should have_many(:assigned_issues).dependent(:destroy) }
+    it { should have_many(:merge_requests).dependent(:destroy) }
+    it { should have_many(:assigned_merge_requests).dependent(:destroy) }
+    it { should have_many(:notes).dependent(:destroy) }
   end
   describe "Respond to" do
@@ -49,21 +50,6 @@ describe User do
     user = Factory(:user)
     user.authentication_token.should_not == ""
   end
-
-  describe "dependent" do
-    before do
-      @user = Factory :user
-      @note = Factory :note,
-        author: @user,
-        project: Factory(:project)
-    end
-
-    it "should destroy all notes with user" do
-      Note.find_by_id(@note.id).should_not be_nil
-      @user.destroy
-      Note.find_by_id(@note.id).should be_nil
-    end
-  end
 end
 # == Schema Information
 #
@@ -87,7 +87,7 @@ describe &quot;Admin::Projects&quot; do
       visit new_admin_project_path
       fill_in 'project_name', with: 'NewProject'
       fill_in 'project_code', with: 'NPR'
-      fill_in 'project_path', with: 'gitlabhq_1'
+      fill_in 'project_path', with: 'newproject'
       expect { click_button "Create project" }.to change { Project.count }.by(1)
       @project = Project.last
     end
@@ -6,13 +6,9 @@ describe &quot;User Issues Dashboard&quot; do
       login_as :user
-      @project1 = Factory :project,
-        path: "gitlabhq_0",
-        code: "TEST1"
+      @project1 = Factory :project
-      @project2 = Factory :project,
-        path: "gitlabhq_1",
-        code: "TEST2"
+      @project2 = Factory :project
       @project1.add_access(@user, :read, :write)
       @project2.add_access(@user, :read, :write)
@@ -10,7 +10,6 @@ require &#39;rspec/rails&#39;
 require 'capybara/rails'
 require 'capybara/rspec'
 require 'webmock/rspec'
-require 'factories'
 require 'email_spec'
 require 'headless'
@@ -28,6 +27,7 @@ RSpec.configure do |config|
   config.include LoginHelpers, type: :request
   config.include GitoliteStub
+  config.include FactoryGirl::Syntax::Methods
   # If you're not using ActiveRecord, or you'd prefer not to run each of your
   # examples within a transaction, remove the following line or assign false
@@ -1,21 +0,0 @@
-# Stubbing Project <-> git host path
-# create project using Factory only
-class Project
-  def path_to_repo
-    File.join(Rails.root, "tmp", "tests", path)
-  end
-
-  def satellite
-    @satellite ||= FakeSatellite.new
-  end
-end
-
-class FakeSatellite
-  def exists?
-    true
-  end
-
-  def create
-    true
-  end
-end
@@ -0,0 +1,31 @@
+# Stubs out all Git repository access done by models so that specs can run
+# against fake repositories without Grit complaining that they don't exist.
+module StubbedRepository
+  def path_to_repo
+    if new_record? || path == 'newproject'
+      # There are a couple Project specs and features that expect the Project's
+      # path to be in the returned path, so let's patronize them.
+      File.join(Rails.root, 'tmp', 'repositories', path)
+    else
+      # For everything else, just give it the path to one of our real seeded
+      # repos.
+      File.join(Rails.root, 'tmp', 'repositories', 'gitlabhq')
+    end
+  end
+
+  def satellite
+    FakeSatellite.new
+  end
+
+  class FakeSatellite
+    def exists?
+      true
+    end
+
+    def create
+      true
+    end
+  end
+end
+
+Project.send(:include, StubbedRepository)
	@@ -107,6 +107,7 @@ group :development, :test do		@@ -107,6 +107,7 @@ group :development, :test do
107	gem "awesome_print"	107	gem "awesome_print"
108	gem "database_cleaner"	108	gem "database_cleaner"
109	gem "launchy"	109	gem "launchy"
		110	+ gem 'factory_girl_rails'
110	end	111	end
111		112
112	group :test do	113	group :test do
	@@ -166,6 +166,11 @@ GEM		@@ -166,6 +166,11 @@ GEM
166	eventmachine (0.12.10)	166	eventmachine (0.12.10)
167	execjs (1.4.0)	167	execjs (1.4.0)
168	multi_json (~> 1.0)	168	multi_json (~> 1.0)
		169	+ factory_girl (4.0.0)
		170	+ activesupport (>= 3.0.0)
		171	+ factory_girl_rails (4.0.0)
		172	+ factory_girl (~> 4.0.0)
		173	+ railties (>= 3.0.0)
169	ffaker (1.14.0)	174	ffaker (1.14.0)
170	ffi (1.0.11)	175	ffi (1.0.11)
171	foreman (0.47.0)	176	foreman (0.47.0)
	@@ -388,6 +393,7 @@ DEPENDENCIES		@@ -388,6 +393,7 @@ DEPENDENCIES
388	devise (~> 2.1.0)	393	devise (~> 2.1.0)
389	draper	394	draper
390	email_spec	395	email_spec
		396	+ factory_girl_rails
391	ffaker	397	ffaker
392	foreman	398	foreman
393	git	399	git
1	-# create tmp dir if not exist
2	-tmp_dir = File.join(Rails.root, "tmp")
3	-Dir.mkdir(tmp_dir) unless File.exists?(tmp_dir)
4	-
5	-# Create dir for test repo
6	-repo_dir = File.join(Rails.root, "tmp", "tests")
7	-Dir.mkdir(repo_dir) unless File.exists?(repo_dir)
8	-
9	-`cp spec/seed_project.tar.gz tmp/tests/`
10	-Dir.chdir(repo_dir)
11	-`tar -xf seed_project.tar.gz`
12	-3.times do \|i\|
13	-`cp -r gitlabhq/ gitlabhq_#{i}/`
14	-puts "Unpacked seed repo - tmp/tests/gitlabhq_#{i}"	1	+require 'fileutils'
		2	+
		3	+print "Unpacking seed repository..."
		4	+
		5	+SEED_REPO = 'seed_project.tar.gz'
		6	+REPO_PATH = File.join(Rails.root, 'tmp', 'repositories')
		7	+
		8	+# Make whatever directories we need to make
		9	+FileUtils.mkdir_p(REPO_PATH)
		10	+
		11	+# Copy the archive to the repo path
		12	+FileUtils.cp(File.join(Rails.root, 'spec', SEED_REPO), REPO_PATH)
		13	+
		14	+# chdir to the repo path
		15	+FileUtils.cd(REPO_PATH) do
		16	+ # Extract the archive
		17	+ `tar -xf #{SEED_REPO}`
		18	+
		19	+ # Remove the copy
		20	+ FileUtils.rm(SEED_REPO)
15	end	21	end
		22	+
		23	+puts ' done.'
	@@ -1,3 +0,0 @@	@@ -1,3 +0,0 @@
1	-AAAAB3NzaC1yc2EAAAABJQAAAIEAiPWx6WM4lhHNedGfBpPJNPpZ7yKu+dnn1SJejgt4
2	-596k6YjzGGphH2TUxwKzxcKDKKezwkpfnxPkSMkuEspGRt/aZZ9wa++Oi7Qkr8prgHc4
3	-soW6NUlfDzpvZK2H5E7eQaSeP3SAwGmQKUFHCddNaP0L+hM7zhFNzjFvpaMgJw0=
1	-require File.join(Rails.root, 'spec', 'factory')
2	-
3	-Factory.add(:project, Project) do \|obj\|
4	- obj.name = Faker::Internet.user_name
5	- obj.path = 'gitlabhq'
6	- obj.owner = Factory(:user)
7	- obj.code = 'LGT'
8	-end
9	-
10	-Factory.add(:project_without_owner, Project) do \|obj\|
11	- obj.name = Faker::Internet.user_name
12	- obj.path = 'gitlabhq'
13	- obj.code = 'LGT'
14	-end
15	-
16	-Factory.add(:public_project, Project) do \|obj\|
17	- obj.name = Faker::Internet.user_name
18	- obj.path = 'gitlabhq'
19	- obj.private_flag = false
20	- obj.owner = Factory(:user)
21	- obj.code = 'LGT'
22	-end
23	-
24	-Factory.add(:user, User) do \|obj\|
25	- obj.email = Faker::Internet.email
26	- obj.password = "123456"
27	- obj.name = Faker::Name.name
28	- obj.password_confirmation = "123456"
29	-end
30	-
31	-Factory.add(:admin, User) do \|obj\|
32	- obj.email = Faker::Internet.email
33	- obj.password = "123456"
34	- obj.name = Faker::Name.name
35	- obj.password_confirmation = "123456"
36	- obj.admin = true
37	-end
38	-
39	-Factory.add(:issue, Issue) do \|obj\|
40	- obj.title = Faker::Lorem.sentence
41	- obj.author = Factory :user
42	- obj.assignee = Factory :user
43	-end
44	-
45	-Factory.add(:merge_request, MergeRequest) do \|obj\|
46	- obj.title = Faker::Lorem.sentence
47	- obj.author = Factory :user
48	- obj.assignee = Factory :user
49	- obj.source_branch = "master"
50	- obj.target_branch = "stable"
51	- obj.closed = false
52	-end
53	-
54	-Factory.add(:snippet, Snippet) do \|obj\|
55	- obj.title = Faker::Lorem.sentence
56	- obj.file_name = Faker::Lorem.sentence
57	- obj.content = Faker::Lorem.sentences
58	-end
59	-
60	-Factory.add(:note, Note) do \|obj\|
61	- obj.note = Faker::Lorem.sentence
62	-end
63	-
64	-Factory.add(:key, Key) do \|obj\|
65	- obj.title = "Example key"
66	- obj.key = File.read(File.join(Rails.root, "db", "pkey.example"))
67	-end
68	-
69	-Factory.add(:project_hook, ProjectHook) do \|obj\|
70	- obj.url = Faker::Internet.uri("http")
71	-end
72	-
73	-Factory.add(:system_hook, SystemHook) do \|obj\|
74	- obj.url = Faker::Internet.uri("http")
75	-end
76	-
77	-Factory.add(:wiki, Wiki) do \|obj\|
78	- obj.title = Faker::Lorem.sentence
79	- obj.content = Faker::Lorem.sentence
80	- obj.user = Factory(:user)
81	- obj.project = Factory(:project)
82	-end
83	-
84	-Factory.add(:event, Event) do \|obj\|
85	- obj.title = Faker::Lorem.sentence
86	- obj.project = Factory(:project)
87	-end
88	-
89	-Factory.add(:milestone, Milestone) do \|obj\|
90	- obj.title = Faker::Lorem.sentence
91	- obj.due_date = Date.today + 1.month
92	-end
93	-
94	-Factory.add(:users_project, UsersProject) do \|obj\|
95	- obj.user = Factory :user
96	- obj.project = Factory :project	1	+# Backwards compatibility with the old method
		2	+def Factory(type, *args)
		3	+ FactoryGirl.create(type, *args)
		4	+end
		5	+
		6	+module Factory
		7	+ def self.create(type, *args)
		8	+ FactoryGirl.create(type, *args)
		9	+ end
		10	+
		11	+ def self.new(type, *args)
		12	+ FactoryGirl.build(type, *args)
		13	+ end
		14	+end
		15	+
		16	+FactoryGirl.define do
		17	+ sequence :sentence, aliases: [:title, :content] do
		18	+ Faker::Lorem.sentence
		19	+ end
		20	+
		21	+ sequence(:url) { Faker::Internet.uri('http') }
		22	+
		23	+ factory :user, aliases: [:author, :assignee, :owner] do
		24	+ email { Faker::Internet.email }
		25	+ name { Faker::Name.name }
		26	+ password "123456"
		27	+ password_confirmation "123456"
		28	+
		29	+ trait :admin do
		30	+ admin true
		31	+ end
		32	+
		33	+ factory :admin, traits: [:admin]
		34	+ end
		35	+
		36	+ factory :project do
		37	+ sequence(:name) { \|n\| "project#{n}" }
		38	+ path { name }
		39	+ code { name }
		40	+ owner
		41	+ end
		42	+
		43	+ factory :users_project do
		44	+ user
		45	+ project
		46	+ end
		47	+
		48	+ factory :issue do
		49	+ title
		50	+ author
		51	+ project
		52	+
		53	+ trait :closed do
		54	+ closed true
		55	+ end
		56	+
		57	+ factory :closed_issue, traits: [:closed]
		58	+ end
		59	+
		60	+ factory :merge_request do
		61	+ title
		62	+ author
		63	+ project
		64	+ source_branch "master"
		65	+ target_branch "stable"
		66	+ end
		67	+
		68	+ factory :note do
		69	+ project
		70	+ note "Note"
		71	+ end
		72	+
		73	+ factory :event do
		74	+ end
		75	+
		76	+ factory :key do
		77	+ title
		78	+ key do
		79	+ """
		80	+ AAAAB3NzaC1yc2EAAAABJQAAAIEAiPWx6WM4lhHNedGfBpPJNPpZ7yKu+dnn1SJejgt4
		81	+ 596k6YjzGGphH2TUxwKzxcKDKKezwkpfnxPkSMkuEspGRt/aZZ9wa++Oi7Qkr8prgHc4
		82	+ soW6NUlfDzpvZK2H5E7eQaSeP3SAwGmQKUFHCddNaP0L+hM7zhFNzjFvpaMgJw0=
		83	+ """
		84	+ end
		85	+
		86	+ factory :deploy_key do
		87	+ project
		88	+ end
		89	+
		90	+ factory :personal_key do
		91	+ user
		92	+ end
		93	+ end
		94	+
		95	+ factory :milestone do
		96	+ title
		97	+ project
		98	+ end
		99	+
		100	+ factory :system_hook do
		101	+ url
		102	+ end
		103	+
		104	+ factory :project_hook do
		105	+ url
		106	+ end
		107	+
		108	+ factory :wiki do
		109	+ title
		110	+ content
		111	+ user
		112	+ end
		113	+
		114	+ factory :snippet do
		115	+ project
		116	+ author
		117	+ title
		118	+ content
		119	+ file_name { Faker::Lorem.sentence }
		120	+ end
97	end	121	end
@@ -0,0 +1,91 @@		@@ -0,0 +1,91 @@
	1	+require 'spec_helper'
	2	+
	3	+describe "Factories" do
	4	+ describe 'User' do
	5	+ it "builds a valid instance" do
	6	+ build(:user).should be_valid
	7	+ end
	8	+
	9	+ it "builds a valid admin instance" do
	10	+ build(:admin).should be_valid
	11	+ end
	12	+ end
	13	+
	14	+ describe 'Project' do
	15	+ it "builds a valid instance" do
	16	+ build(:project).should be_valid
	17	+ end
	18	+ end
	19	+
	20	+ describe 'Issue' do
	21	+ it "builds a valid instance" do
	22	+ build(:issue).should be_valid
	23	+ end
	24	+
	25	+ it "builds a valid closed instance" do
	26	+ build(:closed_issue).should be_valid
	27	+ end
	28	+ end
	29	+
	30	+ describe 'MergeRequest' do
	31	+ it "builds a valid instance" do
	32	+ build(:merge_request).should be_valid
	33	+ end
	34	+ end
	35	+
	36	+ describe 'Note' do
	37	+ it "builds a valid instance" do
	38	+ build(:note).should be_valid
	39	+ end
	40	+ end
	41	+
	42	+ describe 'Event' do
	43	+ it "builds a valid instance" do
	44	+ build(:event).should be_valid
	45	+ end
	46	+ end
	47	+
	48	+ describe 'Key' do
	49	+ it "builds a valid instance" do
	50	+ build(:key).should be_valid
	51	+ end
	52	+
	53	+ it "builds a valid deploy key instance" do
	54	+ build(:deploy_key).should be_valid
	55	+ end
	56	+
	57	+ it "builds a valid personal key instance" do
	58	+ build(:personal_key).should be_valid
	59	+ end
	60	+ end
	61	+
	62	+ describe 'Milestone' do
	63	+ it "builds a valid instance" do
	64	+ build(:milestone).should be_valid
	65	+ end
	66	+ end
	67	+
	68	+ describe 'SystemHook' do
	69	+ it "builds a valid instance" do
	70	+ build(:system_hook).should be_valid
	71	+ end
	72	+ end
	73	+
	74	+ describe 'ProjectHook' do
	75	+ it "builds a valid instance" do
	76	+ build(:project_hook).should be_valid
	77	+ end
	78	+ end
	79	+
	80	+ describe 'Wiki' do
	81	+ it "builds a valid instance" do
	82	+ build(:wiki).should be_valid
	83	+ end
	84	+ end
	85	+
	86	+ describe 'Snippet' do
	87	+ it "builds a valid instance" do
	88	+ build(:snippet).should be_valid
	89	+ end
	90	+ end
	91	+end
	@@ -1,29 +0,0 @@	@@ -1,29 +0,0 @@
1	-class Factory
2	- @factories = {}
3	-
4	- class << self
5	- def add(name, klass, &block)
6	- @factories[name] = [klass, block]
7	- end
8	-
9	- def create(name, opts = {})
10	- new(name, opts).tap(&:save!)
11	- end
12	-
13	- def new(name, opts = {})
14	- factory= @factories[name]
15	- factory[0].new.tap do \|obj\|
16	- factory[1].call(obj)
17	- end.tap do \|obj\|
18	- opts.each do \|k, opt\|
19	- obj.send("#{k}=", opt)
20	- end
21	- end
22	- end
23	- end
24	-end
25	-
26	-def Factory(name, opts={})
27	- Factory.create name, opts
28	-end
29	-
	@@ -2,7 +2,7 @@ require "spec_helper"		@@ -2,7 +2,7 @@ require "spec_helper"
2		2
3	describe GitlabMarkdownHelper do	3	describe GitlabMarkdownHelper do
4	before do	4	before do
5	- @project = Project.find_by_path("gitlabhq") \|\| Factory(:project)	5	+ @project = Factory(:project)
6	@commit = @project.repo.commits.first.parents.first	6	@commit = @project.repo.commits.first.parents.first
7	@commit = CommitDecorator.decorate(Commit.new(@commit))	7	@commit = CommitDecorator.decorate(Commit.new(@commit))
8	@other_project = Factory :project, path: "OtherPath", code: "OtherCode"	8	@other_project = Factory :project, path: "OtherPath", code: "OtherCode"
	@@ -157,7 +157,7 @@ describe GitlabMarkdownHelper do		@@ -157,7 +157,7 @@ describe GitlabMarkdownHelper do
157	gfm("Let @#{user.name} fix the mess in #{@commit.id}").should == "Let #{link_to "@#{user.name}", project_team_member_path(@project, member), class: "gfm gfm-team_member "} fix the mess in #{link_to @commit.id, project_commit_path(@project, id: @commit.id), title: "Commit: #{@commit.author_name} - #{@commit.title}", class: "gfm gfm-commit "}"	157	gfm("Let @#{user.name} fix the mess in #{@commit.id}").should == "Let #{link_to "@#{user.name}", project_team_member_path(@project, member), class: "gfm gfm-team_member "} fix the mess in #{link_to @commit.id, project_commit_path(@project, id: @commit.id), title: "Commit: #{@commit.author_name} - #{@commit.title}", class: "gfm gfm-commit "}"
158	end	158	end
159		159
160	- it "should not trip over other stuff", focus: true do	160	+ it "should not trip over other stuff" do
161	gfm("_Please_ stop 'helping' and all the other b$#%' you do.").should == "_Please_ stop* 'helping' and all the other b*$#%' you do."	161	gfm("_Please_ stop 'helping' and all the other b$#%' you do.").should == "_Please_ stop* 'helping' and all the other b*$#%' you do."
162	end	162	end
163		163
	@@ -85,7 +85,7 @@ describe Project do		@@ -85,7 +85,7 @@ describe Project do
85		85
86	it "should return path to repo" do	86	it "should return path to repo" do
87	project = Project.new(path: "somewhere")	87	project = Project.new(path: "somewhere")
88	- project.path_to_repo.should == File.join(Rails.root, "tmp", "tests", "somewhere")	88	+ project.path_to_repo.should == File.join(Rails.root, "tmp", "repositories", "somewhere")
89	end	89	end
90		90
91	it "returns the full web URL for this repo" do	91	it "returns the full web URL for this repo" do
	@@ -3,11 +3,12 @@ require 'spec_helper'		@@ -3,11 +3,12 @@ require 'spec_helper'
3	describe User do	3	describe User do
4	describe "Associations" do	4	describe "Associations" do
5	it { should have_many(:projects) }	5	it { should have_many(:projects) }
6	- it { should have_many(:users_projects) }
7	- it { should have_many(:issues) }
8	- it { should have_many(:assigned_issues) }
9	- it { should have_many(:merge_requests) }
10	- it { should have_many(:assigned_merge_requests) }	6	+ it { should have_many(:users_projects).dependent(:destroy) }
		7	+ it { should have_many(:issues).dependent(:destroy) }
		8	+ it { should have_many(:assigned_issues).dependent(:destroy) }
		9	+ it { should have_many(:merge_requests).dependent(:destroy) }
		10	+ it { should have_many(:assigned_merge_requests).dependent(:destroy) }
		11	+ it { should have_many(:notes).dependent(:destroy) }
11	end	12	end
12		13
13	describe "Respond to" do	14	describe "Respond to" do
	@@ -49,21 +50,6 @@ describe User do		@@ -49,21 +50,6 @@ describe User do
49	user = Factory(:user)	50	user = Factory(:user)
50	user.authentication_token.should_not == ""	51	user.authentication_token.should_not == ""
51	end	52	end
52	-
53	- describe "dependent" do
54	- before do
55	- @user = Factory :user
56	- @note = Factory :note,
57	- author: @user,
58	- project: Factory(:project)
59	- end
60	-
61	- it "should destroy all notes with user" do
62	- Note.find_by_id(@note.id).should_not be_nil
63	- @user.destroy
64	- Note.find_by_id(@note.id).should be_nil
65	- end
66	- end
67	end	53	end
68	# == Schema Information	54	# == Schema Information
69	#	55	#