Add troubleshooting hints to update hook check

Jacob Vosmaer
1 parent e8b9712d
Showing 1 changed file with 12 additions and 6 deletions Show diff stats
lib/tasks/gitlab/check.rake
@@ -393,14 +393,20 @@ namespace :gitlab do
       hook_file = "update"
       gitlab_shell_hooks_path = Gitlab.config.gitlab_shell.hooks_path
       gitlab_shell_hook_file  = File.join(gitlab_shell_hooks_path, hook_file)
-      gitlab_shell_ssh_user = Gitlab.config.gitlab_shell.ssh_user
  
-      unless File.exists?(gitlab_shell_hook_file)
-        puts "can't check because of previous errors".magenta
-        return
+      if File.exists?(gitlab_shell_hook_file)
+        puts "yes".green
+      else
+        puts "no".red
+        puts "Could not find #{gitlab_shell_hook_file}"
+        try_fixing_it(
+          'Check the hooks_path in config/gitlab.yml',
+          'Check your gitlab-shell installation'
+        )
+        for_more_information(
+          see_installation_guide_section "GitLab Shell"
+        )
       end
-
-      puts "yes".green
     end
  
     def check_repo_base_exists
...	...	@@ -393,14 +393,20 @@ namespace :gitlab do
393	393	hook_file = "update"
394	394	gitlab_shell_hooks_path = Gitlab.config.gitlab_shell.hooks_path
395	395	gitlab_shell_hook_file = File.join(gitlab_shell_hooks_path, hook_file)
396		- gitlab_shell_ssh_user = Gitlab.config.gitlab_shell.ssh_user
397	396
398		- unless File.exists?(gitlab_shell_hook_file)
399		- puts "can't check because of previous errors".magenta
400		- return
	397	+ if File.exists?(gitlab_shell_hook_file)
	398	+ puts "yes".green
	399	+ else
	400	+ puts "no".red
	401	+ puts "Could not find #{gitlab_shell_hook_file}"
	402	+ try_fixing_it(
	403	+ 'Check the hooks_path in config/gitlab.yml',
	404	+ 'Check your gitlab-shell installation'
	405	+ )
	406	+ for_more_information(
	407	+ see_installation_guide_section "GitLab Shell"
	408	+ )
401	409	end
402		-
403		- puts "yes".green
404	410	end
405	411
406	412	def check_repo_base_exists
...	...