API: fixed adding a note

Now the correct attribute is checked if it's available or not. Also fixed a test.

API: fixed adding a note
Now the correct attribute is checked if it's available or not. Also fixed a test.
Sebastian Ziebell
1 parent 3bb342b9
Showing 2 changed files with 2 additions and 3 deletions Show diff stats
lib/api/notes.rb
spec/requests/api/projects_spec.rb
@@ -93,7 +93,7 @@ module Gitlab
         #   POST /projects/:id/issues/:noteable_id/notes
         #   POST /projects/:id/snippets/:noteable_id/notes
         post ":id/#{noteables_str}/:#{noteable_id_str}/notes" do
-          required_attributes! [:"#{noteable_id_str}"]
+          required_attributes! [:body]
  
           @noteable = user_project.send(:"#{noteables_str}").find(params[:"#{noteable_id_str}"])
           @note = @noteable.notes.new(note: params[:body])
@@ -466,8 +466,7 @@ describe Gitlab::API do
         response.status.should == 200
  
         json_response.should be_an Array
-        #json_response.first['id'].should == project.repository.commit.id
-        json_response.size.should == 1
+        json_response.first['id'].should == project.repository.commit.id
       end
     end
...	...	@@ -93,7 +93,7 @@ module Gitlab
93	93	# POST /projects/:id/issues/:noteable_id/notes
94	94	# POST /projects/:id/snippets/:noteable_id/notes
95	95	post ":id/#{noteables_str}/:#{noteable_id_str}/notes" do
96		- required_attributes! [:"#{noteable_id_str}"]
	96	+ required_attributes! [:body]
97	97
98	98	@noteable = user_project.send(:"#{noteables_str}").find(params[:"#{noteable_id_str}"])
99	99	@note = @noteable.notes.new(note: params[:body])
...	...
...	...	@@ -466,8 +466,7 @@ describe Gitlab::API do
466	466	response.status.should == 200
467	467
468	468	json_response.should be_an Array
469		- #json_response.first['id'].should == project.repository.commit.id
470		- json_response.size.should == 1
	469	+ json_response.first['id'].should == project.repository.commit.id
471	470	end
472	471	end
473	472
...	...