replace javascript:void with preventDefault

Alex Denisov
1 parent 5133fe8e
Showing 2 changed files with 3 additions and 2 deletions Show diff stats
app/assets/javascripts/dashboard.js.coffee
app/helpers/events_helper.rb
@@ -3,7 +3,8 @@ $ -&gt;
  
 dashboardPage = ->
   Pager.init 20, true
-  $(".event_filter_link").bind "click", ->
+  $(".event_filter_link").bind "click", (event) ->
+    event.preventDefault()
     toggleFilter $(this)
     reloadActivities()
  
@@ -29,7 +29,7 @@ module EventsHelper
                end
  
     content_tag :div, class: "filter_icon #{inactive}" do
-      link_to 'javascript:void(0)', class: 'has_tooltip event_filter_link', id: "#{key}_event_filter", 'data-original-title' => tooltip do
+      link_to dashboard_path, class: 'has_tooltip event_filter_link', id: "#{key}_event_filter", 'data-original-title' => tooltip do
         image_tag "event_filter_#{key}.png"
       end
     end
...	...	@@ -3,7 +3,8 @@ $ ->
3	3
4	4	dashboardPage = ->
5	5	Pager.init 20, true
6		- $(".event_filter_link").bind "click", ->
	6	+ $(".event_filter_link").bind "click", (event) ->
	7	+ event.preventDefault()
7	8	toggleFilter $(this)
8	9	reloadActivities()
9	10
...	...
...	...	@@ -29,7 +29,7 @@ module EventsHelper
29	29	end
30	30
31	31	content_tag :div, class: "filter_icon #{inactive}" do
32		- link_to 'javascript:void(0)', class: 'has_tooltip event_filter_link', id: "#{key}_event_filter", 'data-original-title' => tooltip do
	32	+ link_to dashboard_path, class: 'has_tooltip event_filter_link', id: "#{key}_event_filter", 'data-original-title' => tooltip do
33	33	image_tag "event_filter_#{key}.png"
34	34	end
35	35	end
...	...