Commit d8a24003cbd66dc80393dae46299c5734d50b5e0
1 parent
44ab156e
Exists in
spb-stable
and in
3 other branches
Don't write the project namespace in email subjects
For instance, the email "Subject" field changes from:
Mattt / Ground Control | Saving issue doesn't work sometimes (#1234)
to:
Ground Control | Saving issue doesn't work sometimes (#1234)
Rationale:
* Most people are receiving email notifications about a single fork:
the project activity, issues and merge requests are happening either
in a root repository or in a fork, but less often in several forks.
* It removes noise from the email subject. The namespace of the project
can still be read in the email body.
* For Entreprise users that have a single namespace "MyEntreprise",
having this repeated in every email subject is very noisy.
Showing
1 changed file
with
1 additions
and
1 deletions
Show diff stats
app/mailers/notify.rb
| @@ -56,7 +56,7 @@ class Notify < ActionMailer::Base | @@ -56,7 +56,7 @@ class Notify < ActionMailer::Base | ||
| 56 | # => "Lorem ipsum | Dolor sit amet" | 56 | # => "Lorem ipsum | Dolor sit amet" |
| 57 | def subject(*extra) | 57 | def subject(*extra) |
| 58 | subject = "" | 58 | subject = "" |
| 59 | - subject << "#{@project.name_with_namespace} | " if @project | 59 | + subject << "#{@project.name} | " if @project |
| 60 | subject << extra.join(' | ') if extra.present? | 60 | subject << extra.join(' | ') if extra.present? |
| 61 | subject | 61 | subject |
| 62 | end | 62 | end |