Replacing the manual parsing of the /etc/group file with the equivalent call fro…

…m the Etc class in the Ruby standard library. This has the benefit of supporting additional platforms (e.g. OS X).

Replacing the manual parsing of the /etc/group file with the equivalent call fro…
…m the Etc class in the Ruby standard library. This has the benefit of supporting additional platforms (e.g. OS X).
Cameron Yule
1 parent 85de55a1
Showing 1 changed file with 1 additions and 2 deletions Show diff stats
lib/tasks/gitlab/task_helpers.rake
@@ -77,8 +77,7 @@ namespace :gitlab do
   end
  
   def gid_for(group_name)
-    group_line = File.read("/etc/group").lines.select{|l| l.start_with?("#{group_name}:")}.first
-    group_line.split(":")[2].to_i
+    Etc.getgrnam(group_name).gid
   end
  
   def warn_user_is_not_gitlab
...	...	@@ -77,8 +77,7 @@ namespace :gitlab do
77	77	end
78	78
79	79	def gid_for(group_name)
80		- group_line = File.read("/etc/group").lines.select{\|l\| l.start_with?("#{group_name}:")}.first
81		- group_line.split(":")[2].to_i
	80	+ Etc.getgrnam(group_name).gid
82	81	end
83	82
84	83	def warn_user_is_not_gitlab
...	...