Merge pull request #1163 from tomykaira/bug_1009

Fix #1009 Replace all special characters in user's identity

Merge pull request #1163 from tomykaira/bug_1009
Fix #1009 Replace all special characters in user's identity
Dmitriy Zaporozhets
2 parents 354d2438 03a2995e
Showing 2 changed files with 6 additions and 1 deletions Show diff stats
app/roles/account.rb
spec/models/user_spec.rb
 module Account 
   def identifier
-    email.gsub /[@.]/, "_"
+    email.gsub /[^[:alnum:]]/, "_"
   end
  
   def is_admin?
@@ -22,6 +22,11 @@ describe User do
     user.identifier.should == "test_mail_com"
   end
  
+  it "should return identifier without + sign" do
+    user = User.new(:email => "test+foo@mail.com")
+    user.identifier.should == "test_foo_mail_com"
+  end
+
   it "should execute callback when force_random_password specified" do
     user = User.new(:email => "test@mail.com", :force_random_password => true)
     user.should_receive(:generate_password)
1	1	module Account
2	2	def identifier
3		- email.gsub /[@.]/, "_"
	3	+ email.gsub /[^[:alnum:]]/, "_"
4	4	end
5	5
6	6	def is_admin?
...	...
...	...	@@ -22,6 +22,11 @@ describe User do
22	22	user.identifier.should == "test_mail_com"
23	23	end
24	24
	25	+ it "should return identifier without + sign" do
	26	+ user = User.new(:email => "test+foo@mail.com")
	27	+ user.identifier.should == "test_foo_mail_com"
	28	+ end
	29	+
25	30	it "should execute callback when force_random_password specified" do
26	31	user = User.new(:email => "test@mail.com", :force_random_password => true)
27	32	user.should_receive(:generate_password)
...	...