Fix bug with branches whose name contains slash

Valeriy Sizov
1 parent 73d5e51a
Showing 2 changed files with 9 additions and 9 deletions Show diff stats
lib/extracts_path.rb
spec/lib/extracts_path_spec.rb
@@ -56,22 +56,22 @@ module ExtractsPath
       # Append a trailing slash if we only get a ref and no file path
       id = input
-      id += '/' unless id.include?('/')
-
+      id += '/' unless id.ends_with?('/')
+      
       valid_refs = @project.branches + @project.tags
-      valid_refs.select! { |v| id.start_with?("#{v}/") }
-
+      valid_refs.select! { |v| id.start_with?("#{v.name}/") }
+      
       if valid_refs.length != 1
         # No exact ref match, so just try our best
         pair = id.match(/([^\/]+)(.*)/).captures
       else
         # Partition the string into the ref and the path, ignoring the empty first value
-        pair = id.partition(valid_refs.first)[1..-1]
+        pair = id.partition(valid_refs.first.name)[1..-1]
       end
     end
-    # Remove leading slash from path
-    pair[1].gsub!(/^\//, '')
+    # Remove ending slashes from path
+    pair[1].gsub!(/^\/|\/$/, '')
     pair
   end
@@ -7,8 +7,8 @@ describe ExtractsPath do
   before do
     @project = project
-    project.stub(:branches).and_return(['master', 'foo/bar/baz'])
-    project.stub(:tags).and_return(['v1.0.0', 'v2.0.0'])
+    project.stub(:branches).and_return([stub(name: 'master'), stub(name: 'foo/bar/baz')])
+    project.stub(:tags).and_return([stub(name: 'master'), stub(name: 'master')])
   end
   describe '#extract_ref' do