Make transfer action in project controller

Dmitriy Zaporozhets
1 parent ff35b37f
Showing 6 changed files with 11 additions and 26 deletions Show diff stats
app/contexts/projects/update_context.rb
app/controllers/projects_controller.rb
app/models/project.rb
app/views/projects/_form.html.haml
app/views/projects/update_failed.js.haml
config/routes.rb
 module Projects
   class UpdateContext < BaseContext
     def execute(role = :default)
-      namespace_id = params[:project].delete(:namespace_id)
+      params[:project].delete(:namespace_id)
       params[:project].delete(:public) unless can?(current_user, :change_public_mode, project)
-
-      allowed_transfer = can?(current_user, :change_namespace, project) || role == :admin
-
-      if allowed_transfer && namespace_id.present?
-        if namespace_id == Namespace.global_id
-          if project.namespace.present?
-            # Transfer to global namespace from anyone
-            project.transfer(nil)
-          end
-        elsif namespace_id.to_i != project.namespace_id
-          # Transfer to someone namespace
-          namespace = Namespace.find(namespace_id)
-          project.transfer(namespace)
-        end
-      end
-
       project.update_attributes(params[:project], as: role)
     end
   end
@@ -4,7 +4,7 @@ class ProjectsController &lt; ProjectResourceController
   # Authorize
   before_filter :authorize_read_project!, except: [:index, :new, :create]
-  before_filter :authorize_admin_project!, only: [:edit, :update, :destroy]
+  before_filter :authorize_admin_project!, only: [:edit, :update, :destroy, :transfer]
   before_filter :require_non_empty_project, only: [:blob, :tree, :graph]
   layout 'application', only: [:new, :create]
@@ -45,10 +45,10 @@ class ProjectsController &lt; ProjectResourceController
         format.js
       end
     end
+  end
-  rescue Project::TransferError => ex
-    @error = ex
-    render :update_failed
+  def transfer
+    ::Projects::TransferContext.new(project, current_user, params).execute
   end
   def show
@@ -26,8 +26,6 @@ class Project &lt; ActiveRecord::Base
   include Gitlab::ShellAdapter
   extend Enumerize
-  class TransferError < StandardError; end
-
   attr_accessible :name, :path, :description, :default_branch, :issues_tracker,
     :issues_enabled, :wall_enabled, :merge_requests_enabled, :snippets_enabled, :issues_tracker_id,
     :wiki_enabled, :public, :import_url, as: [:default, :admin]
@@ -107,8 +107,9 @@
         - if can?(current_user, :change_namespace, @project)
           .ui-box.ui-box-danger
             %h5.title Transfer project
+            .errors-holder
             .form-holder
-              = form_for(@project, remote: true, html: { class: 'transfer-project' }) do |f|
+              = form_for(@project, url: transfer_project_path(@project), remote: true, html: { class: 'transfer-project' }) do |f|
                 .control-group
                   = f.label :namespace_id do
                     %span Namespace
@@ -1,2 +0,0 @@
-:plain
-  $(".save-project-loader").replaceWith(errorMessage('#{escape_javascript(@error.message)}'));
@@ -167,6 +167,10 @@ Gitlab::Application.routes.draw do
   # Project Area
   #
   resources :projects, constraints: { id: /(?:[a-zA-Z.0-9_\-]+\/)?[a-zA-Z.0-9_\-]+/ }, except: [:new, :create, :index], path: "/" do
+    member do
+      put :transfer
+    end
+
     resources :blob,    only: [:show], constraints: {id: /.+/}
     resources :tree,    only: [:show], constraints: {id: /.+/, format: /(html|js)/ }
     resources :edit_tree,    only: [:show, :update], constraints: {id: /.+/}, path: 'edit'
1	module Projects	1	module Projects
2	class UpdateContext < BaseContext	2	class UpdateContext < BaseContext
3	def execute(role = :default)	3	def execute(role = :default)
4	- namespace_id = params[:project].delete(:namespace_id)	4	+ params[:project].delete(:namespace_id)
5	params[:project].delete(:public) unless can?(current_user, :change_public_mode, project)	5	params[:project].delete(:public) unless can?(current_user, :change_public_mode, project)
6	-
7	- allowed_transfer = can?(current_user, :change_namespace, project) \|\| role == :admin
8	-
9	- if allowed_transfer && namespace_id.present?
10	- if namespace_id == Namespace.global_id
11	- if project.namespace.present?
12	- # Transfer to global namespace from anyone
13	- project.transfer(nil)
14	- end
15	- elsif namespace_id.to_i != project.namespace_id
16	- # Transfer to someone namespace
17	- namespace = Namespace.find(namespace_id)
18	- project.transfer(namespace)
19	- end
20	- end
21	-
22	project.update_attributes(params[:project], as: role)	6	project.update_attributes(params[:project], as: role)
23	end	7	end
24	end	8	end
	@@ -1,2 +0,0 @@	@@ -1,2 +0,0 @@
1	-:plain
2	- $(".save-project-loader").replaceWith(errorMessage('#{escape_javascript(@error.message)}'));