Namespace model added. Migration to convert exit project/groups

Dmitriy Zaporozhets
1 parent ced242a2
Showing 6 changed files with 60 additions and 31 deletions Show diff stats
app/models/group.rb
app/models/namespace.rb
app/models/project.rb
db/migrate/20121122145155_convert_group_to_namespace.rb
db/migrate/20121122150932_add_namespace_id_to_project.rb
db/schema.rb
@@ -10,26 +10,7 @@
 #  updated_at :datetime         not null
 #
-class Group < ActiveRecord::Base
-  attr_accessible :code, :name, :owner_id
-
-  has_many :projects
-  belongs_to :owner, class_name: "User"
-
-  validates :name, presence: true, uniqueness: true
-  validates :code, presence: true, uniqueness: true
-  validates :owner, presence: true
-
-  delegate :name, to: :owner, allow_nil: true, prefix: true
-
-  def self.search query
-    where("name LIKE :query OR code LIKE :query", query: "%#{query}%")
-  end
-
-  def to_param
-    code
-  end
-
+class Group < Namespace
   def users
     User.joins(:users_projects).where(users_projects: {project_id: project_ids}).uniq
   end
@@ -0,0 +1,20 @@
+class Namespace < ActiveRecord::Base
+  attr_accessible :code, :name, :owner_id
+
+  has_many :projects
+  belongs_to :owner, class_name: "User"
+
+  validates :name, presence: true, uniqueness: true
+  validates :code, presence: true, uniqueness: true
+  validates :owner, presence: true
+
+  delegate :name, to: :owner, allow_nil: true, prefix: true
+
+  def self.search query
+    where("name LIKE :query OR code LIKE :query", query: "%#{query}%")
+  end
+
+  def to_param
+    code
+  end
+end
@@ -32,7 +32,8 @@ class Project &lt; ActiveRecord::Base
   attr_accessor :error_code
   # Relations
-  belongs_to :group
+  belongs_to :group, foreign_key: "namespace_id", conditions: 'type = Group'
+  belongs_to :namespace
   belongs_to :owner, class_name: "User"
   has_many :users,          through: :users_projects
   has_many :events,         dependent: :destroy
@@ -192,4 +193,12 @@ class Project &lt; ActiveRecord::Base
   def gitlab_ci?
     gitlab_ci_service && gitlab_ci_service.active
   end
+
+  def path_with_namespace
+    if namespace
+      namespace.code + '/' + path
+    else
+      path
+    end
+  end
 end
@@ -0,0 +1,13 @@
+class ConvertGroupToNamespace < ActiveRecord::Migration
+  def up
+    rename_table 'groups', 'namespaces'
+    add_column :namespaces, :type, :string, null: true
+
+    # Migrate old groups
+    Namespace.update_all(type: 'Group')
+  end
+
+  def down
+    raise 'Rollback is not allowed'
+  end
+end
@@ -0,0 +1,5 @@
+class AddNamespaceIdToProject < ActiveRecord::Migration
+  def change
+    rename_column :projects, :group_id, :namespace_id
+  end
+end
@@ -11,7 +11,7 @@
 #
 # It's strongly recommended to check this file into your version control system.
-ActiveRecord::Schema.define(:version => 20121120113838) do
+ActiveRecord::Schema.define(:version => 20121122150932) do
   create_table "events", :force => true do |t|
     t.string   "target_type"
@@ -25,14 +25,6 @@ ActiveRecord::Schema.define(:version =&gt; 20121120113838) do
     t.integer  "author_id"
   end
-  create_table "groups", :force => true do |t|
-    t.string   "name",       :null => false
-    t.string   "code",       :null => false
-    t.integer  "owner_id",   :null => false
-    t.datetime "created_at", :null => false
-    t.datetime "updated_at", :null => false
-  end
-
   create_table "issues", :force => true do |t|
     t.string   "title"
     t.integer  "assignee_id"
@@ -88,6 +80,15 @@ ActiveRecord::Schema.define(:version =&gt; 20121120113838) do
     t.datetime "updated_at",                     :null => false
   end
+  create_table "namespaces", :force => true do |t|
+    t.string   "name",       :null => false
+    t.string   "code",       :null => false
+    t.integer  "owner_id",   :null => false
+    t.datetime "created_at", :null => false
+    t.datetime "updated_at", :null => false
+    t.string   "type"
+  end
+
   create_table "notes", :force => true do |t|
     t.text     "note"
     t.string   "noteable_id"
@@ -117,7 +118,7 @@ ActiveRecord::Schema.define(:version =&gt; 20121120113838) do
     t.boolean  "wall_enabled",           :default => true, :null => false
     t.boolean  "merge_requests_enabled", :default => true, :null => false
     t.boolean  "wiki_enabled",           :default => true, :null => false
-    t.integer  "group_id"
+    t.integer  "namespace_id"
   end
   create_table "protected_branches", :force => true do |t|
	@@ -10,26 +10,7 @@		@@ -10,26 +10,7 @@
10	# updated_at :datetime not null	10	# updated_at :datetime not null
11	#	11	#
12		12
13	-class Group < ActiveRecord::Base
14	- attr_accessible :code, :name, :owner_id
15	-
16	- has_many :projects
17	- belongs_to :owner, class_name: "User"
18	-
19	- validates :name, presence: true, uniqueness: true
20	- validates :code, presence: true, uniqueness: true
21	- validates :owner, presence: true
22	-
23	- delegate :name, to: :owner, allow_nil: true, prefix: true
24	-
25	- def self.search query
26	- where("name LIKE :query OR code LIKE :query", query: "%#{query}%")
27	- end
28	-
29	- def to_param
30	- code
31	- end
32	-	13	+class Group < Namespace
33	def users	14	def users
34	User.joins(:users_projects).where(users_projects: {project_id: project_ids}).uniq	15	User.joins(:users_projects).where(users_projects: {project_id: project_ids}).uniq
35	end	16	end
@@ -0,0 +1,20 @@		@@ -0,0 +1,20 @@
	1	+class Namespace < ActiveRecord::Base
	2	+ attr_accessible :code, :name, :owner_id
	3	+
	4	+ has_many :projects
	5	+ belongs_to :owner, class_name: "User"
	6	+
	7	+ validates :name, presence: true, uniqueness: true
	8	+ validates :code, presence: true, uniqueness: true
	9	+ validates :owner, presence: true
	10	+
	11	+ delegate :name, to: :owner, allow_nil: true, prefix: true
	12	+
	13	+ def self.search query
	14	+ where("name LIKE :query OR code LIKE :query", query: "%#{query}%")
	15	+ end
	16	+
	17	+ def to_param
	18	+ code
	19	+ end
	20	+end
@@ -0,0 +1,13 @@		@@ -0,0 +1,13 @@
	1	+class ConvertGroupToNamespace < ActiveRecord::Migration
	2	+ def up
	3	+ rename_table 'groups', 'namespaces'
	4	+ add_column :namespaces, :type, :string, null: true
	5	+
	6	+ # Migrate old groups
	7	+ Namespace.update_all(type: 'Group')
	8	+ end
	9	+
	10	+ def down
	11	+ raise 'Rollback is not allowed'
	12	+ end
	13	+end
@@ -0,0 +1,5 @@		@@ -0,0 +1,5 @@
	1	+class AddNamespaceIdToProject < ActiveRecord::Migration
	2	+ def change
	3	+ rename_column :projects, :group_id, :namespace_id
	4	+ end
	5	+end