Commit e426d43924be265d4834f47fd765895dde6017fb
1 parent
7ad5fb53
Exists in
spb-stable
and in
2 other branches
Check return system value for gitlab test rake tasks
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Showing
3 changed files
with
6 additions
and
7 deletions
Show diff stats
lib/tasks/gitlab/test.rake
... | ... | @@ -8,9 +8,8 @@ namespace :gitlab do |
8 | 8 | ] |
9 | 9 | |
10 | 10 | cmds.each do |cmd| |
11 | - result = system({'RAILS_ENV' => 'test', 'force' => 'yes'}, *cmd) | |
12 | - | |
13 | - raise "#{cmd} failed!" unless result | |
11 | + system({'RAILS_ENV' => 'test', 'force' => 'yes'}, *cmd) || | |
12 | + raise "#{cmd} failed!" | |
14 | 13 | end |
15 | 14 | end |
16 | 15 | end | ... | ... |
lib/tasks/spec.rake
... | ... | @@ -40,7 +40,7 @@ end |
40 | 40 | |
41 | 41 | def run_commands(cmds) |
42 | 42 | cmds.each do |cmd| |
43 | - system({'RAILS_ENV' => 'test', 'force' => 'yes'}, *cmd) | |
44 | - raise "#{cmd} failed!" unless $?.exitstatus.zero? | |
43 | + system({'RAILS_ENV' => 'test', 'force' => 'yes'}, *cmd) || | |
44 | + raise "#{cmd} failed!" | |
45 | 45 | end |
46 | 46 | end | ... | ... |
lib/tasks/spinach.rake
... | ... | @@ -8,7 +8,7 @@ task :spinach do |
8 | 8 | ] |
9 | 9 | |
10 | 10 | cmds.each do |cmd| |
11 | - system({'RAILS_ENV' => 'test', 'force' => 'yes'}, *cmd) | |
12 | - raise "#{cmd} failed!" unless $?.exitstatus.zero? | |
11 | + system({'RAILS_ENV' => 'test', 'force' => 'yes'}, *cmd) || | |
12 | + raise "#{cmd} failed!" | |
13 | 13 | end |
14 | 14 | end | ... | ... |