Merge branch 'master' of https://github.com/gitlabhq/gitlabhq into admin-panel-disign

user
2 parents c3eac16f c359eadf
Showing 11 changed files with 84 additions and 27 deletions Show diff stats
Gemfile
Gemfile.lock
app/assets/stylesheets/style.scss
app/models/note.rb
app/models/user.rb
app/views/commits/_text_file.html.haml
app/views/layouts/_head_panel.html.erb
app/views/layouts/project.html.haml
lib/commit_ext.rb
spec/models/note_spec.rb
spec/models/user_spec.rb
@@ -39,7 +39,7 @@ group :development, :test do
   gem 'capybara'
   gem 'autotest'
   gem 'autotest-rails'
-  # gem 'ruby-debug19', :require => 'ruby-debug'
+  gem 'ruby-debug19', :require => 'ruby-debug'
   gem 'awesome_print'
   gem 'database_cleaner'
   gem 'launchy'
@@ -50,6 +50,7 @@ GEM
     acts_as_list (0.1.4)
     addressable (2.2.6)
     ansi (1.4.1)
+    archive-tar-minitar (0.5.2)
     arel (2.2.1)
     autotest (4.4.6)
       ZenTest (>= 4.4.1)
@@ -77,6 +78,7 @@ GEM
       coffee-script-source
       execjs
     coffee-script-source (1.1.3)
+    columnize (0.3.4)
     daemons (1.1.4)
     database_cleaner (0.7.0)
     devise (1.5.0)
@@ -113,6 +115,8 @@ GEM
     letter_opener (0.0.2)
       launchy
     libv8 (3.3.10.4)
+    linecache19 (0.5.12)
+      ruby_core_source (>= 0.1.4)
     mail (2.3.0)
       i18n (>= 0.4.0)
       mime-types (~> 1.16)
@@ -168,6 +172,16 @@ GEM
       activesupport (~> 3.0)
       railties (~> 3.0)
       rspec (~> 2.7.0)
+    ruby-debug-base19 (0.11.25)
+      columnize (>= 0.3.1)
+      linecache19 (>= 0.5.11)
+      ruby_core_source (>= 0.1.4)
+    ruby-debug19 (0.11.6)
+      columnize (>= 0.3.1)
+      linecache19 (>= 0.5.11)
+      ruby-debug-base19 (>= 0.11.19)
+    ruby_core_source (0.1.5)
+      archive-tar-minitar (>= 0.5.2)
     rubypython (0.5.3)
       blankslate (>= 2.1.2.3)
       ffi (~> 1.0.7)
@@ -254,6 +268,7 @@ DEPENDENCIES
   rails-footnotes (~> 3.7.5)
   rdiscount
   rspec-rails
+  ruby-debug19
   sass-rails (~> 3.1.0)
   seed-fu (~> 2.1.0)
   shoulda (~> 3.0.0.beta2)
@@ -74,7 +74,6 @@ $blue_link: &quot;#2fa0bb&quot;;
 /* eo Vars */
  
 html{ -webkit-font-smoothing:antialiased; }
-*{text-shadow: 0 1px 0 white}
 body{font-size: 12px; background-color: #eee;}
 a{text-decoration: none; font-weight: bold; color: #666}
 a:hover{color: #333}
@@ -494,13 +493,55 @@ header .account-links a:last-child{
   border-bottom: 0;
 }
  
-#no_ssh_key_defined {
-  border:1px solid #ee8801;
-  margin:20px;
-  padding:20px;
-  background:#ffe3f0;
-  h2{margin:0;}
-  p {margin:10px 0 0;}
+.big-message{
+	background-image: -webkit-gradient(linear, 0 48, 0 0, color-stop(0.041, #eccb40), to(#ffee4d));
+	background-image: -webkit-linear-gradient(90deg, #eccb40 4.1%, #ffee4d);
+	background-image: -moz-linear-gradient(90deg, #eccb40 4.1%, #ffee4d);
+	background-image: -o-linear-gradient(90deg, #eccb40 4.1%, #ffee4d);
+	text-align: center;
+	font-weight: bold;
+	padding: 10px 20px;
+	text-shadow: 0 1px 0 rgba(255,255,255,.3);
+	color: #333;
+	color: rgba(0,0,0,.7);
+	font-size: 14px;
+	box-shadow: 0 1px 2px rgba(0,0,0,.7);
+	z-index: 100000;
+	margin-bottom: 2px;
+}
+
+.big-message a{color: #000; text-decoration: underline;}
+
+.big-message.error{
+	background-color: #722523;
+	background-image: -webkit-gradient(linear, 0 49, 0 0, color-stop(0.04, #722523), to(#ad4846));
+	background-image: -webkit-linear-gradient(90deg, #9b403f 4%, #c16765);
+	background-image: -moz-linear-gradient(90deg, #722523 4%, #ad4846);
+	background-image: -o-linear-gradient(90deg, #722523 4%, #ad4846);
+	color: #2E0D0C;
+}
+
+.big-message.success{
+	background-color: #7a9339;
+	background-image: -webkit-gradient(linear, 0 48, 0 0, color-stop(0.062, #7a9339), to(#93ae46));
+	background-image: -webkit-linear-gradient(90deg, #7a9339 6.2%, #93ae46);
+	background-image: -moz-linear-gradient(90deg, #7a9339 6.2%, #93ae46);
+	background-image: -o-linear-gradient(90deg, #7a9339 6.2%, #93ae46)
+}
+
+.big-message.success{
+	background-color: #7a9339;
+	background-image: -webkit-gradient(linear, 0 48, 0 0, color-stop(0.062, #7a9339), to(#93ae46));
+	background-image: -webkit-linear-gradient(90deg, #7a9339 6.2%, #93ae46);
+	background-image: -moz-linear-gradient(90deg, #7a9339 6.2%, #93ae46);
+	background-image: -o-linear-gradient(90deg, #7a9339 6.2%, #93ae46)
+}
+
+.big-message.notice{
+	background-image: -webkit-gradient(linear, 0 49, 0 0, color-stop(0.061, #447790), color-stop(0.897, #5da2bf));
+	background-image: -webkit-linear-gradient(90deg, #447790 6.1%, #5da2bf 89.7%);
+	background-image: -moz-linear-gradient(90deg, #447790 6.1%, #5da2bf 89.7%);
+	background-image: -o-linear-gradient(90deg, #447790 6.1%, #5da2bf 89.7%)
 }
  
 /* eo Account Box */
@@ -516,12 +557,14 @@ h2.icon span{background: #E3E5EA url(&#39;images.png&#39;);  height: 32px; width: 32px; 
 /* Dashboard Page */
 html, body { height: 100%; }
  
+
+
 body.dashboard-page h2.icon span{ background-position:  9px -69px; }
 body.dashboard-page header{margin-bottom: 0}
-body.dashboard-page .news-feed{padding-left: 1em; margin-right: 450px; margin-left: 1%}
+body.dashboard-page .news-feed{padding-left: 1em; margin-right: 450px; min-height: 600px; margin-left: 1%}
 body.dashboard-page .dashboard-content{ position: relative; float: left; width: 100%; height: 100%; }
 body.dashboard-page .news-feed h2{float: left;}
-body.dashboard-page aside{ min-height: 700px; width: 420px;  float: right;  background-color: #f7f7f7; border-left: 1px solid #ccc }
+body.dashboard-page aside{ min-height: 700px; position: absolute; top: 0; bottom: 0; right: 0; width: 420px;  float: right;  background-color: #f7f7f7; border-left: 1px solid #ccc }
 body.dashboard-page aside h4{margin: 0; border-bottom: 1px solid #ccc; padding: 10px 10px; font-size: 11px; font-weight: bold; text-transform: uppercase;}
 body.dashboard-page aside h4 a.button-small{float: right; text-transform: none; border-radius: 4px; margin-right: 2%; margin-top: -4px; display: block;}
 body.dashboard-page aside .project-list {list-style: none; margin: 0; padding: 0;}
@@ -563,7 +606,7 @@ body.project-page .page-title{margin-bottom: 0}
 body.project-page .project-sidebar {width: 220px;  left: 0; top: 0; height: 100%; bottom: 0;  position: absolute; background-color: #f7f7f7; float: left; display: inline-block; background: #f7f7f7; padding: 20px 0 20px 2%; margin: 0; }
  
 body.project-page input.text.git-url,
-body.projects-page input.text.git-url { font-size: 12px; border-radius: 5px; color: #666; box-shadow: 0 1px 2px rgba(0,0,0,.2) inset; padding:  8px 14px 8px 30px;  margin-bottom: 20px;  background: white url('images.png') no-repeat 8px -40px;}
+body.projects-page input.text.git-url { font-size: 12px; border-radius: 5px; color: #666; box-shadow: 0 1px 2px rgba(0,0,0,.2) inset; padding:  8px 0 8px 30px;  margin-bottom: 20px;  background: white url('images.png') no-repeat 8px -40px; width: 176px}
 body.projects-page input.text.git-url {margin:10px 0 0 }
 .git_url_wrapper { margin-right:50px }
  
@@ -27,6 +27,7 @@ class Note &lt; ActiveRecord::Base
  
   scope :common, where(:noteable_id => nil)
  
+  scope :today, where("created_at >= :date", :date => Date.today)
   scope :last_week, where("created_at  >= :date", :date => (Date.today - 7.days))
   scope :since, lambda { |day| where("created_at  >= :date", :date => (day)) }
   scope :fresh, order("created_at DESC")
@@ -30,7 +30,7 @@ class User &lt; ActiveRecord::Base
   scope :not_in_project, lambda { |project|  where("id not in (:ids)", :ids => project.users.map(&:id) ) }
  
   def identifier
-    email.gsub "@", "_"
+    email.gsub /[@.]/, "_"
   end
  
   def is_admin?
@@ -2,6 +2,7 @@
 - line_new = 0
 - lines_arr = diff.diff.lines.to_a
 - lines_arr.each do |line|
+  - line.force_encoding(Encoding::UTF_8)
   - next if line.match(/^--- \/dev\/null/)
   - next if line.match(/^--- a/)
   - next if line.match(/^\+\+\+ b/)
@@ -48,9 +48,7 @@
 <% end %>
  
 <% if current_user.keys.all.empty? %>
-  <div id="no_ssh_key_defined">
-    <h2>ATTENTION!</h2>
-    <p>No SSH Key is defined. You won't be able to use any Git command!
-    <p>Click <%=link_to( 'here', keys_path ) %> to add one!
+  <div id="no_ssh_key_defined" class="big-message error">
+    <p>No SSH Key is defined. You won't be able to use any Git command!. Click <%=link_to( 'here', keys_path ) %> to add one!
   </div>
 <% end %>
@@ -38,7 +38,7 @@
               = link_to wall_project_path(@project), :class => current_page?(:controller => "projects", :action => "wall", :id => @project) ? "current" : nil do
                 Wall
                 - if @project.common_notes.count > 0
-                  %span{ :class => "number" }= @project.common_notes.count
+                  %span{ :class => "number" }= @project.common_notes.today.count
               = link_to project_snippets_path(@project), :class => (controller.controller_name == "snippets") ? "current" : nil do
                 Snippets
                 - if @project.snippets.count > 0
@@ -3,13 +3,7 @@ module CommitExt
   attr_accessor :refs
  
   def safe_message
-    message.encode("UTF-8",
-                   :invalid => :replace,
-                   :undef => :replace,
-                   :universal_newline => true,
-                   :replace => "")
-  rescue
-    "-- invalid encoding for commit message"
+    message.force_encoding(Encoding::UTF_8)
   end
  
   def created_at
@@ -12,7 +12,12 @@ describe Note do
  
   it { Factory.create(:note,
                       :project => Factory.create(:project)).should be_valid }
-
+  describe "Scopes" do
+    it "should have a today named scope that returns ..." do
+      Note.today.where_values.should == ["created_at >= '#{Date.today}'"]
+    end
+  end
+  
   describe :authorization do
     before do
       @p1 = Factory :project
@@ -16,7 +16,7 @@ describe User do
  
   it "should return valid identifier" do
     user = User.new(:email => "test@mail.com")
-    user.identifier.should == "test_mail.com"
+    user.identifier.should == "test_mail_com"
   end
  
   it "should have authentication token" do
...	...	@@ -39,7 +39,7 @@ group :development, :test do
39	39	gem 'capybara'
40	40	gem 'autotest'
41	41	gem 'autotest-rails'
42		- # gem 'ruby-debug19', :require => 'ruby-debug'
	42	+ gem 'ruby-debug19', :require => 'ruby-debug'
43	43	gem 'awesome_print'
44	44	gem 'database_cleaner'
45	45	gem 'launchy'
...	...
...	...	@@ -50,6 +50,7 @@ GEM
50	50	acts_as_list (0.1.4)
51	51	addressable (2.2.6)
52	52	ansi (1.4.1)
	53	+ archive-tar-minitar (0.5.2)
53	54	arel (2.2.1)
54	55	autotest (4.4.6)
55	56	ZenTest (>= 4.4.1)
...	...	@@ -77,6 +78,7 @@ GEM
77	78	coffee-script-source
78	79	execjs
79	80	coffee-script-source (1.1.3)
	81	+ columnize (0.3.4)
80	82	daemons (1.1.4)
81	83	database_cleaner (0.7.0)
82	84	devise (1.5.0)
...	...	@@ -113,6 +115,8 @@ GEM
113	115	letter_opener (0.0.2)
114	116	launchy
115	117	libv8 (3.3.10.4)
	118	+ linecache19 (0.5.12)
	119	+ ruby_core_source (>= 0.1.4)
116	120	mail (2.3.0)
117	121	i18n (>= 0.4.0)
118	122	mime-types (~> 1.16)
...	...	@@ -168,6 +172,16 @@ GEM
168	172	activesupport (~> 3.0)
169	173	railties (~> 3.0)
170	174	rspec (~> 2.7.0)
	175	+ ruby-debug-base19 (0.11.25)
	176	+ columnize (>= 0.3.1)
	177	+ linecache19 (>= 0.5.11)
	178	+ ruby_core_source (>= 0.1.4)
	179	+ ruby-debug19 (0.11.6)
	180	+ columnize (>= 0.3.1)
	181	+ linecache19 (>= 0.5.11)
	182	+ ruby-debug-base19 (>= 0.11.19)
	183	+ ruby_core_source (0.1.5)
	184	+ archive-tar-minitar (>= 0.5.2)
171	185	rubypython (0.5.3)
172	186	blankslate (>= 2.1.2.3)
173	187	ffi (~> 1.0.7)
...	...	@@ -254,6 +268,7 @@ DEPENDENCIES
254	268	rails-footnotes (~> 3.7.5)
255	269	rdiscount
256	270	rspec-rails
	271	+ ruby-debug19
257	272	sass-rails (~> 3.1.0)
258	273	seed-fu (~> 2.1.0)
259	274	shoulda (~> 3.0.0.beta2)
...	...
...	...	@@ -74,7 +74,6 @@ $blue_link: "#2fa0bb";
74	74	/* eo Vars */
75	75
76	76	html{ -webkit-font-smoothing:antialiased; }
77		-*{text-shadow: 0 1px 0 white}
78	77	body{font-size: 12px; background-color: #eee;}
79	78	a{text-decoration: none; font-weight: bold; color: #666}
80	79	a:hover{color: #333}
...	...	@@ -494,13 +493,55 @@ header .account-links a:last-child{
494	493	border-bottom: 0;
495	494	}
496	495
497		-#no_ssh_key_defined {
498		- border:1px solid #ee8801;
499		- margin:20px;
500		- padding:20px;
501		- background:#ffe3f0;
502		- h2{margin:0;}
503		- p {margin:10px 0 0;}
	496	+.big-message{
	497	+ background-image: -webkit-gradient(linear, 0 48, 0 0, color-stop(0.041, #eccb40), to(#ffee4d));
	498	+ background-image: -webkit-linear-gradient(90deg, #eccb40 4.1%, #ffee4d);
	499	+ background-image: -moz-linear-gradient(90deg, #eccb40 4.1%, #ffee4d);
	500	+ background-image: -o-linear-gradient(90deg, #eccb40 4.1%, #ffee4d);
	501	+ text-align: center;
	502	+ font-weight: bold;
	503	+ padding: 10px 20px;
	504	+ text-shadow: 0 1px 0 rgba(255,255,255,.3);
	505	+ color: #333;
	506	+ color: rgba(0,0,0,.7);
	507	+ font-size: 14px;
	508	+ box-shadow: 0 1px 2px rgba(0,0,0,.7);
	509	+ z-index: 100000;
	510	+ margin-bottom: 2px;
	511	+}
	512	+
	513	+.big-message a{color: #000; text-decoration: underline;}
	514	+
	515	+.big-message.error{
	516	+ background-color: #722523;
	517	+ background-image: -webkit-gradient(linear, 0 49, 0 0, color-stop(0.04, #722523), to(#ad4846));
	518	+ background-image: -webkit-linear-gradient(90deg, #9b403f 4%, #c16765);
	519	+ background-image: -moz-linear-gradient(90deg, #722523 4%, #ad4846);
	520	+ background-image: -o-linear-gradient(90deg, #722523 4%, #ad4846);
	521	+ color: #2E0D0C;
	522	+}
	523	+
	524	+.big-message.success{
	525	+ background-color: #7a9339;
	526	+ background-image: -webkit-gradient(linear, 0 48, 0 0, color-stop(0.062, #7a9339), to(#93ae46));
	527	+ background-image: -webkit-linear-gradient(90deg, #7a9339 6.2%, #93ae46);
	528	+ background-image: -moz-linear-gradient(90deg, #7a9339 6.2%, #93ae46);
	529	+ background-image: -o-linear-gradient(90deg, #7a9339 6.2%, #93ae46)
	530	+}
	531	+
	532	+.big-message.success{
	533	+ background-color: #7a9339;
	534	+ background-image: -webkit-gradient(linear, 0 48, 0 0, color-stop(0.062, #7a9339), to(#93ae46));
	535	+ background-image: -webkit-linear-gradient(90deg, #7a9339 6.2%, #93ae46);
	536	+ background-image: -moz-linear-gradient(90deg, #7a9339 6.2%, #93ae46);
	537	+ background-image: -o-linear-gradient(90deg, #7a9339 6.2%, #93ae46)
	538	+}
	539	+
	540	+.big-message.notice{
	541	+ background-image: -webkit-gradient(linear, 0 49, 0 0, color-stop(0.061, #447790), color-stop(0.897, #5da2bf));
	542	+ background-image: -webkit-linear-gradient(90deg, #447790 6.1%, #5da2bf 89.7%);
	543	+ background-image: -moz-linear-gradient(90deg, #447790 6.1%, #5da2bf 89.7%);
	544	+ background-image: -o-linear-gradient(90deg, #447790 6.1%, #5da2bf 89.7%)
504	545	}
505	546
506	547	/* eo Account Box */
...	...	@@ -516,12 +557,14 @@ h2.icon span{background: #E3E5EA url('images.png'); height: 32px; width: 32px;
516	557	/* Dashboard Page */
517	558	html, body { height: 100%; }
518	559
	560	+
	561	+
519	562	body.dashboard-page h2.icon span{ background-position: 9px -69px; }
520	563	body.dashboard-page header{margin-bottom: 0}
521		-body.dashboard-page .news-feed{padding-left: 1em; margin-right: 450px; margin-left: 1%}
	564	+body.dashboard-page .news-feed{padding-left: 1em; margin-right: 450px; min-height: 600px; margin-left: 1%}
522	565	body.dashboard-page .dashboard-content{ position: relative; float: left; width: 100%; height: 100%; }
523	566	body.dashboard-page .news-feed h2{float: left;}
524		-body.dashboard-page aside{ min-height: 700px; width: 420px; float: right; background-color: #f7f7f7; border-left: 1px solid #ccc }
	567	+body.dashboard-page aside{ min-height: 700px; position: absolute; top: 0; bottom: 0; right: 0; width: 420px; float: right; background-color: #f7f7f7; border-left: 1px solid #ccc }
525	568	body.dashboard-page aside h4{margin: 0; border-bottom: 1px solid #ccc; padding: 10px 10px; font-size: 11px; font-weight: bold; text-transform: uppercase;}
526	569	body.dashboard-page aside h4 a.button-small{float: right; text-transform: none; border-radius: 4px; margin-right: 2%; margin-top: -4px; display: block;}
527	570	body.dashboard-page aside .project-list {list-style: none; margin: 0; padding: 0;}
...	...	@@ -563,7 +606,7 @@ body.project-page .page-title{margin-bottom: 0}
563	606	body.project-page .project-sidebar {width: 220px; left: 0; top: 0; height: 100%; bottom: 0; position: absolute; background-color: #f7f7f7; float: left; display: inline-block; background: #f7f7f7; padding: 20px 0 20px 2%; margin: 0; }
564	607
565	608	body.project-page input.text.git-url,
566		-body.projects-page input.text.git-url { font-size: 12px; border-radius: 5px; color: #666; box-shadow: 0 1px 2px rgba(0,0,0,.2) inset; padding: 8px 14px 8px 30px; margin-bottom: 20px; background: white url('images.png') no-repeat 8px -40px;}
	609	+body.projects-page input.text.git-url { font-size: 12px; border-radius: 5px; color: #666; box-shadow: 0 1px 2px rgba(0,0,0,.2) inset; padding: 8px 0 8px 30px; margin-bottom: 20px; background: white url('images.png') no-repeat 8px -40px; width: 176px}
567	610	body.projects-page input.text.git-url {margin:10px 0 0 }
568	611	.git_url_wrapper { margin-right:50px }
569	612
...	...
...	...	@@ -27,6 +27,7 @@ class Note < ActiveRecord::Base
27	27
28	28	scope :common, where(:noteable_id => nil)
29	29
	30	+ scope :today, where("created_at >= :date", :date => Date.today)
30	31	scope :last_week, where("created_at >= :date", :date => (Date.today - 7.days))
31	32	scope :since, lambda { \|day\| where("created_at >= :date", :date => (day)) }
32	33	scope :fresh, order("created_at DESC")
...	...
...	...	@@ -30,7 +30,7 @@ class User < ActiveRecord::Base
30	30	scope :not_in_project, lambda { \|project\| where("id not in (:ids)", :ids => project.users.map(&:id) ) }
31	31
32	32	def identifier
33		- email.gsub "@", "_"
	33	+ email.gsub /[@.]/, "_"
34	34	end
35	35
36	36	def is_admin?
...	...
...	...	@@ -2,6 +2,7 @@
2	2	- line_new = 0
3	3	- lines_arr = diff.diff.lines.to_a
4	4	- lines_arr.each do \|line\|
	5	+ - line.force_encoding(Encoding::UTF_8)
5	6	- next if line.match(/^--- \/dev\/null/)
6	7	- next if line.match(/^--- a/)
7	8	- next if line.match(/^\+\+\+ b/)
...	...
...	...	@@ -48,9 +48,7 @@
48	48	<% end %>
49	49
50	50	<% if current_user.keys.all.empty? %>
51		- <div id="no_ssh_key_defined">
52		- <h2>ATTENTION!</h2>
53		- <p>No SSH Key is defined. You won't be able to use any Git command!
54		- <p>Click <%=link_to( 'here', keys_path ) %> to add one!
	51	+ <div id="no_ssh_key_defined" class="big-message error">
	52	+ <p>No SSH Key is defined. You won't be able to use any Git command!. Click <%=link_to( 'here', keys_path ) %> to add one!
55	53	</div>
56	54	<% end %>
...	...
...	...	@@ -38,7 +38,7 @@
38	38	= link_to wall_project_path(@project), :class => current_page?(:controller => "projects", :action => "wall", :id => @project) ? "current" : nil do
39	39	Wall
40	40	- if @project.common_notes.count > 0
41		- %span{ :class => "number" }= @project.common_notes.count
	41	+ %span{ :class => "number" }= @project.common_notes.today.count
42	42	= link_to project_snippets_path(@project), :class => (controller.controller_name == "snippets") ? "current" : nil do
43	43	Snippets
44	44	- if @project.snippets.count > 0
...	...
...	...	@@ -3,13 +3,7 @@ module CommitExt
3	3	attr_accessor :refs
4	4
5	5	def safe_message
6		- message.encode("UTF-8",
7		- :invalid => :replace,
8		- :undef => :replace,
9		- :universal_newline => true,
10		- :replace => "")
11		- rescue
12		- "-- invalid encoding for commit message"
	6	+ message.force_encoding(Encoding::UTF_8)
13	7	end
14	8
15	9	def created_at
...	...
...	...	@@ -12,7 +12,12 @@ describe Note do
12	12
13	13	it { Factory.create(:note,
14	14	:project => Factory.create(:project)).should be_valid }
15		-
	15	+ describe "Scopes" do
	16	+ it "should have a today named scope that returns ..." do
	17	+ Note.today.where_values.should == ["created_at >= '#{Date.today}'"]
	18	+ end
	19	+ end
	20	+
16	21	describe :authorization do
17	22	before do
18	23	@p1 = Factory :project
...	...