Creating MR comment without a note returns status code 400 (Bad request)

Creating a comment to an existing merge request via API without providing a note returns a status code 400 now, suggesting a bad request. The reason for this is the resource itself (MR) exists but the required property is not set.

Creating MR comment without a note returns status code 400 (Bad request)
Creating a comment to an existing merge request via API without providing a note returns a status code 400 now, suggesting a bad request. The reason for this is the resource itself (MR) exists but the required property is not set.
Sebastian Ziebell
1 parent 3f4e215c
Showing 2 changed files with 8 additions and 0 deletions Show diff stats
lib/api/merge_requests.rb
spec/requests/api/merge_requests_spec.rb
@@ -128,6 +128,9 @@ module Gitlab
         if note.save
           present note, with: Entities::MRNote
         else
+          if note.errors[:note].any?
+            error!(note.errors[:note], 400)
+          end
           not_found!
         end
       end
@@ -87,6 +87,11 @@ describe Gitlab::API do
       response.status.should == 201
       json_response['note'].should == 'My comment'
     end
+
+    it "should return 400 if note is missing" do
+      post api("/projects/#{project.id}/merge_request/#{merge_request.id}/comments", user)
+      response.status.should == 400
+    end
   end
  
 end
...	...	@@ -128,6 +128,9 @@ module Gitlab
128	128	if note.save
129	129	present note, with: Entities::MRNote
130	130	else
	131	+ if note.errors[:note].any?
	132	+ error!(note.errors[:note], 400)
	133	+ end
131	134	not_found!
132	135	end
133	136	end
...	...
...	...	@@ -87,6 +87,11 @@ describe Gitlab::API do
87	87	response.status.should == 201
88	88	json_response['note'].should == 'My comment'
89	89	end
	90	+
	91	+ it "should return 400 if note is missing" do
	92	+ post api("/projects/#{project.id}/merge_request/#{merge_request.id}/comments", user)
	93	+ response.status.should == 400
	94	+ end
90	95	end
91	96
92	97	end
...	...