Remove team_member show page -> use user_path instead

Dmitriy Zaporozhets
1 parent 366bc320
Showing 13 changed files with 34 additions and 178 deletions Show diff stats
app/controllers/team_members_controller.rb
app/decorators/commit_decorator.rb
app/helpers/projects_helper.rb
app/views/milestones/show.html.haml
app/views/team_members/_team_member.html.haml
app/views/team_members/show.html.haml
app/views/teams/members/_show.html.haml
app/views/teams/members/new.html.haml
app/views/teams/members/show.html.haml
app/views/users/_profile.html.haml
app/views/users/show.html.haml
features/project/team_management.feature
features/steps/project/project_team_management.rb
@@ -11,11 +11,6 @@ class TeamMembersController &lt; ProjectResourceController
     @assigned_teams = @project.user_team_project_relationships
   end
-  def show
-    @user_project_relation = project.users_projects.find_by_user_id(member)
-    @events = member.recent_events.in_projects(project).limit(7)
-  end
-
   def new
     @user_project_relation = project.users_projects.new
   end
@@ -81,12 +81,13 @@ class CommitDecorator &lt; ApplicationDecorator
           else
             source_name
           end
-    team_member = @project.try(:team_member_by_name_or_email, source_name, source_email)
-    if team_member.nil?
-      h.mail_to source_email, text.html_safe, class: "commit-#{options[:source]}-link"
+    user = User.where('name like ? or email like ?', source_name, source_email).first
+
+    if user.nil?
+      h.mail_to(source_email, text.html_safe, class: "commit-#{options[:source]}-link")
     else
-      h.link_to text, h.project_team_member_path(@project, team_member), class: "commit-#{options[:source]}-link"
+      h.link_to(text.html_safe, h.user_path(user), class: "commit-#{options[:source]}-link")
     end
   end
 end
@@ -32,17 +32,7 @@ module ProjectsHelper
     author_html = author_html.html_safe
-    tm = project.team_member_by_id(author)
-
-    if tm
-      link_to author_html, project_team_member_path(project, tm.user_username), class: "author_link"
-    else
-      author_html
-    end.html_safe
-  end
-
-  def tm_path team_member
-    project_team_member_path(@project, team_member)
+    link_to(author_html, user_path(author), class: "author_link").html_safe
   end
   def project_title project
@@ -87,7 +87,7 @@
 %h6 Participants:
 %div
   - @users.each do |user|
-    = link_to tm_path(user.tm_of(@project)), class: 'float-link' do
+    = link_to user, class: 'float-link' do
       = user.avatar_image
       = user.name
@@ -3,12 +3,11 @@
 %li{id: dom_id(user), class: "team_member_row user_#{user.id}"}
   .row
     .span4
-      = link_to project_team_member_path(@project, user), title: user.name, class: "dark" do
-        = image_tag gravatar_icon(user.email, 40), class: "avatar s32"
-      = link_to project_team_member_path(@project, user), title: user.name, class: "dark" do
+      = link_to user, title: user.name, class: "dark" do
+        = image_tag gravatar_icon(user.email, 32), class: "avatar s32"
         %strong= truncate(user.name, lenght: 40)
         %br
-        %small.cgray= user.email
+        %small.cgray= user.username
     .span4.pull-right
       - if allow_admin
@@ -23,6 +22,6 @@
         - elsif user.blocked?
           %span.label Blocked
         - elsif allow_admin
-          = link_to project_team_member_path(@project, user), confirm: remove_from_project_team_message(@project, user), method: :delete, class: "btn-tiny btn btn-remove" do
+          = link_to project_team_member_path(@project, user), confirm: remove_from_project_team_message(@project, user), method: :delete, class: "btn-tiny btn btn-remove", title: 'Remove user from team' do
             %i.icon-minus.icon-white
@@ -1,59 +0,0 @@
-- allow_admin = can? current_user, :admin_project, @project
-
-.team_member_show
-  - if can? current_user, :admin_project, @project
-    = link_to 'Remove from team', project_team_member_path(@project, @member), confirm: 'Are you sure?', method: :delete, class: "btn btn-remove pull-right"
-  .profile_avatar_holder
-    = image_tag gravatar_icon(@member.email, 60), class: "borders"
-  %h3.page_title
-    = @member.name
-    %small (@#{@member.username})
-
-  %hr
-  .back_link
-    %br
-    = link_to project_team_index_path(@project), class: "" do
-      &larr; To team list
-  %br
-  .row
-    .span6
-      %table.lite
-        %tr
-          %td Email
-          %td= mail_to @member.email
-        %tr
-          %td Skype
-          %td= @member.skype
-        - unless @member.linkedin.blank?
-          %tr
-            %td LinkedIn
-            %td= @member.linkedin
-        - unless @member.twitter.blank?
-          %tr
-            %td Twitter
-            %td= @member.twitter
-        - unless @member.bio.blank?
-          %tr
-            %td Bio
-            %td= @member.bio
-    .span6
-      %table.lite
-        %tr
-          %td Member since
-          %td= @user_project_relation.created_at.stamp("Aug 21, 2011")
-        %tr
-          %td
-            Project Access:
-            %small (#{link_to "read more", help_permissions_path, class: "vlink"})
-          %td
-            = form_for(@user_project_relation, as: :team_member, url: project_team_member_path(@project, @member)) do |f|
-              = f.select :project_access, options_for_select(Project.access_options, @user_project_relation.project_access), {}, class: "project-access-select", disabled: !allow_admin
-  %hr
-  = render @events
-:javascript
-  $(function(){
-    $('.repo-access-select, .project-access-select').live("change", function() {
-      $(this.form).submit();
-    });
-  })
-
@@ -8,7 +8,7 @@
       = link_to user_path(user.username), title: user.name, class: "dark" do
         %strong= truncate(user.name, lenght: 40)
         %br
-        %small.cgray= user.email
+        %small.cgray= user.username
     .span4
       - if allow_admin
@@ -15,7 +15,7 @@
         %tr.member
           %td
             = member.name
-            %small= "(#{member.email})"
+            %small= "(#{member.username})"
           %td= @team.human_default_projects_access(member)
           %td= @team.admin?(member) ? "Admin" : "Member"
           %td
@@ -1,60 +0,0 @@
-- allow_admin = can? current_user, :admin_project, @project
-- user = @team_member.user
-
-.team_member_show
-  - if can? current_user, :admin_project, @project
-    = link_to 'Remove from team', project_team_member_path(project_id: @project, id: @team_member.id), confirm: 'Are you sure?', method: :delete, class: "pull-right btn btn-remove"
-  .profile_avatar_holder
-    = image_tag gravatar_icon(user.email, 60), class: "borders"
-  %h3.page_title
-    = user.name
-    %small (@#{user.username})
-
-  %hr
-  .back_link
-    %br
-    = link_to project_team_index_path(@project), class: "" do
-      &larr; To team list
-  %br
-  .row
-    .span6
-      %table.lite
-        %tr
-          %td Email
-          %td= mail_to user.email
-        %tr
-          %td Skype
-          %td= user.skype
-        - unless user.linkedin.blank?
-          %tr
-            %td LinkedIn
-            %td= user.linkedin
-        - unless user.twitter.blank?
-          %tr
-            %td Twitter
-            %td= user.twitter
-        - unless user.bio.blank?
-          %tr
-            %td Bio
-            %td= user.bio
-    .span6
-      %table.lite
-        %tr
-          %td Member since
-          %td= @team_member.created_at.stamp("Aug 21, 2011")
-        %tr
-          %td
-            Project Access:
-            %small (#{link_to "read more", help_permissions_path, class: "vlink"})
-          %td
-            = form_for(@team_member, as: :team_member, url: project_team_member_path(@project, @team_member)) do |f|
-              = f.select :project_access, options_for_select(Project.access_options, @team_member.project_access), {}, class: "project-access-select", disabled: !allow_admin
-  %hr
-  = render @events
-:javascript
-  $(function(){
-    $('.repo-access-select, .project-access-select').live("change", function() {
-      $(this.form).submit();
-    });
-  })
-
@@ -3,21 +3,21 @@
     Profile
   %ul.well-list
     %li
-      %strong Email
-      %span.pull-right= mail_to user.email
+      %span.light Member since
+      %strong= user.created_at.stamp("Aug 21, 2011")
     - unless user.skype.blank?
       %li
-        %strong Skype
-        %span.pull-right= user.skype
+        %span.light Skype:
+        %strong= user.skype
     - unless user.linkedin.blank?
       %li
-        %strong LinkedIn
-        %span.pull-right= user.linkedin
+        %span.light LinkedIn:
+        %strong= user.linkedin
     - unless user.twitter.blank?
       %li
-        %strong Twitter
-        %span.pull-right= user.twitter
+        %span.light Twitter:
+        %strong= user.twitter
     - unless user.bio.blank?
       %li
-        %strong Bio
-        %span.pull-right= user.bio
+        %span.light Bio:
+        %span= user.bio
@@ -9,7 +9,7 @@
             %i.icon-edit
             Edit Profile
       %br
-      %small @#{@user.username}
+      %small #{@user.username}
       %br
       %small member since #{@user.created_at.stamp("Nov 12, 2031")}
     .clearfix
@@ -23,13 +23,8 @@ Feature: Project Team management
     Then I visit project "Shop" team page
     And I should see "Sam" in team list as "Reporter"
-  Scenario: View team member profile
-    Given I click link "Sam"
-    Then I should see "Sam" team profile
-
   Scenario: Cancel team member
-    Given I click link "Sam"
-    And I click link "Remove from team"
+    Given I click cancel link for "Sam"
     Then I visit project "Shop" team page
     And I should not see "Sam" in team list
@@ -5,13 +5,13 @@ class ProjectTeamManagement &lt; Spinach::FeatureSteps
   Then 'I should be able to see myself in team' do
     page.should have_content(@user.name)
-    page.should have_content(@user.email)
+    page.should have_content(@user.username)
   end
   And 'I should see "Sam" in team list' do
     user = User.find_by_name("Sam")
     page.should have_content(user.name)
-    page.should have_content(user.email)
+    page.should have_content(user.username)
   end
   Given 'I click link "New Team Member"' do
@@ -52,17 +52,6 @@ class ProjectTeamManagement &lt; Spinach::FeatureSteps
     role_id.should == UsersProject.access_roles["Reporter"].to_s
   end
-  Given 'I click link "Sam"' do
-    first(:link, "Sam").click
-  end
-
-  Then 'I should see "Sam" team profile' do
-    user = User.find_by_name("Sam")
-    page.should have_content(user.name)
-    page.should have_content(user.email)
-    page.should have_content("To team list")
-  end
-
   And 'I click link "Remove from team"' do
     click_link "Remove from team"
   end
@@ -70,7 +59,7 @@ class ProjectTeamManagement &lt; Spinach::FeatureSteps
   And 'I should not see "Sam" in team list' do
     user = User.find_by_name("Sam")
     page.should_not have_content(user.name)
-    page.should_not have_content(user.email)
+    page.should_not have_content(user.username)
   end
   And 'gitlab user "Mike"' do
@@ -106,4 +95,10 @@ class ProjectTeamManagement &lt; Spinach::FeatureSteps
     select 'Website', from: 'source_project_id'
     click_button 'Import'
   end
+
+  step 'I click cancel link for "Sam"' do
+    within "#user_#{User.find_by_name('Sam').id}" do
+      click_link('Remove user from team')
+    end
+  end
 end
	@@ -32,17 +32,7 @@ module ProjectsHelper		@@ -32,17 +32,7 @@ module ProjectsHelper
32		32
33	author_html = author_html.html_safe	33	author_html = author_html.html_safe
34		34
35	- tm = project.team_member_by_id(author)
36	-
37	- if tm
38	- link_to author_html, project_team_member_path(project, tm.user_username), class: "author_link"
39	- else
40	- author_html
41	- end.html_safe
42	- end
43	-
44	- def tm_path team_member
45	- project_team_member_path(@project, team_member)	35	+ link_to(author_html, user_path(author), class: "author_link").html_safe
46	end	36	end
47		37
48	def project_title project	38	def project_title project
	@@ -87,7 +87,7 @@		@@ -87,7 +87,7 @@
87	%h6 Participants:	87	%h6 Participants:
88	%div	88	%div
89	- @users.each do \|user\|	89	- @users.each do \|user\|
90	- = link_to tm_path(user.tm_of(@project)), class: 'float-link' do	90	+ = link_to user, class: 'float-link' do
91	= user.avatar_image	91	= user.avatar_image
92	= user.name	92	= user.name
93		93
	@@ -1,59 +0,0 @@	@@ -1,59 +0,0 @@
1	-- allow_admin = can? current_user, :admin_project, @project
2	-
3	-.team_member_show
4	- - if can? current_user, :admin_project, @project
5	- = link_to 'Remove from team', project_team_member_path(@project, @member), confirm: 'Are you sure?', method: :delete, class: "btn btn-remove pull-right"
6	- .profile_avatar_holder
7	- = image_tag gravatar_icon(@member.email, 60), class: "borders"
8	- %h3.page_title
9	- = @member.name
10	- %small (@#{@member.username})
11	-
12	- %hr
13	- .back_link
14	- %br
15	- = link_to project_team_index_path(@project), class: "" do
16	- ← To team list
17	- %br
18	- .row
19	- .span6
20	- %table.lite
21	- %tr
22	- %td Email
23	- %td= mail_to @member.email
24	- %tr
25	- %td Skype
26	- %td= @member.skype
27	- - unless @member.linkedin.blank?
28	- %tr
29	- %td LinkedIn
30	- %td= @member.linkedin
31	- - unless @member.twitter.blank?
32	- %tr
33	- %td Twitter
34	- %td= @member.twitter
35	- - unless @member.bio.blank?
36	- %tr
37	- %td Bio
38	- %td= @member.bio
39	- .span6
40	- %table.lite
41	- %tr
42	- %td Member since
43	- %td= @user_project_relation.created_at.stamp("Aug 21, 2011")
44	- %tr
45	- %td
46	- Project Access:
47	- %small (#{link_to "read more", help_permissions_path, class: "vlink"})
48	- %td
49	- = form_for(@user_project_relation, as: :team_member, url: project_team_member_path(@project, @member)) do \|f\|
50	- = f.select :project_access, options_for_select(Project.access_options, @user_project_relation.project_access), {}, class: "project-access-select", disabled: !allow_admin
51	- %hr
52	- = render @events
53	-:javascript
54	- $(function(){
55	- $('.repo-access-select, .project-access-select').live("change", function() {
56	- $(this.form).submit();
57	- });
58	- })
59	-
	@@ -8,7 +8,7 @@		@@ -8,7 +8,7 @@
8	= link_to user_path(user.username), title: user.name, class: "dark" do	8	= link_to user_path(user.username), title: user.name, class: "dark" do
9	%strong= truncate(user.name, lenght: 40)	9	%strong= truncate(user.name, lenght: 40)
10	%br	10	%br
11	- %small.cgray= user.email	11	+ %small.cgray= user.username
12		12
13	.span4	13	.span4
14	- if allow_admin	14	- if allow_admin
	@@ -15,7 +15,7 @@		@@ -15,7 +15,7 @@
15	%tr.member	15	%tr.member
16	%td	16	%td
17	= member.name	17	= member.name
18	- %small= "(#{member.email})"	18	+ %small= "(#{member.username})"
19	%td= @team.human_default_projects_access(member)	19	%td= @team.human_default_projects_access(member)
20	%td= @team.admin?(member) ? "Admin" : "Member"	20	%td= @team.admin?(member) ? "Admin" : "Member"
21	%td	21	%td
	@@ -1,60 +0,0 @@	@@ -1,60 +0,0 @@
1	-- allow_admin = can? current_user, :admin_project, @project
2	-- user = @team_member.user
3	-
4	-.team_member_show
5	- - if can? current_user, :admin_project, @project
6	- = link_to 'Remove from team', project_team_member_path(project_id: @project, id: @team_member.id), confirm: 'Are you sure?', method: :delete, class: "pull-right btn btn-remove"
7	- .profile_avatar_holder
8	- = image_tag gravatar_icon(user.email, 60), class: "borders"
9	- %h3.page_title
10	- = user.name
11	- %small (@#{user.username})
12	-
13	- %hr
14	- .back_link
15	- %br
16	- = link_to project_team_index_path(@project), class: "" do
17	- ← To team list
18	- %br
19	- .row
20	- .span6
21	- %table.lite
22	- %tr
23	- %td Email
24	- %td= mail_to user.email
25	- %tr
26	- %td Skype
27	- %td= user.skype
28	- - unless user.linkedin.blank?
29	- %tr
30	- %td LinkedIn
31	- %td= user.linkedin
32	- - unless user.twitter.blank?
33	- %tr
34	- %td Twitter
35	- %td= user.twitter
36	- - unless user.bio.blank?
37	- %tr
38	- %td Bio
39	- %td= user.bio
40	- .span6
41	- %table.lite
42	- %tr
43	- %td Member since
44	- %td= @team_member.created_at.stamp("Aug 21, 2011")
45	- %tr
46	- %td
47	- Project Access:
48	- %small (#{link_to "read more", help_permissions_path, class: "vlink"})
49	- %td
50	- = form_for(@team_member, as: :team_member, url: project_team_member_path(@project, @team_member)) do \|f\|
51	- = f.select :project_access, options_for_select(Project.access_options, @team_member.project_access), {}, class: "project-access-select", disabled: !allow_admin
52	- %hr
53	- = render @events
54	-:javascript
55	- $(function(){
56	- $('.repo-access-select, .project-access-select').live("change", function() {
57	- $(this.form).submit();
58	- });
59	- })
60	-
	@@ -9,7 +9,7 @@		@@ -9,7 +9,7 @@
9	%i.icon-edit	9	%i.icon-edit
10	Edit Profile	10	Edit Profile
11	%br	11	%br
12	- %small @#{@user.username}	12	+ %small #{@user.username}
13	%br	13	%br
14	%small member since #{@user.created_at.stamp("Nov 12, 2031")}	14	%small member since #{@user.created_at.stamp("Nov 12, 2031")}
15	.clearfix	15	.clearfix