Refactoring: get rid of ruby antipattern unless/else and use if/else instead

Andrey Vakarev
1 parent f33cf247
Showing 1 changed file with 3 additions and 3 deletions Show diff stats
app/controllers/application_controller.rb
@@ -97,12 +97,12 @@ class ApplicationController &lt; ActionController::Base
   end
  
   def load_refs
-    unless params[:ref].blank?
-      @ref = params[:ref]
-    else
+    if params[:ref].blank?
       @branch = params[:branch].blank? ? nil : params[:branch]
       @tag = params[:tag].blank? ? nil : params[:tag]
       @ref = @branch || @tag || @project.try(:default_branch) || Repository.default_ref
+    else
+      @ref = params[:ref]
     end
   end
...	...	@@ -97,12 +97,12 @@ class ApplicationController < ActionController::Base
97	97	end
98	98
99	99	def load_refs
100		- unless params[:ref].blank?
101		- @ref = params[:ref]
102		- else
	100	+ if params[:ref].blank?
103	101	@branch = params[:branch].blank? ? nil : params[:branch]
104	102	@tag = params[:tag].blank? ? nil : params[:tag]
105	103	@ref = @branch \|\| @tag \|\| @project.try(:default_branch) \|\| Repository.default_ref
	104	+ else
	105	+ @ref = params[:ref]
106	106	end
107	107	end
108	108
...	...