25 Feb, 2014

6 commits

  • 2c28dbd2   commit description in commit list Browse Dir »
    skv-headless
     
  • 5f31caa0   Fix read_group ability ... Browse Dir » 
    Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
    Dmitriy Zaporozhets
     
  • c3a3f80a   Merge branch 'cleaner-email-headers' into 'master' ... Browse Dir » 
    Cleaner headers in Notification Emails

Make the informations available in the notification email headers (sender, recipient, subject, etc.) more readable and meaningful.

* Remove the email subject prefix
* Don't write the project namespace in email subjects
* Write the issue/merge request title in the notification email subject
* Make the email appear as sent from the action author (the actual email address is still `gitlab@gitlab.com`)

For instance, this is the notification email for a new issue comment before:

> From: gitlab@gitlab.com
> To: myemailaddress@gmail.com
> Subject: GitLab | GitLab HQ / GitLab-Shell | New note for issue #1234

And after :

> From: Nick Brown <gitlab@gitlab.com>
> To: myemailaddress@gmail.com
> Subject: GitLab-Shell |  Add local update hook  (#1234)

The recipient of the notification can easily get the gist of the message without even opening it — just by looking at how it appears in her inbox. None of the actual email addresses (From, To, Reply-to) changes, just the display name.

Having a consistent subject for all notification emails sent about some resource also allow good email clients to group the discussion by thread (although grouping in Mail.app still needs some work).
    Dmitriy Zaporozhets
     
  • 75eed4eb   Implement project collection service ... Browse Dir » 
    Main purpose is move big amount of methods from user, group, project
models and place filtering logic in one place.
It also fixes 500 error on group page for PostgreSQL

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
    Dmitriy Zaporozhets
     
  • 9f20580e   Merge pull request #6375 from cirosantilli/link-with-id ... Browse Dir » 
    Blob and tree gfm links to anchors work.
    Dmitriy Zaporozhets
     
  • 44013827   Fix 500 error when try to update own profile in admin area ... Browse Dir » 
    Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
    Dmitriy Zaporozhets
     

24 Feb, 2014

14 commits

23 Feb, 2014

1 commit

21 Feb, 2014

5 commits

20 Feb, 2014

7 commits

19 Feb, 2014

7 commits

  • 96dded3e   Send emails from the author ... Browse Dir » 
    This changes the email "From" field from "gitlab@example.com" to either:

* "John Doe <gitlab@example.com>" if the author of the action is known,
* "GitLab <gitlab@example.com>" otherwise.

Rationale: this allow mails to appear as if they were sent by the
author. It appears in the mailbox more like a real discussion between
the sender and the receiver ("John sent: we should refactor this") and
less like a robot notifying about something.
    Pierre de La Morinerie
     
  • 57cb1ca7   Write the issue/merge request title in the notification email subject ... Browse Dir » 
    This changes the email subjects for issues and merge request
notifications from:

    Team / Project | Note for issue #1234

to:

    Team / Project | Saving issue doesn't work sometimes (#1234)

Rationale:

* Scan the subject of the email notification more easily when catching
up with a lot of notifications. Instead of having to open the email to
get the title of the issue or merge request, one can simply read the
subject of the email.

* Group messages by subject: email clients will group emails in threads
if they have the same subject.
    Pierre de La Morinerie
     
  • d8a24003   Don't write the project namespace in email subjects ... Browse Dir » 
    For instance, the email "Subject" field changes from:

    Mattt / Ground Control | Saving issue doesn't work sometimes (#1234)

to:

    Ground Control | Saving issue doesn't work sometimes (#1234)

Rationale:

* Most people are receiving email notifications about a single fork:
the project activity, issues and merge requests are happening either
in a root repository or in a fork, but less often in several forks.

* It removes noise from the email subject. The namespace of the project
can still be read in the email body.

* For Entreprise users that have a single namespace "MyEntreprise",
having this repeated in every email subject is very noisy.
    Pierre de La Morinerie
     
  • 44ab156e   Remove the email subject prefix ... Browse Dir » 
    This changes email subjects from:

    GitLab | Team / Project | Note for issue #1234

to:

    Team / Project | Note for issue #1234

Rationale:

* Emails should be as meaningful as possible, and emphasize content over
chrome. The "GitLab" name is more chrome than content.

* Users can tell an email coming from GitLab by the sender or the header
in the email content.

* An organization that works mainly with GitLab knows that
every SVC email comes from GitLab. For these organizations, having
"GitLab" in front of every email is just noise hiding the meaningful
information.
    Pierre de La Morinerie
     
  • 49cb1c72   Fix misleading comment Browse Dir »
    Pierre de La Morinerie
     
  • 2b8d2891   Fix readme h4 style ... Browse Dir » 
    Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
    Dmitriy Zaporozhets
     
  • ee750298   Move assignee/milestone below description of Issue ... Browse Dir » 
    Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
    Dmitriy Zaporozhets