Software Publico / Gitlab

18 Jun, 2014

1 commit

780d868f Revert "Merge branch 'fix-email-threading' into 'master'" ... Browse File »

This reverts commit 97fd990ecde387290be269ef7daafa5761f94af6, reversing
changes made to f451a697e0c018359e6d8ff3aaba4eb0484c4bee.

Conflicts:
	app/mailers/emails/notes.rb
	app/mailers/emails/projects.rb

2014-06-18 13:41:12 +0200

10 Jun, 2014

2 commits

de90b572 Allow more mail clients to group emails by thread ... Browse File »

* send a ‘In-Reply-To’ header along the ‘References’ header
* subject of answers to an existing thread begins with ‘Re: ’

This fixes threading with at least Mail.app and Airmail.

2014-06-10 17:09:15 +0200

466b768b Send notification emails to the "project", and put people in Cc ... Browse File »

This fixes email threading in Mail.app, that doesn't like when a thread
doesn't have stable recipients.

For instance, here is a possible sender-recipient combinations before:

From: A
To: Me
New issue

From: B
To: Me
Reply on new issue

From: A
To: Me
Another reply

Mail.app doesn't see B as a participant to the original email thread,
and decides to break the thread: it will group all messages from A
together, and separately all messages from B.

This commit makes the thread look like this:

From: A
To: gitlab/project
Cc: Me
New issue

From: B
To: gitlab/project
Cc: Me
Reply on new issue

From: A
To: gitlab/project
Cc: Me
Another reply

Mail.app sees a common recipient, and group the thread correctly.

2014-06-10 17:09:15 +0200

05 May, 2014

1 commit

06bed543 Added email threading for update emails on issues and merge requests (if the mai… ... Browse File »
```
…l client support the References: mail header)
```
Philip Blatter
2014-05-05 21:46:51 +0200

19 Feb, 2014

4 commits

96dded3e Send emails from the author ... Browse File »

This changes the email "From" field from "gitlab@example.com" to either:

* "John Doe <gitlab@example.com>" if the author of the action is known,
* "GitLab <gitlab@example.com>" otherwise.

Rationale: this allow mails to appear as if they were sent by the
author. It appears in the mailbox more like a real discussion between
the sender and the receiver ("John sent: we should refactor this") and
less like a robot notifying about something.

2014-02-19 18:25:18 +0100

d8a24003 Don't write the project namespace in email subjects ... Browse File »

For instance, the email "Subject" field changes from:

    Mattt / Ground Control | Saving issue doesn't work sometimes (#1234)

to:

    Ground Control | Saving issue doesn't work sometimes (#1234)

Rationale:

* Most people are receiving email notifications about a single fork:
the project activity, issues and merge requests are happening either
in a root repository or in a fork, but less often in several forks.

* It removes noise from the email subject. The namespace of the project
can still be read in the email body.

* For Entreprise users that have a single namespace "MyEntreprise",
having this repeated in every email subject is very noisy.

2014-02-19 18:25:18 +0100

44ab156e Remove the email subject prefix ... Browse File »

This changes email subjects from:

    GitLab | Team / Project | Note for issue #1234

to:

    Team / Project | Note for issue #1234

Rationale:

* Emails should be as meaningful as possible, and emphasize content over
chrome. The "GitLab" name is more chrome than content.

* Users can tell an email coming from GitLab by the sender or the header
in the email content.

* An organization that works mainly with GitLab knows that
every SVC email comes from GitLab. For these organizations, having
"GitLab" in front of every email is just noise hiding the meaningful
information.

2014-02-19 18:25:18 +0100

49cb1c72 Fix misleading comment Browse File »

Pierre de La Morinerie
2014-02-19 18:25:18 +0100

24 Jan, 2014

1 commit

39a2adf4 Fix broken test in spec/models/project_spec.rb ... Browse File »

A test was broken if running on a non-standard port.
Made checking for (non-)standard port more robust.
Changed gitlab_on_non_standard_port to gitlab_on_standard_port (less negative).

2014-01-24 21:14:05 -0600

09 Dec, 2013

1 commit

ccf2e48a Set noreply@HOSTNAME for reply_to field in all emails ... Browse File »
```
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
```
Dmitriy Zaporozhets
2013-12-09 16:36:21 +0200

11 Sep, 2013

1 commit

73446fe1 Email templates when user was added to group Browse File »

Dmitriy Zaporozhets
2013-09-11 21:17:28 +0300

17 Jul, 2013

1 commit

539c70c7 Update emails to describe path using for_fork? ... Browse File »

Forked MR's will print

Project:Branch <source_project_with_path>:<source_branch> -> <target_project_with_path>:<target_branch>

Non forked MR's will print

Branch <source_branch> -> <target_branch>

Change-Id: I89399aec2e7fde8e4b64b110a48099a95ae4f038

2013-07-17 22:48:03 -0400

19 Mar, 2013

1 commit

a3cdaeef refactor emails a bit. Add email on ssh key creation Browse File »

Dmitriy Zaporozhets
2013-03-19 20:00:41 +0200

01 Feb, 2013

2 commits

591e094e Add a delay for sending emails Browse File »

Dmitriy Zaporozhets
2013-02-01 17:04:41 +0200
cc2484c3 Fix sending commit note email to id instead email Browse File »

Dmitriy Zaporozhets
2013-02-01 08:59:30 +0200

15 Jan, 2013

2 commits

211c06e4 Fix few test and notify for commit author Browse File »

Dmitriy Zaporozhets
2013-01-15 13:37:20 +0200

30227869 Merge commit 'master' into discussions ... Browse File »

Conflicts:
	app/assets/stylesheets/sections/notes.scss
	app/contexts/notes/load_context.rb
	app/models/project.rb
	app/observers/note_observer.rb
	app/roles/votes.rb
	app/views/commit/show.html.haml
	app/views/merge_requests/_show.html.haml
	app/views/merge_requests/diffs.js.haml
	app/views/merge_requests/show.js.haml
	app/views/notes/_note.html.haml
	features/steps/project/project_merge_requests.rb
	spec/models/note_spec.rb