25 Mar, 2014

1 commit


24 Mar, 2014

3 commits

  •  Don't send an email for "mentioned in" notes
    
    Currently, an email is sent every time a mentionable is referenced by an issue, a commit or a merge request: if I comment "This MR is related to #5", the watchers get one email for the comment, and another one stating "Issue #5 was mentioned by issue #13".
    
    This is annoying — but the biggest issue is when pushing an existing branch. Every issue referenced by commit messages in this branch will get a new mention (which is fine), and dozens of emails will be sent for all these new mentions (which is not).
    
    This commit fixes the spam by avoiding to send an email when a new mention is added to an existing mentionable. In most cases the email notification sent by the mentioner is enough.
    Dmitriy Zaporozhets
     
  • The 'author_id_of_changes' attribute is not persisted in the database.
    As we retrieve the merge request from the DB just before sending the
    email, this attribute was always nil.
    
    Also there was no tests for the merge notification code - tests have
    been added.
    
    Fix #6605
    Pierre de La Morinerie
     
  • Small changes
    Dmitriy Zaporozhets
     

22 Mar, 2014

2 commits


20 Mar, 2014

1 commit

  • Currently this method responds with `text/html`. It is kind of unusable
    if you open it in a browser. The browser thinks it is HTML and renders
    it as HTML, meaning new lines are dropped. So it's very hard to
    distinguish where the key starts and where it ends.
    
    This commit changes the content type header to `text/plain`.
    Dmitry Medvinsky
     

19 Mar, 2014

5 commits


18 Mar, 2014

1 commit


17 Mar, 2014

4 commits


16 Mar, 2014

1 commit


14 Mar, 2014

1 commit


13 Mar, 2014

1 commit


12 Mar, 2014

1 commit


11 Mar, 2014

2 commits

  • Streamline the content of notification emails
    
    In notification emails, the actual content of the email is often buried under several blocks of chrome — and may even be truncated or completely missing. Ideally, the notification emails would be like *real emails*: a short message of meaningful text, sent from the author of the change that triggered the notification.
    
    This MR includes the following changes to notification emails:
    
    * Remove much of the chrome (e.g. the "GitLab" header)
    * Emphasize the content (no more small, grayed-out content)
    * Add missing informations to the emails (issue description in "new issue" email, file name in "diff comment" email)
    * Add a consistent "View in GitLab" link in the footer
    * The assignee is displayed only if someone is assigned
    * Fix a rendering bug when viewing emails with [Zimbra](http://www.zimbra.com/)
    
    We use these patches at [Capitaine Train](http://www.capitainetrain.com), and it has been a surprisingly big productivity boost for us.
    
    ![Before and after](http://f.cl.ly/items/3n0P2c2v1P0y011c0D3e/Before%20and%20After.png)
    Dmitriy Zaporozhets
     
  • LDAP code from EE
    Dmitriy Zaporozhets
     

10 Mar, 2014

2 commits


09 Mar, 2014

1 commit


06 Mar, 2014

3 commits


05 Mar, 2014

3 commits


03 Mar, 2014

6 commits


02 Mar, 2014

1 commit


28 Feb, 2014

1 commit