25 Mar, 2013

1 commit


18 Mar, 2013

1 commit


07 Mar, 2013

2 commits


06 Mar, 2013

1 commit


05 Mar, 2013

5 commits


01 Mar, 2013

2 commits


27 Feb, 2013

6 commits


20 Feb, 2013

3 commits


16 Feb, 2013

1 commit

  • When a user is not authorized to see the list of hooks for a project, he is
    still able to access the hooks separately. For example if access to
    `GET /projects/:id/hooks` fails and returns a `403 Unauthorized` error it is
    still possible to access a hook directly via `GET /projects/:id/hooks/:hook_id`.
    
    Fixes access, also added tests to check access and status codes of hooks.
    Sebastian Ziebell
     

14 Feb, 2013

2 commits


13 Feb, 2013

4 commits


12 Feb, 2013

1 commit

  • Different status codes in the API lib are returned on hook creation, update or deletion.
    If a required parameter is not given (e.g. `url` in `/projects/:id/hooks/:hook_id`) status
    code 400 (Bad request) is returned. On hook deletion a 200 status code is returned, regardless if
    the hook is present or not. This makes the DELETE function an idempotent operation. Appropriate tests
    are added to check these status codes.
    Sebastian Ziebell
     

09 Feb, 2013

1 commit


08 Feb, 2013

4 commits


01 Feb, 2013

1 commit

  • The attempt to revoke project access for a user that was not member of the
    project results in a 500 Internal Server error where it actually should
    result in a 200 OK since after the operation, the user is not member of
    the project. This turns the operation into an idempotent call that can
    be repeated with no ill effects.
    
    Updated the spec and changed the code accordingly. However, the result differs
    slightly, as we can't return the users project access level if the user was not
    member. I'm not aware if anybody relies on the result of this call.
    
    Fixes #2832
    Felix Gilcher
     

31 Jan, 2013

1 commit


18 Jan, 2013

1 commit


17 Jan, 2013

1 commit


04 Jan, 2013

1 commit


02 Jan, 2013

1 commit