05 Nov, 2013

4 commits


04 Nov, 2013

1 commit

  • - Database name may contain characters which are not shell friendly
    - Database password could contain the same
    - While we at it there is no harm in escaping generated paths too
    - Refactored 2-line system(command)
    
    Signed-off-by: Nigel Kukard <nkukard@lbsd.net>
    Nigel Kukard
     

03 Nov, 2013

1 commit

  • The blocked? method is used to check whether a user exists in LDAP. Prior to this change, if the LDAP server had more objects below the one pointed to by the DN, those objects would also be picked up by the search, causing the method to determine the user should be blocked.
    
    One case where this can happen is when using Active Directory and a user have a mobile phone assigned. In this case, Exchange will add an entry called ExchangeActiveSyncDevices under the users entry. The user-visible behaviour is then that a user loses Gitlab access when he enables a mobile device.
    
    This fix sets the search scope to BaseObject in order to ensure that only the user itself is returned.
    Elias Mårtenson
     

01 Nov, 2013

4 commits


31 Oct, 2013

2 commits


29 Oct, 2013

3 commits


28 Oct, 2013

1 commit


25 Oct, 2013

3 commits


24 Oct, 2013

3 commits


17 Oct, 2013

1 commit


16 Oct, 2013

7 commits


15 Oct, 2013

2 commits


14 Oct, 2013

2 commits


11 Oct, 2013

4 commits


10 Oct, 2013

2 commits