Remove validates presence of cnpj and coroporate name

Signed-off-by: Luciano Prestes Cavalcanti <lucianopcbr@gmail.com> Signed-off-by: Simiao Carvalho <simiaosimis@gmail.com>

Remove validates presence of cnpj and coroporate name
Signed-off-by: Luciano Prestes Cavalcanti <lucianopcbr@gmail.com> Signed-off-by: Simiao Carvalho <simiaosimis@gmail.com>
Luciano Prestes · Thiago Ribeiro
1 parent cb896ae4
Showing 4 changed files with 15 additions and 29 deletions Show diff stats
lib/institution.rb
test/unit/private_institution_test.rb
test/unit/public_institution_test.rb
views/gov_user_plugin/_institution.html.erb
@@ -23,8 +23,7 @@ class Institution &lt; ActiveRecord::Base
                   :corporate_name
   validates :name, :presence=>true, :uniqueness=>true
-
-  validates :corporate_name, :presence => true
+  validates :cnpj, :uniqueness=>true
   before_save :verify_institution_type
@@ -35,7 +34,7 @@ class Institution &lt; ActiveRecord::Base
   }
   validate :validate_country, :validate_state, :validate_city,
-           :verify_institution_type, :validate_cnpj, :validate_format_cnpj
+           :verify_institution_type, :validate_format_cnpj
   protected
@@ -57,7 +56,7 @@ class Institution &lt; ActiveRecord::Base
   def validate_country
     unless self.community.blank?
-       if self.community.country.blank? && self.errors[:country].blank?
+      if self.community.country.blank? && self.errors[:country].blank?
         self.errors.add(:country, _("can't be blank"))
         return false
       end
@@ -94,7 +93,8 @@ class Institution &lt; ActiveRecord::Base
   end
   def validate_format_cnpj
-    return true if !self.community.blank? && self.community.country != "BR"
+    return true if self.community.blank? && self.community.country != "BR"
+    return true if self.cnpj.blank?
     format =  /^\d{2}\.\d{3}\.\d{3}\/\d{4}\-\d{2}$/
@@ -105,15 +105,4 @@ class Institution &lt; ActiveRecord::Base
       return false
     end
   end
-
-  def validate_cnpj
-    if !self.community.blank? && self.community.country == "BR"
-      if self.cnpj.blank? && self.errors[:cnpj].blank?
-        self.errors.add(:cnpj, _("can't be blank"))
-        return false
-      end
-    end
-
-    return true
-  end
 end
@@ -19,11 +19,10 @@ class PrivateInstitutionTest &lt; ActiveSupport::TestCase
     Institution.destroy_all
   end
-  should "not save without a cnpj" do
+  should "save without a cnpj" do
     @institution.cnpj = nil
-    assert !@institution.save
-    assert @institution.errors.full_messages.include? "Cnpj can't be blank"
+    assert @institution.save
   end
   should "not save with a repeated cnpj" do
@@ -32,9 +32,9 @@ class PublicInstitutionTest &lt; ActiveSupport::TestCase
     @institution = nil
   end
-  should "not save without a cnpj" do
+  should "save without a cnpj" do
     @institution.cnpj = nil
-    assert !@institution.save
+    assert @institution.save
   end
   should "save institution without an acronym" do
@@ -43,10 +43,10 @@
       <%= required f.text_field(:name, :class => flash[:error_community_name], :value => params[:community][:name]) %>
       <%= content_tag :span, _("Institution name already exists"), :id=>"already_exists_text", :class=>"errorExplanation hide-field" %>
-      <span class='required-field'>
+      <span class='optional-field'>
         <div class="formfield type-text">
           <%= inst.label "corporate_name", _("Corporate Name"), :class=>"formlabel" %>
-          <%= required inst.text_field(:corporate_name, :value => params[:institutions][:corporate_name], :size => 55, :class => flash[:error_institution_corporate_name]) %>
+          <%= inst.text_field(:corporate_name, :value => params[:institutions][:corporate_name], :size => 55) %>
         </div>
       </span>
@@ -62,12 +62,10 @@
       <%= required f.text_field(:city, :class => flash[:error_community_city], :value => params[:community][:city]) %>
-      <span class='required-field'>
-        <div class="formfield type-text">
-          <%= inst.label("cnpj" ,_("CNPJ"), :class=>"formlabel") %>
-          <%= required inst.text_field(:cnpj, :placeholder=>"99.999.999/9999-99", :class=>"intitution_cnpj_field #{flash[:error_institution_cnpj]}", :value => params[:institutions][:cnpj]) %>
-        </div>
-      </span>
+      <div class="formfield type-text">
+        <%= inst.label("cnpj" ,_("CNPJ"), :class=>"formlabel") %>
+        <%= required inst.text_field(:cnpj, :placeholder=>"99.999.999/9999-99", :class=>"intitution_cnpj_field", :value => params[:institutions][:cnpj]) %>
+      </div>
       <span class='optional-field'>
         <div class="formfield type-text">
	@@ -32,9 +32,9 @@ class PublicInstitutionTest < ActiveSupport::TestCase		@@ -32,9 +32,9 @@ class PublicInstitutionTest < ActiveSupport::TestCase
32	@institution = nil	32	@institution = nil
33	end	33	end
34		34
35	- should "not save without a cnpj" do	35	+ should "save without a cnpj" do
36	@institution.cnpj = nil	36	@institution.cnpj = nil
37	- assert !@institution.save	37	+ assert @institution.save
38	end	38	end
39		39
40	should "save institution without an acronym" do	40	should "save institution without an acronym" do