Download as
Browse Code »

Commit 9769663aa1185b58f1ba84c0514249fb6c93eb57

Authored by Luciano Prestes
Committed by Thiago Ribeiro
1 parent e3871694
Exists in refactor_software_info_365

Refactor software_communities classes 

Signed-off-by: Luciano Prestes Cavalcanti <lucianopcbr@gmail.com>
Signed-off-by: Marcos Ronaldo <marcos.rpj2@gmail.com>
Showing 3 changed files with 5 additions and 15 deletions   Show diff stats
lib/software_communities_plugin.rb
  Diff comments   View file @9769663
... ... @@ -102,7 +102,6 @@ class SoftwareCommunitiesPlugin &lt; Noosfero::Plugin
102 102 is_admin ||= user_rating.organization.admins.include?(current_user.person)
103 103  
104 104 if is_admin and profile.software?
105   -
106 105 render :file => 'organization_ratings_extra_fields_show_data',
107 106 :locals => {:user_rating => user_rating}
108 107 end
... ...
lib/software_helper.rb
  Diff comments   View file @9769663
... ... @@ -27,18 +27,10 @@ module SoftwareHelper
27 27  
28 28 table.each do |key, value|
29 29 unless ignored_fields.include? key
30   - filled_fields << if value.empty?
31   - false
32   - else
33   - true
34   - end
  30 + filled_fields << !value.empty?
35 31 end
36 32 end
37 33  
38   - if filled_fields.include? true
39   - false
40   - else
41   - true
42   - end
  34 + return !filled_fields.include?(true)
43 35 end
44 36 end
... ...
lib/software_language_helper.rb
  Diff comments   View file @9769663
... ... @@ -50,10 +50,9 @@ class SoftwareLanguageHelper &lt; DynamicTableHelper
50 50  
51 51 def self.language_html_structure(language_data, disabled)
52 52 language_id = language_data[:programming_language_id]
53   - language_name = if language_data[:programming_language_id].blank?
54   - ""
55   - else
56   - ProgrammingLanguage.find(
  53 + language_name = ""
  54 + unless language_data[:programming_language_id].blank?
  55 + language_name = ProgrammingLanguage.find(
57 56 language_data[:programming_language_id],
58 57 :select=>"name"
59 58 ).name
... ...