Commit c489251bf4383c07e9e2f8db313108406435048c
Committed by
Thiago Ribeiro
1 parent
5ffa5a41
Exists in
master
and in
3 other branches
Search software_infos find only softwares with visible community
Showing
2 changed files
with
20 additions
and
0 deletions
Show diff stats
lib/ext/search_controller.rb
... | ... | @@ -61,6 +61,7 @@ class SearchController |
61 | 61 | |
62 | 62 | def get_filtered_software_list |
63 | 63 | params[:query] ||= "" |
64 | + visible_communities = visible_profiles(Community) | |
64 | 65 | |
65 | 66 | filtered_software_list = SoftwareInfo.search_by_query(params[:query]) |
66 | 67 | |
... | ... | @@ -70,6 +71,7 @@ class SearchController |
70 | 71 | @public_software_selected = false |
71 | 72 | end |
72 | 73 | |
74 | + filtered_software_list.select!{ |software| visible_communities.include?(software.community) } | |
73 | 75 | category_ids = get_filter_category_ids |
74 | 76 | |
75 | 77 | unless category_ids.empty? | ... | ... |
test/functional/search_controller_test.rb
... | ... | @@ -214,6 +214,7 @@ class SearchControllerTest < ActionController::TestCase |
214 | 214 | assert_not_includes assigns(:searches)[:software_infos][:results], software_one.community |
215 | 215 | end |
216 | 216 | |
217 | +<<<<<<< 5ffa5a412be43c8ca9d1a07ed84a55503bb1a3fd | |
217 | 218 | should "software_infos search return only enabled softwares" do |
218 | 219 | s1 = SoftwareInfo.first |
219 | 220 | s2 = SoftwareInfo.last |
... | ... | @@ -239,6 +240,23 @@ class SearchControllerTest < ActionController::TestCase |
239 | 240 | assert_not_includes assigns(:searches)[:software_infos][:results], s2.community |
240 | 241 | end |
241 | 242 | |
243 | + should "software_infos search not return software with secret community" do | |
244 | + software_one = create_software_info("Software ABC", :acronym => "SFO", :finality => "Help") | |
245 | + software_two = create_software_info("Python", :acronym => "SFT", :finality => "Task") | |
246 | + software_three = create_software_info("Software DEF", :acronym => "SFW", :finality => "Java") | |
247 | + | |
248 | + software_one.community.secret = true | |
249 | + software_one.community.save! | |
250 | + | |
251 | + get( | |
252 | + :software_infos, | |
253 | + ) | |
254 | + | |
255 | + assert_includes assigns(:searches)[:software_infos][:results], software_two.community | |
256 | + assert_includes assigns(:searches)[:software_infos][:results], software_three.community | |
257 | + assert_not_includes assigns(:searches)[:software_infos][:results], software_one.community | |
258 | + end | |
259 | + | |
242 | 260 | private |
243 | 261 | |
244 | 262 | def create_software_categories | ... | ... |