Refactory to new feature that show a specific message when a user inactive try login

Michel Felipe
1 parent 23a10a5f
Showing 3 changed files with 54 additions and 7 deletions Show diff stats
app/controllers/public/account_controller.rb
app/models/user.rb
test/functional/account_controller_test.rb
@@ -46,8 +46,12 @@ class AccountController &lt; ApplicationController
     self.current_user = plugins_alternative_authentication
-    self.current_user ||= User.authenticate(params[:user][:login], params[:user][:password], environment) if params[:user]
-
+    begin
+      self.current_user ||= User.authenticate(params[:user][:login], params[:user][:password], environment) if params[:user]
+    rescue NoosferoExceptions::UserInactive => e
+      session[:notice] = e.message
+      return
+    end
     if logged_in?
       check_join_in_community(self.current_user)
@@ -120,11 +120,17 @@ class User &lt; ActiveRecord::Base
   validates_inclusion_of :terms_accepted, :in => [ '1' ], :if => lambda { |u| ! u.terms_of_use.blank? }, :message => N_('{fn} must be checked in order to signup.').fix_i18n
+  scope :has_login?, lambda { |login,email,environment_id|
+    where('login = ? OR email = ?', login, email).
+    where(environment_id: environment_id)
+  }
+
   # Authenticates a user by their login name or email and unencrypted password.  Returns the user or nil.
   def self.authenticate(login, password, environment = nil)
     environment ||= Environment.default
-    u = self.first :conditions => ['(login = ? OR email = ?) AND environment_id = ? AND activated_at IS NOT NULL',
-                                   login, login, environment.id] # need to get the salt
+
+    u = self.has_login?(login, login, environment.id)
+    u = u.first if u.is_a?(ActiveRecord::Relation)
     u && u.authenticated?(password) ? u : nil
   end
@@ -237,6 +243,12 @@ class User &lt; ActiveRecord::Base
   end
   def authenticated?(password)
+
+    unless self.activated?
+      message = _('The user "%{login}" is not active!') % {login: self.login}
+      raise NoosferoExceptions::UserInactive.new(message, self)
+    end
+
     result = (crypted_password == encrypt(password))
     if (encryption_method != User.system_encryption_method) && result
       self.password_type = User.system_encryption_method.to_s
@@ -275,8 +287,14 @@ class User &lt; ActiveRecord::Base
   #   current password.
   # * Saves the record unless it is a new one.
   def change_password!(current, new, confirmation)
-    unless self.authenticated?(current)
-      self.errors.add(:current_password, _('does not match.'))
+
+    begin
+      unless self.authenticated?(current)
+        self.errors.add(:current_password, _('does not match.'))
+        raise IncorrectPassword
+      end
+    rescue NoosferoExceptions::UserInactive => e
+      self.errors.add(:current_password, e.message)
       raise IncorrectPassword
     end
     self.force_change_password!(new, confirmation)
@@ -393,3 +411,15 @@ class User &lt; ActiveRecord::Base
       Delayed::Job.enqueue(UserActivationJob.new(self.id), {:priority => 0, :run_at => (NOOSFERO_CONF['hours_until_user_activation_check'] || 72).hours.from_now})
     end
 end
+
+module NoosferoExceptions
+  class UserInactive < ActiveRecord::ActiveRecordError
+    attr_reader :user
+
+    def initialize(message, user = nil)
+      @user = user
+
+      super(message)
+    end
+  end
+end
@@ -40,6 +40,14 @@ class AccountControllerTest &lt; ActionController::TestCase
     post :login, :user => { :login => 'fake', :password => 'fake' }
   end
+  should 'fail login if a user is inactive and show a warning message' do
+    user = User.create!(login: 'testuser', email: 'test@email.com', password:'test', password_confirmation:'test', activation_code: nil)
+    post :login, :user => { :login => 'testuser', :password => 'test' }
+
+    assert_match 'not active', session[:notice]
+    assert_nil session[:user]
+  end
+
   def test_should_fail_login_and_not_redirect
     @request.env["HTTP_REFERER"] = 'bli'
     post :login, :user => {:login => 'johndoe', :password => 'bad password'}
@@ -273,8 +281,9 @@ class AccountControllerTest &lt; ActionController::TestCase
     assert_template 'invalid_change_password_code'
   end
-  should 'require password confirmation correctly to enter new pasword' do
+  should 'require password confirmation correctly to enter new password' do
     user = create_user('testuser', :email => 'testuser@example.com', :password => 'test', :password_confirmation => 'test')
+    user.activate
     change = ChangePassword.create!(:requestor => user.person)
     post :new_password, :code => change.code, :change_password => { :password => 'onepass', :password_confirmation => 'another_pass' }
@@ -749,6 +758,8 @@ class AccountControllerTest &lt; ActionController::TestCase
     get :activate
     assert_nil assigns(:message)
     post :login, :user => {:login => 'testuser', :password => 'test123'}
+
+    assert_match 'not active', session[:notice]
     assert_nil session[:user]
   end
@@ -758,6 +769,8 @@ class AccountControllerTest &lt; ActionController::TestCase
     get :activate, :activation_code => 'wrongcode'
     assert_nil assigns(:message)
     post :login, :user => {:login => 'testuser', :password => 'test123'}
+
+    assert_match 'not active', session[:notice]
     assert_nil session[:user]
   end
	@@ -120,11 +120,17 @@ class User < ActiveRecord::Base		@@ -120,11 +120,17 @@ class User < ActiveRecord::Base
120		120
121	validates_inclusion_of :terms_accepted, :in => [ '1' ], :if => lambda { \|u\| ! u.terms_of_use.blank? }, :message => N_('{fn} must be checked in order to signup.').fix_i18n	121	validates_inclusion_of :terms_accepted, :in => [ '1' ], :if => lambda { \|u\| ! u.terms_of_use.blank? }, :message => N_('{fn} must be checked in order to signup.').fix_i18n
122		122
		123	+ scope :has_login?, lambda { \|login,email,environment_id\|
		124	+ where('login = ? OR email = ?', login, email).
		125	+ where(environment_id: environment_id)
		126	+ }
		127	+
123	# Authenticates a user by their login name or email and unencrypted password. Returns the user or nil.	128	# Authenticates a user by their login name or email and unencrypted password. Returns the user or nil.
124	def self.authenticate(login, password, environment = nil)	129	def self.authenticate(login, password, environment = nil)
125	environment \|\|= Environment.default	130	environment \|\|= Environment.default
126	- u = self.first :conditions => ['(login = ? OR email = ?) AND environment_id = ? AND activated_at IS NOT NULL',
127	- login, login, environment.id] # need to get the salt	131	+
		132	+ u = self.has_login?(login, login, environment.id)
		133	+ u = u.first if u.is_a?(ActiveRecord::Relation)
128	u && u.authenticated?(password) ? u : nil	134	u && u.authenticated?(password) ? u : nil
129	end	135	end
130		136
	@@ -237,6 +243,12 @@ class User < ActiveRecord::Base		@@ -237,6 +243,12 @@ class User < ActiveRecord::Base
237	end	243	end
238		244
239	def authenticated?(password)	245	def authenticated?(password)
		246	+
		247	+ unless self.activated?
		248	+ message = _('The user "%{login}" is not active!') % {login: self.login}
		249	+ raise NoosferoExceptions::UserInactive.new(message, self)
		250	+ end
		251	+
240	result = (crypted_password == encrypt(password))	252	result = (crypted_password == encrypt(password))
241	if (encryption_method != User.system_encryption_method) && result	253	if (encryption_method != User.system_encryption_method) && result
242	self.password_type = User.system_encryption_method.to_s	254	self.password_type = User.system_encryption_method.to_s
	@@ -275,8 +287,14 @@ class User < ActiveRecord::Base		@@ -275,8 +287,14 @@ class User < ActiveRecord::Base
275	# current password.	287	# current password.
276	# * Saves the record unless it is a new one.	288	# * Saves the record unless it is a new one.
277	def change_password!(current, new, confirmation)	289	def change_password!(current, new, confirmation)
278	- unless self.authenticated?(current)
279	- self.errors.add(:current_password, _('does not match.'))	290	+
		291	+ begin
		292	+ unless self.authenticated?(current)
		293	+ self.errors.add(:current_password, _('does not match.'))
		294	+ raise IncorrectPassword
		295	+ end
		296	+ rescue NoosferoExceptions::UserInactive => e
		297	+ self.errors.add(:current_password, e.message)
280	raise IncorrectPassword	298	raise IncorrectPassword
281	end	299	end
282	self.force_change_password!(new, confirmation)	300	self.force_change_password!(new, confirmation)
	@@ -393,3 +411,15 @@ class User < ActiveRecord::Base		@@ -393,3 +411,15 @@ class User < ActiveRecord::Base
393	Delayed::Job.enqueue(UserActivationJob.new(self.id), {:priority => 0, :run_at => (NOOSFERO_CONF['hours_until_user_activation_check'] \|\| 72).hours.from_now})	411	Delayed::Job.enqueue(UserActivationJob.new(self.id), {:priority => 0, :run_at => (NOOSFERO_CONF['hours_until_user_activation_check'] \|\| 72).hours.from_now})
394	end	412	end
395	end	413	end
		414	+
		415	+module NoosferoExceptions
		416	+ class UserInactive < ActiveRecord::ActiveRecordError
		417	+ attr_reader :user
		418	+
		419	+ def initialize(message, user = nil)
		420	+ @user = user
		421	+
		422	+ super(message)
		423	+ end
		424	+ end
		425	+end