[Mezuro] Fixed 'get module result' tests

Alessandro Palmeira + Caio Salgado · Rafael Manzo
1 parent 4107a13b
Showing 2 changed files with 25 additions and 15 deletions Show diff stats
plugins/mezuro/test/functional/echo_port_test.rb
plugins/mezuro/test/functional/mezuro_plugin_profile_controller_test.rb
@@ -85,4 +85,4 @@ class EchoPortTest &lt; ActiveSupport::TestCase
     assert_equal parent, @port.request(:infer_parent_granularity, body)[:parent_granularity]
   end
-end
 \ No newline at end of file
+end
@@ -72,28 +72,25 @@ class MezuroPluginProfileControllerTest &lt; ActionController::TestCase
     assert_response 200
   end
-  should 'get module result' do
+  should 'get module result without date' do
     create_project_content
-    module_result_client = mock
+    mock_module_result
     Kalibro::Client::ProjectResultClient.expects(:last_result).with(@name).returns(@project_result)
-    Kalibro::Client::ModuleResultClient.expects(:new).returns(module_result_client)
-    module_result_client.expects(:module_result).with(@name, @name, @project_result.date).returns(@module_result)
+    Kalibro::Client::ProjectClient.expects(:project).with(@name).returns(@project)
+
     get :module_result, :profile => @profile.identifier, :id => @content.id, :module_name => @name
     assert_response 200
     assert_select('h5', 'Metric results for: Qt-Calculator (APPLICATION)')
   end
   should 'get module result from a specific date' do
-	create_project_content
-	client = mock
-    module_result_client = mock
-    Kalibro::Client::ModuleResultClient.expects(:new).returns(module_result_client)
-    module_result_client.expects(:module_result).with(@name, @name, @project_result.date).returns(@module_result)
-	Kalibro::Client::ProjectResultClient.expects(:new).returns(client)
-	client.expects(:has_results_before).returns(true)
-	client.expects(:last_result_before).returns(@project_result)
-	get :module_result, :profile => @profile.identifier, :id => @content.id, :date => "2012-04-13T20:39:41+04:00", :module_name => @name
-	assert_response 200
+	  create_project_content
+    Kalibro::Client::ProjectClient.expects(:project).with(@name).returns(@project)
+    mock_module_result
+	  mock_project_result
+
+	  get :module_result, :profile => @profile.identifier, :id => @content.id, :date => @project_result.date, :module_name => @name
+	  assert_response 200
   end
   should 'get project tree' do
@@ -121,5 +118,18 @@ class MezuroPluginProfileControllerTest &lt; ActionController::TestCase
     @content.expects(:send_project_to_service).returns(nil)
     @content.save
   end
+  
+  def mock_project_result
+    project_result_client = mock
+	  Kalibro::Client::ProjectResultClient.expects(:new).returns(project_result_client)
+	  project_result_client.expects(:has_results_before).returns(true)
+	  project_result_client.expects(:last_result_before).returns(@project_result)
+  end
+  
+  def mock_module_result
+    module_result_client = mock
+    Kalibro::Client::ModuleResultClient.expects(:new).returns(module_result_client)
+    module_result_client.expects(:module_result).with(@name, @name, @project_result.date).returns(@module_result)
+  end
 end
	@@ -85,4 +85,4 @@ class EchoPortTest < ActiveSupport::TestCase		@@ -85,4 +85,4 @@ class EchoPortTest < ActiveSupport::TestCase
85	assert_equal parent, @port.request(:infer_parent_granularity, body)[:parent_granularity]	85	assert_equal parent, @port.request(:infer_parent_granularity, body)[:parent_granularity]
86	end	86	end
87		87
88	-end
89	\ No newline at end of file	88	\ No newline at end of file
		89	+end