rails3: fix community_track plugin

Victor Costa
1 parent f1963acc
Showing 35 changed files with 311 additions and 307 deletions Show diff stats
plugins/community_track/lib/community_track_plugin/activation_job.rb
plugins/community_track/lib/community_track_plugin/step.rb
plugins/community_track/lib/community_track_plugin/track.rb
plugins/community_track/lib/community_track_plugin/track_list_block.rb
plugins/community_track/test/functional/community_track_plugin_content_viewer_controller_test.rb
plugins/community_track/test/functional/community_track_plugin_environment_design_controller_test.rb
plugins/community_track/test/functional/community_track_plugin_public_controller_test.rb
plugins/community_track/test/unit/community_track_plugin/step_test.rb
plugins/community_track/test/unit/community_track_plugin/track_card_list_block_test.rb
plugins/community_track/test/unit/community_track_plugin/track_list_block_test.rb
plugins/community_track/test/unit/community_track_plugin/track_test.rb
plugins/community_track/views/blocks/_track.html.erb
plugins/community_track/views/blocks/_track.rhtml
plugins/community_track/views/blocks/_track_card.html.erb
plugins/community_track/views/blocks/_track_card.rhtml
plugins/community_track/views/blocks/_track_list_more.html.erb
plugins/community_track/views/blocks/_track_list_more.rhtml
plugins/community_track/views/blocks/track_list.html.erb
plugins/community_track/views/blocks/track_list.rhtml
plugins/community_track/views/box_organizer/community_track_plugin/_track_list_block.html.erb
 class CommunityTrackPlugin::ActivationJob < Struct.new(:step_id)
  
   def self.find(step_id)
-    Delayed::Job.where(:handler => "--- !ruby/struct:CommunityTrackPlugin::ActivationJob \nstep_id: #{step_id}\n")
+    Delayed::Job.where(:handler => "--- !ruby/struct:CommunityTrackPlugin::ActivationJob\nstep_id: #{step_id}\n")
   end
  
   def perform
@@ -3,6 +3,8 @@ class CommunityTrackPlugin::Step &lt; Folder
   settings_items :hidden, :type => :boolean, :default => false
   settings_items :tool_type, :type => String
  
+  attr_accessible :start_date, :end_date, :tool_type, :hidden
+
   alias :tools :children
  
   acts_as_list  :scope => :parent
@@ -64,8 +66,8 @@ class CommunityTrackPlugin::Step &lt; Folder
  
   def to_html(options = {})
     step = self
-    lambda do
-      render :file => 'content_viewer/step.rhtml', :locals => {:step => step}
+    proc do
+      render :file => 'content_viewer/step', :locals => {:step => step}
     end
   end
  
@@ -86,7 +88,7 @@ class CommunityTrackPlugin::Step &lt; Folder
     if Date.today <= end_date || accept_comments
       schedule_date = !accept_comments ? start_date : end_date + 1.day
       CommunityTrackPlugin::ActivationJob.find(id).destroy_all
-      Delayed::Job.enqueue(CommunityTrackPlugin::ActivationJob.new(self.id), 0, schedule_date)
+      Delayed::Job.enqueue(CommunityTrackPlugin::ActivationJob.new(self.id), :run_at => schedule_date)
     end
   end
  
@@ -5,6 +5,8 @@ class CommunityTrackPlugin::Track &lt; Folder
  
   validate :validate_categories
  
+  attr_accessible :goals, :expected_results
+
   def validate_categories
     errors.add(:categories, _('should not be blank.')) if categories.empty? && pending_categorizations.blank?
   end
@@ -48,7 +50,7 @@ class CommunityTrackPlugin::Track &lt; Folder
   end
  
   def comments_count
-    steps_unsorted.joins(:children).sum('childrens_articles.comments_count')
+    steps_unsorted.joins(:children).sum('children_articles.comments_count')
   end
  
   def css_class_name
@@ -68,8 +70,8 @@ class CommunityTrackPlugin::Track &lt; Folder
  
   def to_html(options = {})
     track = self
-    lambda do
-      render :file => 'content_viewer/track.rhtml', :locals => {:track => track}
+    proc do
+      render :file => 'content_viewer/track', :locals => {:track => track}
     end
   end
  
@@ -48,8 +48,8 @@ class CommunityTrackPlugin::TrackListBlock &lt; Block
  
   def content(args={})
     block = self
-    lambda do
-      render :file => 'blocks/track_list.rhtml', :locals => {:block => block}
+    proc do
+      render :file => 'blocks/track_list', :locals => {:block => block}
     end
   end
  
@@ -60,7 +60,7 @@ class CommunityTrackPlugin::TrackListBlock &lt; Block
   def footer
     block = self
     return nil if !has_page?(2)
-    lambda do
+    proc do
       render :partial => 'blocks/track_list_more', :locals => {:block => block, :page => 2, :per_page => block.limit}
     end
   end
@@ -88,7 +88,7 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
  
   should 'render a div with block id for track list block' do
     box = fast_create(Box, :owner_id => @profile.id, :owner_type => @profile.class.name)
-    @block = CommunityTrackPlugin::TrackListBlock.create!(:box => box)
+    @block = create(CommunityTrackPlugin::TrackListBlock, :box => box)
     @profile.boxes << box
     get :view_page, @step.url
     assert_tag :tag => 'div', :attributes => { :class => 'track_list', :id => "track_list_#{@block.id}" }
@@ -96,7 +96,7 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
  
   should 'render a div with block id for track card list block' do
     box = fast_create(Box, :owner_id => @profile.id, :owner_type => @profile.class.name)
-    @block = CommunityTrackPlugin::TrackCardListBlock.create!(:box => box)
+    @block = create(CommunityTrackPlugin::TrackCardListBlock, :box => box)
     @profile.boxes << box
     get :view_page, @step.url
     assert_tag :tag => 'div', :attributes => { :class => 'track_list', :id => "track_list_#{@block.id}" }
@@ -104,7 +104,7 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
  
   should 'render tracks in track list block' do
     box = fast_create(Box, :owner_id => @profile.id, :owner_type => @profile.class.name)
-    @block = CommunityTrackPlugin::TrackListBlock.create!(:box => box)
+    @block = create(CommunityTrackPlugin::TrackListBlock, :box => box)
     @profile.boxes << box
     get :view_page, @step.url
     assert_tag :tag => 'div', :attributes => { :class => "item category_#{@track.category_name}" }, :descendant => { :tag => 'div', :attributes => { :class => 'steps' }, :descendant => { :tag => 'span', :attributes => { :class => "step #{@block.status_class(@step)}" } } }
@@ -112,7 +112,7 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
  
   should 'render tracks in track card list block' do
     box = fast_create(Box, :owner_id => @profile.id, :owner_type => @profile.class.name)
-    @block = CommunityTrackPlugin::TrackCardListBlock.create!(:box => box)
+    @block = create(CommunityTrackPlugin::TrackCardListBlock, :box => box)
     @profile.boxes << box
     get :view_page, @step.url
     assert_tag :tag => 'div', :attributes => { :class => "item_card category_#{@track.category_name}" }, :descendant => { :tag => 'div', :attributes => { :class => 'track_content' } }
@@ -121,7 +121,7 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
  
   should 'render link to display more tracks in track list block' do
     box = fast_create(Box, :owner_id => @profile.id, :owner_type => @profile.class.name)
-    @block = CommunityTrackPlugin::TrackCardListBlock.create!(:box => box)
+    @block = create(CommunityTrackPlugin::TrackCardListBlock, :box => box)
     @profile.boxes << box
  
     (@block.limit+1).times { |i| create_track("track#{i}", @profile) }
@@ -132,7 +132,7 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
  
   should 'render link to show all tracks in track list block' do
     box = fast_create(Box, :owner_id => @profile.id, :owner_type => @profile.class.name)
-    @block = CommunityTrackPlugin::TrackCardListBlock.create!(:box => box)
+    @block = create(CommunityTrackPlugin::TrackCardListBlock, :box => box)
     @profile.boxes << box
     @block.more_another_page = true
     @block.save!
@@ -15,9 +15,9 @@ class EnvironmentDesignControllerTest &lt; ActionController::TestCase
     @environment.add_admin(user.person)
     login_as(user.login)
  
-    box = Box.create!(:owner => @environment)
-    @block = CommunityTrackPlugin::TrackListBlock.create!(:box => box)
-    @block_card = CommunityTrackPlugin::TrackCardListBlock.create!(:box => box)
+    box = create(Box, :owner => @environment)
+    @block = create(CommunityTrackPlugin::TrackListBlock, :box => box)
+    @block_card = create(CommunityTrackPlugin::TrackCardListBlock, :box => box)
   end
  
   should 'be able to edit TrackListBlock' do
@@ -11,8 +11,8 @@ class CommunityTrackPluginPublicControllerTest &lt; ActionController::TestCase
     @track = create_track('track', @community)
  
     box = fast_create(Box, :owner_id => @community.id, :owner_type => 'Community')
-    @card_block = CommunityTrackPlugin::TrackCardListBlock.create!(:box => box)
-    @block = CommunityTrackPlugin::TrackListBlock.create!(:box => box)
+    @card_block = create(CommunityTrackPlugin::TrackCardListBlock, :box => box)
+    @block = create(CommunityTrackPlugin::TrackListBlock, :box => box)
   end
  
   should 'display tracks for card block' do
@@ -4,7 +4,7 @@ class StepTest &lt; ActiveSupport::TestCase
  
   def setup
     @profile = fast_create(Community)
-    @track = CommunityTrackPlugin::Track.new(:profile_id => @profile.id, :name => 'track')
+    @track = CommunityTrackPlugin::Track.new(:profile => @profile, :name => 'track')
     @category = fast_create(Category)
     @track.add_category(@category)
     @track.save!
@@ -61,13 +61,13 @@ class StepTest &lt; ActiveSupport::TestCase
   should 'do not validate date period if start date is nil' do
     @step.start_date = nil
     @step.end_date_equal_or_after_start_date.inspect
-    assert [], @step.errors
+    assert @step.errors.empty?
   end
  
   should 'do not validate date period if end date is nil' do
     @step.end_date = nil
     @step.end_date_equal_or_after_start_date.inspect
-    assert [], @step.errors
+    assert @step.errors.empty?
   end
  
   should 'be active if today is between start and end dates' do
@@ -5,7 +5,7 @@ class TrackCardListBlockTest &lt; ActiveSupport::TestCase
   def setup
     @community = fast_create(Community)
     box = fast_create(Box, :owner_id => @community.id, :owner_type => @community.class.name)
-    @block = CommunityTrackPlugin::TrackCardListBlock.create!(:box => box)
+    @block = create(CommunityTrackPlugin::TrackCardListBlock, :box => box)
   end
  
   should 'describe yourself' do
@@ -6,7 +6,7 @@ class TrackListBlockTest &lt; ActiveSupport::TestCase
     @profile = fast_create(Community)
     @track = create_track('track', profile)
     box = fast_create(Box, :owner_id => @profile.id, :owner_type => @profile.class.name)
-    @block = CommunityTrackPlugin::TrackListBlock.create!(:box => box)
+    @block = create(CommunityTrackPlugin::TrackListBlock, :box => box)
   end
  
   attr_reader :profile
@@ -31,7 +31,7 @@ class TrackListBlockTest &lt; ActiveSupport::TestCase
  
   should 'list of articles be limited by block configuration' do
     (@block.limit + 1).times { |i| create_track("track#{i}", profile) }
-    assert_equal @block.limit, @block.tracks.count
+    assert_equal @block.limit, @block.tracks.size
   end
  
   should 'return more link if has more tracks to show' do
@@ -130,13 +130,13 @@ class TrackTest &lt; ActiveSupport::TestCase
  
   should 'not be able to create a track without category' do
     track = CommunityTrackPlugin::Track.create(:profile => @profile, :name => 'track')
-    assert track.errors.invalid?(:categories)
+    assert track.errors.include?(:categories)
   end
  
   should 'not be able to save a track without category' do
     @track.categories.delete_all
     @track.save
-    assert @track.errors.invalid?(:categories)
+    assert @track.errors.include?(:categories)
   end
  
 end
@@ -0,0 +1,26 @@
+<% extend CommunityTrackPlugin::TrackHelper %>
+<% extend CommunityTrackPlugin::StepHelper %>
+<div class="item <%= category_class(track) %>">
+  <div class="track_content">
+    <div class="lead">
+      <h3><%= link_to track.name, track.url %></h3>
+      <div class="content">
+        <%= track.lead %>
+      </div>
+    </div>
+    <div class="steps">
+      <h3><%= _("Steps") %></h3>
+      <% track.steps.each do |step| %>
+        <%= link_to_step(step) do %>
+          <span class="step <%= block.status_class(step) %>">
+            <span class="position"><%= step.position %></span>
+            <span class="legend"><%= status_description(step) %></span>
+            <span class="tool_icon button with-text icon-new icon-new<%= step.tool_class.icon_name if step.tool_class %>"></span>
+            <span class="name"><%= step.name %></span>
+          </span>
+        <% end %>
+      <% end %>
+    </div>
+  </div>
+</div>
+<br style="clear: both;"/>
@@ -1,26 +0,0 @@
-<% extend CommunityTrackPlugin::TrackHelper %>
-<% extend CommunityTrackPlugin::StepHelper %>
-<div class="item <%= category_class(track) %>">
-  <div class="track_content">
-    <div class="lead">
-      <h3><%= link_to track.name, track.url %></h3>
-      <div class="content">
-        <%= track.lead %>
-      </div>
-    </div>
-    <div class="steps">
-      <h3><%= _("Steps") %></h3>
-      <% track.steps.each do |step| %>
-        <% link_to_step(step) do %>
-          <span class="step <%= block.status_class(step) %>">
-            <span class="position"><%= step.position %></span>
-            <span class="legend"><%= status_description(step) %></span>
-            <span class="tool_icon button with-text icon-new icon-new<%= step.tool_class.icon_name if step.tool_class %>"></span>
-            <span class="name"><%= step.name %></span>
-          </span>
-        <% end %>
-      <% end %>
-    </div>
-  </div>
-</div>
-<br style="clear: both;"/>
@@ -0,0 +1,29 @@
+<% extend CommunityTrackPlugin::TrackHelper %>
+<div class="item_card <%= category_class(track_card) %>">
+  <a href="<%= url_for track_card.url %>">
+  <div class="track_content">
+    <div class="title">
+      <%= track_card.category_name %>
+    </div>
+    <div class="image">
+      <%= image_tag track_card.image.public_filename if track_card.image %>
+    </div>
+    <div class="name">
+      <%= track_card.name %>
+    </div>
+    <div class="lead">
+      <%= track_card_lead(track_card) %>
+    </div>
+  </div>
+  <div class="track_stats">
+    <div class="comments">
+      <span class="counter"><%= "#{track_card.comments_count}" %></span>
+      <span class="label"><%= _('comments') %></span>
+    </div>
+    <div class="hits">
+      <span class="counter"><%= "#{track_card.hits}" %></span>
+      <span class="label"><%= _('hits') %></span>
+    </div>
+  </div>
+  </a>
+</div>
@@ -1,29 +0,0 @@
-<% extend CommunityTrackPlugin::TrackHelper %>
-<div class="item_card <%= category_class(track_card) %>">
-  <a href="<%= url_for track_card.url %>">
-  <div class="track_content">
-    <div class="title">
-      <%= track_card.category_name %>
-    </div>
-    <div class="image">
-      <%= image_tag track_card.image.public_filename if track_card.image %>
-    </div>
-    <div class="name">
-      <%= track_card.name %>
-    </div>
-    <div class="lead">
-      <%= track_card_lead(track_card) %>
-    </div>
-  </div>
-  <div class="track_stats">
-    <div class="comments">
-      <span class="counter"><%= "#{track_card.comments_count}" %></span>
-      <span class="label"><%= _('comments') %></span>
-    </div>
-    <div class="hits">
-      <span class="counter"><%= "#{track_card.hits}" %></span>
-      <span class="label"><%= _('hits') %></span>
-    </div>
-  </div>
-  </a>
-</div>
@@ -0,0 +1,12 @@
+<% force_same_page ||= false %>
+<div id="track_list_more_<%= block.id %>" class="more_button">
+  <% if block.more_another_page && !force_same_page %>
+    <div class="view_all">
+      <%= link_to _('View All'), :id => block.id, :controller => 'community_track_plugin_public', :action => 'all_tracks' %>
+    </div>
+  <% else %>
+    <div class="more">
+      <%= link_to_remote(_('More'), :url => {:id => block.id, :controller => 'community_track_plugin_public', :action => 'view_tracks', :page => page, :per_page => per_page, :force_same_page => force_same_page}, :loaded => visual_effect(:highlight, "track_card_list_#{block.id}")) %>
+    </div>
+  <% end %>
+</div>
@@ -1,12 +0,0 @@
-<% force_same_page ||= false %>
-<div id="track_list_more_<%= block.id %>" class="more_button">
-  <% if block.more_another_page && !force_same_page %>
-    <div class="view_all">
-      <%= link_to _('View All'), :id => block.id, :controller => 'community_track_plugin_public', :action => 'all_tracks' %>
-    </div>
-  <% else %>
-    <div class="more">
-      <%= link_to_remote(_('More'), :url => {:id => block.id, :controller => 'community_track_plugin_public', :action => 'view_tracks', :page => page, :per_page => per_page, :force_same_page => force_same_page}, :loaded => visual_effect(:highlight, "track_card_list_#{block.id}")) %>
-    </div>
-  <% end %>
-</div>
@@ -0,0 +1,6 @@
+<%= block_title(block.title) %>
+
+<div class="track_list" id="track_list_<%= block.id %>">
+  <%= render :partial => "blocks/#{block.track_partial}", :collection => block.tracks, :locals => {:block => block} %>
+</div>
+<br style="clear: both;"/>
@@ -1,6 +0,0 @@
-<%= block_title(block.title) %>
-
-<div class="track_list" id="track_list_<%= block.id %>">
-  <%= render :partial => "blocks/#{block.track_partial}", :collection => block.tracks, :locals => {:block => block} %>
-</div>
-<br style="clear: both;"/>
@@ -0,0 +1,6 @@
+<div id='edit-track-list-block'>
+  <%= labelled_form_field _('Limit of items'), text_field(:block, :limit, :size => 3) %>
+  <%= labelled_form_field check_box(:block, :more_another_page) + _('Show more at another page'), '' %>
+  <%= select_categories(:block, _('Select Categories')) %>
+<br/>
+</div>
@@ -1,6 +0,0 @@
-<div id='edit-track-list-block'>
-  <%= labelled_form_field _('Limit of items'), text_field(:block, :limit, :size => 3) %>
-  <%= labelled_form_field check_box(:block, :more_another_page) + _('Show more at another page'), '' %>
-  <%= select_categories(:block, _('Select Categories')) %>
-<br/>
-</div>
@@ -0,0 +1,21 @@
+<%= required_fields_message %>
+
+<%= render :file => 'shared/tiny_mce' %>
+
+<div>
+  <%= required f.text_field('name', :size => '64', :maxlength => 150) %>
+  <%= labelled_form_field(_('Period'), (
+    date_range_field('article[start_date]', 'article[end_date]', @article.start_date, @article.end_date,
+                     '%Y-%m-%d',
+                     { :change_month => true, :change_year => true,
+                       :date_format => 'yy-mm-dd' },
+                     { :size => 14 })
+  )) %>
+
+  <%= labelled_form_field(_('Tool type'), select(:article, :tool_type, CommunityTrackPlugin::Step.enabled_tools.map {|t| [t.short_description, t.name]} )) %>
+  <%= hidden_field_tag('success_back_to', url_for(@article.parent.view_url)) %>
+</div>
+
+<%= labelled_form_field check_box(:article, :hidden) + _('Hidden Step'), '' %>
+
+<%= render :partial => 'shared/lead_and_body', :locals => {:tiny_mce => true, :body_label => 'Description:'} %>
@@ -1,21 +0,0 @@
-<%= required_fields_message %>
-
-<%= render :file => 'shared/tiny_mce' %>
-
-<div>
-  <%= required f.text_field('name', :size => '64', :maxlength => 150) %>
-  <%= labelled_form_field(_('Period'), (
-    date_range_field('article[start_date]', 'article[end_date]', @article.start_date, @article.end_date,
-                     '%Y-%m-%d',
-                     { :change_month => true, :change_year => true,
-                       :date_format => 'yy-mm-dd' },
-                     { :size => 14 })
-  )) %>
-
-  <%= labelled_form_field(_('Tool type'), select(:article, :tool_type, CommunityTrackPlugin::Step.enabled_tools.map {|t| [t.short_description, t.name]} )) %>
-  <%= hidden_field_tag('success_back_to', url_for(@article.parent.view_url)) %>
-</div>
-
-<%= labelled_form_field check_box(:article, :hidden) + _('Hidden Step'), '' %>
-
-<%= render :partial => 'shared/lead_and_body', :locals => {:tiny_mce => true, :body_label => 'Description:'} %>
@@ -0,0 +1,16 @@
+<div class='community-track'>
+  <%= required_fields_message %>
+
+  <%= render :file => 'shared/tiny_mce' %>
+
+  <div>
+    <%= required labelled_form_field(_('Title'), text_field(:article, 'name', :size => '64', :maxlength => 150)) %>
+  </div>
+
+  <%= render :partial => 'shared/lead_and_body', :locals => {:tiny_mce => true, :body_label => 'Description:'} %>
+
+  <div>
+    <%= labelled_form_field(_('Goals:'), text_area(:article, :goals, :rows => 3, :cols => 64)) %>
+    <%= labelled_form_field(_('Expected Results:'), text_area(:article, :expected_results, :rows => 3, :cols => 64)) %>
+  </div>
+</div>
@@ -1,16 +0,0 @@
-<div class='community-track'>
-  <%= required_fields_message %>
-
-  <%= render :file => 'shared/tiny_mce' %>
-
-  <div>
-    <%= required labelled_form_field(_('Title'), text_field(:article, 'name', :size => '64', :maxlength => 150)) %>
-  </div>
-
-  <%= render :partial => 'shared/lead_and_body', :locals => {:tiny_mce => true, :body_label => 'Description:'} %>
-
-  <div>
-    <%= labelled_form_field(_('Goals:'), text_area(:article, :goals, :rows => 3, :cols => 64)) %>
-    <%= labelled_form_field(_('Expected Results:'), text_area(:article, :expected_results, :rows => 3, :cols => 64)) %>
-  </div>
-</div>
@@ -0,0 +1,10 @@
+<h1><%= _('Tracks') %></h1>
+<div class="all_tracks">
+  <div class="track_list track_card_list" id="track_list_<%= @block.id %>">
+    <%= render :partial => "blocks/#{@block.track_partial}", :collection => @tracks, :locals => {:block => @block} %>
+  </div>
+  <br style="clear: both;"/>
+  <% if @show_more %>
+    <%= render :partial => "blocks/track_list_more", :locals => {:block => @block, :force_same_page => true, :page => 2, :per_page => @per_page} %>
+  <% end %>
+</div>
@@ -1,10 +0,0 @@
-<h1><%= _('Tracks') %></h1>
-<div class="all_tracks">
-  <div class="track_list track_card_list" id="track_list_<%= @block.id %>">
-    <%= render :partial => "blocks/#{@block.track_partial}", :collection => @tracks, :locals => {:block => @block} %>
-  </div>
-  <br style="clear: both;"/>
-  <% if @show_more %>
-    <%= render :partial => "blocks/track_list_more", :locals => {:block => @block, :force_same_page => true, :page => 2, :per_page => @per_page} %>
-  <% end %>
-</div>
@@ -0,0 +1,41 @@
+<div>
+
+<h1><%= _('Select Community') %></h1>
+
+<% if !@failed.blank? %>
+  <div class="errorExplanation" id="errorExplanation">
+    <div style="color: #c00;">
+    <% @failed.each do |error|%>
+      <strong> <%= error %></strong>
+    <% end %>
+    </div>
+  </div>
+<% end %>
+
+<% button_bar do %>
+  <%= button(:add, _('Create a new community'), :controller => 'memberships', :action => 'new_community', :profile => user.identifier, :back_to => @back_to) %>
+<% end %>
+
+<%= form_tag({:controller => 'community_track_plugin_public', :action => 'select_community', :profile => user.identifier}) do %>
+<div class="common-profile-list-block">
+  <ul>
+  <% @communities.each do |community| %>
+    <li class="search-profile-item">
+      <div class="common-profile-list-block">
+        <div class="vcard">
+          <a href="#" onclick="jQuery('<%= "#community_identifier_#{community.identifier}" %>').attr('checked', true);">
+            <span class="profile-image"><%= profile_image(community) %></span>
+            <span class="org"><%= community.name %></span>
+            <span class="select_community"><%= radio_button_tag(:community_identifier, community.identifier) %></span>
+          </a>
+        </div>
+      </div>
+    </li>
+  <% end %>
+  </ul>
+  </div>
+  <div class="clear"></div>
+  <br/>
+  <%= submit_button :save, _('New Track') %>
+<% end %>
+</div>
@@ -1,41 +0,0 @@
-<div>
-
-<h1><%= _('Select Community') %></h1>
-
-<% if !@failed.blank? %>
-  <div class="errorExplanation" id="errorExplanation">
-    <div style="color: #c00;">
-    <% @failed.each do |error|%>
-      <strong> <%= error %></strong>
-    <% end %>
-    </div>
-  </div>
-<% end %>
-
-<% button_bar do %>
-  <%= button(:add, __('Create a new community'), :controller => 'memberships', :action => 'new_community', :profile => user.identifier, :back_to => @back_to) %>
-<% end %>
-
-<% form_tag({:controller => 'community_track_plugin_public', :action => 'select_community', :profile => user.identifier}) do %>
-<div class="common-profile-list-block">
-  <ul>
-  <% @communities.each do |community| %>
-    <li class="search-profile-item">
-      <div class="common-profile-list-block">
-        <div class="vcard">
-          <a href="#" onclick="jQuery('<%= "#community_identifier_#{community.identifier}" %>').attr('checked', true);">
-            <span class="profile-image"><%= profile_image(community) %></span>
-            <span class="org"><%= community.name %></span>
-            <span class="select_community"><%= radio_button_tag(:community_identifier, community.identifier) %></span>
-          </a>
-        </div>
-      </div>
-    </li>
-  <% end %>
-  </ul>
-  </div>
-  <div class="clear"></div>
-  <br/>
-  <%= submit_button :save, _('New Track') %>
-<% end %>
-</div>
@@ -0,0 +1,41 @@
+<li class="step <%= status_class(step_item) %>">
+  <%= hidden_field_tag "step_ids[]", step_item.id %>
+  <div class="tool_link" onclick="l=jQuery('#step_link_<%= step_item.id%>'); if(l.length) window.location = l.first().attr('href');">
+    <div class="position"><%= step_item.hidden ? '' : step_item.position %></div>
+    <div class="content">
+      <div class="date">
+        <%= show_period(step_item.start_date, step_item.end_date) %>
+      </div>
+      <div class="legend">
+        <%= status_description(step_item) %>
+      </div>
+      <div class="name"><span class="tool_icon button with-text icon-new icon-new<%= step_item.tool_class.icon_name if step_item.tool_class %>"></span>  <%= step_item.name %></div>
+      <div class="lead"><%= step_item.body %></div>
+      <div class="tools">
+        <% if step_item.tool %>
+          <%= _('Tool: ') %>
+
+          <%= link_to_step(step_item, {:id => "step_link_#{step_item.id}"}) do %>
+            <%= step_item.tool.name %>
+          <% end %>
+
+        <% elsif step_item.allow_create?(user) && step_item.tool_class %>
+          <a id="step_link_<%= step_item.id %>" href="<%= url_for({:controller => 'cms', :action => 'new', :type => step_item.tool_class, :parent_id => step_item, :success_back_to => url_for(step_item.parent.view_url)}) %>" class="button icon-new with-text icon-new<%= step_item.tool_class.icon_name %>"><%= _('Create %s' % step_item.tool_class.short_description) %></a>
+        <% else %>
+          <%= link_to_step(step_item, {:id => "step_link_#{step_item.id}"}, '') %>
+        <% end %>
+      </div>
+    </div>
+  </div>
+  <div class="step_actions">
+    <% if step_item.allow_edit?(user) && !remove_content_button(:edit) %>
+      <%= button('eyes', _('View'), step_item.url) %>
+      <% content = content_tag('span', label_for_edit_article(step_item)) %>
+      <% url = profile.admin_url.merge({ :controller => 'cms', :action => 'edit', :id => step_item.id, :success_back_to => url_for(step_item.parent.view_url) }) %>
+      <%= expirable_button step_item, :edit, content, url %>
+    <% end %>
+    <% if step_item.accept_uploads? && step_item.allow_create?(user) %>
+      <%= button('upload-file', _('Upload files'), profile.admin_url.merge(:controller => 'cms', :action => 'upload_files', :parent_id => step_item)) unless remove_content_button(:upload)%>
+    <% end %>
+  </div>
+</li>
@@ -1,41 +0,0 @@
-<li class="step <%= status_class(step_item) %>">
-  <%= hidden_field_tag "step_ids[]", step_item.id %>
-  <div class="tool_link" onclick="l=jQuery('#step_link_<%= step_item.id%>'); if(l.length) window.location = l.first().attr('href');">
-    <div class="position"><%= step_item.hidden ? '' : step_item.position %></div>
-    <div class="content">
-      <div class="date">
-        <%= show_period(step_item.start_date, step_item.end_date) %>
-      </div>
-      <div class="legend">
-        <%= status_description(step_item) %>
-      </div>
-      <div class="name"><span class="tool_icon button with-text icon-new icon-new<%= step_item.tool_class.icon_name if step_item.tool_class %>"></span>  <%= step_item.name %></div>
-      <div class="lead"><%= step_item.body %></div>
-      <div class="tools">
-        <% if step_item.tool %>
-          <%= _('Tool: ') %>
-
-          <% link_to_step(step_item, {:id => "step_link_#{step_item.id}"}) do %>
-            <%= step_item.tool.name %>
-          <% end %>
-
-        <% elsif step_item.allow_create?(user) && step_item.tool_class %>
-          <a id="step_link_<%= step_item.id %>" href="<%= url_for({:controller => 'cms', :action => 'new', :type => step_item.tool_class, :parent_id => step_item, :success_back_to => url_for(step_item.parent.view_url)}) %>" class="button icon-new with-text icon-new<%= step_item.tool_class.icon_name %>"><%= _('Create %s' % step_item.tool_class.short_description) %></a>
-        <% else %>
-          <% link_to_step(step_item, {:id => "step_link_#{step_item.id}"}, '') %>
-        <% end %>
-      </div>
-    </div>
-  </div>
-  <div class="step_actions">
-    <% if step_item.allow_edit?(user) && !remove_content_button(:edit) %>
-      <%= button('eyes', _('View'), step_item.url) %>
-      <% content = content_tag('span', label_for_edit_article(step_item)) %>
-      <% url = profile.admin_url.merge({ :controller => 'cms', :action => 'edit', :id => step_item.id, :success_back_to => url_for(step_item.parent.view_url) }) %>
-      <%= expirable_button step_item, :edit, content, url %>
-    <% end %>
-    <% if step_item.accept_uploads? && step_item.allow_create?(user) %>
-      <%= button('upload-file', _('Upload files'), profile.admin_url.merge(:controller => 'cms', :action => 'upload_files', :parent_id => step_item)) unless remove_content_button(:upload)%>
-    <% end %>
-  </div>
-</li>
@@ -0,0 +1,28 @@
+<div id="step">
+  <div class="event-info">
+    <ul class="event-data">
+      <li class="event-dates">
+        <span><%= _('When:') %></span><%= show_period(step.start_date, step.end_date) %>
+      </li>
+    </ul>
+  </div>
+  <div>
+    <%= step.body %>
+  </div>
+  <% if step.allow_create?(user) && !step.tool && step.tool_class %>
+    <h3><%= _("Tool") %></h3>
+    <div class="actions">
+      <a href="<%= url_for({:controller => 'cms', :action => 'new', :type => step.tool_type.constantize, :parent_id => @page}) %>" class="button with-text icon-new icon-new<%= step.tool_class.icon_name %>"><%= _('Create %s' % step.tool_class.short_description) %></a>
+    </div>
+  <% end %>
+  <% if step.tool %>
+    <h3><%= _("Tool") %></h3>
+    <div class="tools">
+      <div class="item">
+        <div class="name">
+          <%= link_to(step.tool.name, step.tool.view_url, :class=>"button with-text icon-new icon-new#{step.tool.class.icon_name}") %>
+          </div>
+        </div>
+    </div>
+  <% end %>
+</div>
@@ -1,28 +0,0 @@
-<div id="step">
-  <div class="event-info">
-    <ul class="event-data">
-      <li class="event-dates">
-        <span><%= _('When:') %></span><%= show_period(step.start_date, step.end_date) %>
-      </li>
-    </ul>
-  </div>
-  <div>
-    <%= step.body %>
-  </div>
-  <% if step.allow_create?(user) && !step.tool && step.tool_class %>
-    <h3><%= _("Tool") %></h3>
-    <div class="actions">
-      <a href="<%= url_for({:controller => 'cms', :action => 'new', :type => step.tool_type.constantize, :parent_id => @page}) %>" class="button with-text icon-new icon-new<%= step.tool_class.icon_name %>"><%= _('Create %s' % step.tool_class.short_description) %></a>
-    </div>
-  <% end %>
-  <% if step.tool %>
-    <h3><%= _("Tool") %></h3>
-    <div class="tools">
-      <div class="item">
-        <div class="name">
-          <%= link_to(step.tool.name, step.tool.view_url, :class=>"button with-text icon-new icon-new#{step.tool.class.icon_name}") %>
-          </div>
-        </div>
-    </div>
-  <% end %>
-</div>
@@ -0,0 +1,42 @@
+<% extend CommunityTrackPlugin::StepHelper %>
+
+<%= form_tag({:controller => 'community_track_plugin_myprofile', :action => 'save_order', :track => track}) do %>
+<div id="track">
+  <div>
+    <%= track.body %>
+  </div>
+
+  <h3><%= _("Steps") %></h3>
+
+  <% if track.allow_create?(user) %>
+    <div class="track actions">
+        <%= content_tag('a', :href => url_for({:controller => 'cms', :action => 'new', :type => "CommunityTrackPlugin::Step", :parent_id => track.id}), :class => 'button with-text icon-add') do %>
+          <strong><%= _("New %s") % CommunityTrackPlugin::Step.short_description %></strong>
+        <% end %>
+        <a href="#" class="reorder_button button with-text icon-up" onclick="enableReorder();"><%= _('Reorder Steps') %></a>
+        <%= submit_button :save, _('Save Order'), :class => "save_button" %>
+    </div>
+    <script>
+      function enableReorder() {
+        jQuery(".reorder_button").hide();
+        jQuery(".save_button").show();
+        jQuery("#sortable li").addClass("ui-state-default");
+        jQuery("#sortable").sortable();
+        jQuery("#sortable").disableSelection();
+      }
+    </script>
+    <% end %>
+
+    <ul id="sortable" class="step_list">
+      <%= render :partial => 'step_item', :collection => track.steps %>
+    </ul>
+    <% if track.allow_create?(user) && !track.hidden_steps.empty? %>
+      <div id="hidden_steps">
+        <h3><%= _('Hidden Steps') %></h3>
+        <ul class="step_list">
+          <%= render :partial => 'step_item', :collection => track.hidden_steps %>
+        </ul>
+      </div>
+    <% end %>
+</div>
+<% end %>
@@ -1,42 +0,0 @@
-<% extend CommunityTrackPlugin::StepHelper %>
-
-<% form_tag({:controller => 'community_track_plugin_myprofile', :action => 'save_order', :track => track}) do %>
-<div id="track">
-  <div>
-    <%= track.body %>
-  </div>
-
-  <h3><%= _("Steps") %></h3>
-
-  <% if track.allow_create?(user) %>
-    <div class="track actions">
-        <% content_tag('a', :href => url_for({:controller => 'cms', :action => 'new', :type => "CommunityTrackPlugin::Step", :parent_id => track.id}), :class => 'button with-text icon-add') do %>
-          <strong><%= _("New %s") % CommunityTrackPlugin::Step.short_description %></strong>
-        <% end %>
-        <a href="#" class="reorder_button button with-text icon-up" onclick="enableReorder();"><%= _('Reorder Steps') %></a>
-        <%= submit_button :save, _('Save Order'), :class => "save_button" %>
-    </div>
-    <script>
-      function enableReorder() {
-        jQuery(".reorder_button").hide();
-        jQuery(".save_button").show();
-        jQuery("#sortable li").addClass("ui-state-default");
-        jQuery("#sortable").sortable();
-        jQuery("#sortable").disableSelection();
-      }
-    </script>
-    <% end %>
-
-    <ul id="sortable" class="step_list">
-      <%= render :partial => 'step_item', :collection => track.steps %>
-    </ul>
-    <% if track.allow_create?(user) && !track.hidden_steps.empty? %>
-      <div id="hidden_steps">
-        <h3><%= _('Hidden Steps') %></h3>
-        <ul class="step_list">
-          <%= render :partial => 'step_item', :collection => track.hidden_steps %>
-        </ul>
-      </div>
-    <% end %>
-</div>
-<% end %>
1	1	class CommunityTrackPlugin::ActivationJob < Struct.new(:step_id)
2	2
3	3	def self.find(step_id)
4		- Delayed::Job.where(:handler => "--- !ruby/struct:CommunityTrackPlugin::ActivationJob \nstep_id: #{step_id}\n")
	4	+ Delayed::Job.where(:handler => "--- !ruby/struct:CommunityTrackPlugin::ActivationJob\nstep_id: #{step_id}\n")
5	5	end
6	6
7	7	def perform
...	...
...	...	@@ -3,6 +3,8 @@ class CommunityTrackPlugin::Step < Folder
3	3	settings_items :hidden, :type => :boolean, :default => false
4	4	settings_items :tool_type, :type => String
5	5
	6	+ attr_accessible :start_date, :end_date, :tool_type, :hidden
	7	+
6	8	alias :tools :children
7	9
8	10	acts_as_list :scope => :parent
...	...	@@ -64,8 +66,8 @@ class CommunityTrackPlugin::Step < Folder
64	66
65	67	def to_html(options = {})
66	68	step = self
67		- lambda do
68		- render :file => 'content_viewer/step.rhtml', :locals => {:step => step}
	69	+ proc do
	70	+ render :file => 'content_viewer/step', :locals => {:step => step}
69	71	end
70	72	end
71	73
...	...	@@ -86,7 +88,7 @@ class CommunityTrackPlugin::Step < Folder
86	88	if Date.today <= end_date \|\| accept_comments
87	89	schedule_date = !accept_comments ? start_date : end_date + 1.day
88	90	CommunityTrackPlugin::ActivationJob.find(id).destroy_all
89		- Delayed::Job.enqueue(CommunityTrackPlugin::ActivationJob.new(self.id), 0, schedule_date)
	91	+ Delayed::Job.enqueue(CommunityTrackPlugin::ActivationJob.new(self.id), :run_at => schedule_date)
90	92	end
91	93	end
92	94
...	...
...	...	@@ -5,6 +5,8 @@ class CommunityTrackPlugin::Track < Folder
5	5
6	6	validate :validate_categories
7	7
	8	+ attr_accessible :goals, :expected_results
	9	+
8	10	def validate_categories
9	11	errors.add(:categories, _('should not be blank.')) if categories.empty? && pending_categorizations.blank?
10	12	end
...	...	@@ -48,7 +50,7 @@ class CommunityTrackPlugin::Track < Folder
48	50	end
49	51
50	52	def comments_count
51		- steps_unsorted.joins(:children).sum('childrens_articles.comments_count')
	53	+ steps_unsorted.joins(:children).sum('children_articles.comments_count')
52	54	end
53	55
54	56	def css_class_name
...	...	@@ -68,8 +70,8 @@ class CommunityTrackPlugin::Track < Folder
68	70
69	71	def to_html(options = {})
70	72	track = self
71		- lambda do
72		- render :file => 'content_viewer/track.rhtml', :locals => {:track => track}
	73	+ proc do
	74	+ render :file => 'content_viewer/track', :locals => {:track => track}
73	75	end
74	76	end
75	77
...	...
...	...	@@ -48,8 +48,8 @@ class CommunityTrackPlugin::TrackListBlock < Block
48	48
49	49	def content(args={})
50	50	block = self
51		- lambda do
52		- render :file => 'blocks/track_list.rhtml', :locals => {:block => block}
	51	+ proc do
	52	+ render :file => 'blocks/track_list', :locals => {:block => block}
53	53	end
54	54	end
55	55
...	...	@@ -60,7 +60,7 @@ class CommunityTrackPlugin::TrackListBlock < Block
60	60	def footer
61	61	block = self
62	62	return nil if !has_page?(2)
63		- lambda do
	63	+ proc do
64	64	render :partial => 'blocks/track_list_more', :locals => {:block => block, :page => 2, :per_page => block.limit}
65	65	end
66	66	end
...	...
...	...	@@ -88,7 +88,7 @@ class ContentViewerControllerTest < ActionController::TestCase
88	88
89	89	should 'render a div with block id for track list block' do
90	90	box = fast_create(Box, :owner_id => @profile.id, :owner_type => @profile.class.name)
91		- @block = CommunityTrackPlugin::TrackListBlock.create!(:box => box)
	91	+ @block = create(CommunityTrackPlugin::TrackListBlock, :box => box)
92	92	@profile.boxes << box
93	93	get :view_page, @step.url
94	94	assert_tag :tag => 'div', :attributes => { :class => 'track_list', :id => "track_list_#{@block.id}" }
...	...	@@ -96,7 +96,7 @@ class ContentViewerControllerTest < ActionController::TestCase
96	96
97	97	should 'render a div with block id for track card list block' do
98	98	box = fast_create(Box, :owner_id => @profile.id, :owner_type => @profile.class.name)
99		- @block = CommunityTrackPlugin::TrackCardListBlock.create!(:box => box)
	99	+ @block = create(CommunityTrackPlugin::TrackCardListBlock, :box => box)
100	100	@profile.boxes << box
101	101	get :view_page, @step.url
102	102	assert_tag :tag => 'div', :attributes => { :class => 'track_list', :id => "track_list_#{@block.id}" }
...	...	@@ -104,7 +104,7 @@ class ContentViewerControllerTest < ActionController::TestCase
104	104
105	105	should 'render tracks in track list block' do
106	106	box = fast_create(Box, :owner_id => @profile.id, :owner_type => @profile.class.name)
107		- @block = CommunityTrackPlugin::TrackListBlock.create!(:box => box)
	107	+ @block = create(CommunityTrackPlugin::TrackListBlock, :box => box)
108	108	@profile.boxes << box
109	109	get :view_page, @step.url
110	110	assert_tag :tag => 'div', :attributes => { :class => "item category_#{@track.category_name}" }, :descendant => { :tag => 'div', :attributes => { :class => 'steps' }, :descendant => { :tag => 'span', :attributes => { :class => "step #{@block.status_class(@step)}" } } }
...	...	@@ -112,7 +112,7 @@ class ContentViewerControllerTest < ActionController::TestCase
112	112
113	113	should 'render tracks in track card list block' do
114	114	box = fast_create(Box, :owner_id => @profile.id, :owner_type => @profile.class.name)
115		- @block = CommunityTrackPlugin::TrackCardListBlock.create!(:box => box)
	115	+ @block = create(CommunityTrackPlugin::TrackCardListBlock, :box => box)
116	116	@profile.boxes << box
117	117	get :view_page, @step.url
118	118	assert_tag :tag => 'div', :attributes => { :class => "item_card category_#{@track.category_name}" }, :descendant => { :tag => 'div', :attributes => { :class => 'track_content' } }
...	...	@@ -121,7 +121,7 @@ class ContentViewerControllerTest < ActionController::TestCase
121	121
122	122	should 'render link to display more tracks in track list block' do
123	123	box = fast_create(Box, :owner_id => @profile.id, :owner_type => @profile.class.name)
124		- @block = CommunityTrackPlugin::TrackCardListBlock.create!(:box => box)
	124	+ @block = create(CommunityTrackPlugin::TrackCardListBlock, :box => box)
125	125	@profile.boxes << box
126	126
127	127	(@block.limit+1).times { \|i\| create_track("track#{i}", @profile) }
...	...	@@ -132,7 +132,7 @@ class ContentViewerControllerTest < ActionController::TestCase
132	132
133	133	should 'render link to show all tracks in track list block' do
134	134	box = fast_create(Box, :owner_id => @profile.id, :owner_type => @profile.class.name)
135		- @block = CommunityTrackPlugin::TrackCardListBlock.create!(:box => box)
	135	+ @block = create(CommunityTrackPlugin::TrackCardListBlock, :box => box)
136	136	@profile.boxes << box
137	137	@block.more_another_page = true
138	138	@block.save!
...	...
...	...	@@ -15,9 +15,9 @@ class EnvironmentDesignControllerTest < ActionController::TestCase
15	15	@environment.add_admin(user.person)
16	16	login_as(user.login)
17	17
18		- box = Box.create!(:owner => @environment)
19		- @block = CommunityTrackPlugin::TrackListBlock.create!(:box => box)
20		- @block_card = CommunityTrackPlugin::TrackCardListBlock.create!(:box => box)
	18	+ box = create(Box, :owner => @environment)
	19	+ @block = create(CommunityTrackPlugin::TrackListBlock, :box => box)
	20	+ @block_card = create(CommunityTrackPlugin::TrackCardListBlock, :box => box)
21	21	end
22	22
23	23	should 'be able to edit TrackListBlock' do
...	...
...	...	@@ -11,8 +11,8 @@ class CommunityTrackPluginPublicControllerTest < ActionController::TestCase
11	11	@track = create_track('track', @community)
12	12
13	13	box = fast_create(Box, :owner_id => @community.id, :owner_type => 'Community')
14		- @card_block = CommunityTrackPlugin::TrackCardListBlock.create!(:box => box)
15		- @block = CommunityTrackPlugin::TrackListBlock.create!(:box => box)
	14	+ @card_block = create(CommunityTrackPlugin::TrackCardListBlock, :box => box)
	15	+ @block = create(CommunityTrackPlugin::TrackListBlock, :box => box)
16	16	end
17	17
18	18	should 'display tracks for card block' do
...	...
...	...	@@ -4,7 +4,7 @@ class StepTest < ActiveSupport::TestCase
4	4
5	5	def setup
6	6	@profile = fast_create(Community)
7		- @track = CommunityTrackPlugin::Track.new(:profile_id => @profile.id, :name => 'track')
	7	+ @track = CommunityTrackPlugin::Track.new(:profile => @profile, :name => 'track')
8	8	@category = fast_create(Category)
9	9	@track.add_category(@category)
10	10	@track.save!
...	...	@@ -61,13 +61,13 @@ class StepTest < ActiveSupport::TestCase
61	61	should 'do not validate date period if start date is nil' do
62	62	@step.start_date = nil
63	63	@step.end_date_equal_or_after_start_date.inspect
64		- assert [], @step.errors
	64	+ assert @step.errors.empty?
65	65	end
66	66
67	67	should 'do not validate date period if end date is nil' do
68	68	@step.end_date = nil
69	69	@step.end_date_equal_or_after_start_date.inspect
70		- assert [], @step.errors
	70	+ assert @step.errors.empty?
71	71	end
72	72
73	73	should 'be active if today is between start and end dates' do
...	...
...	...	@@ -5,7 +5,7 @@ class TrackCardListBlockTest < ActiveSupport::TestCase
5	5	def setup
6	6	@community = fast_create(Community)
7	7	box = fast_create(Box, :owner_id => @community.id, :owner_type => @community.class.name)
8		- @block = CommunityTrackPlugin::TrackCardListBlock.create!(:box => box)
	8	+ @block = create(CommunityTrackPlugin::TrackCardListBlock, :box => box)
9	9	end
10	10
11	11	should 'describe yourself' do
...	...
...	...	@@ -6,7 +6,7 @@ class TrackListBlockTest < ActiveSupport::TestCase
6	6	@profile = fast_create(Community)
7	7	@track = create_track('track', profile)
8	8	box = fast_create(Box, :owner_id => @profile.id, :owner_type => @profile.class.name)
9		- @block = CommunityTrackPlugin::TrackListBlock.create!(:box => box)
	9	+ @block = create(CommunityTrackPlugin::TrackListBlock, :box => box)
10	10	end
11	11
12	12	attr_reader :profile
...	...	@@ -31,7 +31,7 @@ class TrackListBlockTest < ActiveSupport::TestCase
31	31
32	32	should 'list of articles be limited by block configuration' do
33	33	(@block.limit + 1).times { \|i\| create_track("track#{i}", profile) }
34		- assert_equal @block.limit, @block.tracks.count
	34	+ assert_equal @block.limit, @block.tracks.size
35	35	end
36	36
37	37	should 'return more link if has more tracks to show' do
...	...