Download as
Browse Code »

Commit 1098be610d999b0a54c80a299a69453dd8f1e7b5

Authored by Antonio Terceiro
1 parent 9593b2d9
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

Replacing scary eval's with String#constantize

Showing 2 changed files with 2 additions and 2 deletions   Show diff stats
app/controllers/admin/plugins_controller.rb
  Diff comments   View file @1098be6
1 1 class PluginsController < AdminController
2 2  
3 3 def index
4   - @active_plugins = Noosfero::Plugin.all.map {|plugin_name| eval(plugin_name)}.compact
  4 + @active_plugins = Noosfero::Plugin.all.map {|plugin_name| plugin_name.constantize }.compact
5 5 end
6 6  
7 7 post_only :update
... ...
lib/noosfero/plugin/manager.rb
  Diff comments   View file @1098be6
... ... @@ -12,7 +12,7 @@ class Noosfero::Plugin::Manager
12 12  
13 13 def enabled_plugins
14 14 @enabled_plugins ||= (Noosfero::Plugin.all & context.environment.enabled_plugins).map do |plugin|
15   - p = eval(plugin).new
  15 + p = plugin.constantize.new
16 16 p.context = context
17 17 p
18 18 end
... ...