Fixes for sendemail_plugin

- Fixed email sent to users - Removed from params info that don't need to be displayed to users on screen and email - Fixed replace of macro "{sendemail}"

Fixes for sendemail_plugin
- Fixed email sent to users - Removed from params info that don't need to be displayed to users on screen and email - Fixed replace of macro "{sendemail}"
Daniela Feitosa
1 parent b501e2ce
Showing 10 changed files with 36 additions and 20 deletions Show diff stats
plugins/send_email/controllers/send_email_plugin_base_controller.rb
plugins/send_email/lib/send_email_plugin.rb
plugins/send_email/lib/send_email_plugin/mail.rb
plugins/send_email/lib/send_email_plugin/sender.rb
plugins/send_email/test/functional/send_email_plugin_base_controller_test.rb
plugins/send_email/test/unit/send_email_plugin_sender_test.rb
plugins/send_email/test/unit/send_email_plugin_test.rb
plugins/send_email/views/send_email_plugin/sender/message.html.erb
plugins/send_email/views/send_email_plugin/sender/send_message.html.erb
plugins/send_email/views/send_email_plugin/success.html.erb
@@ -11,7 +11,8 @@ module SendEmailPluginBaseController
       )
       @mail.subject = params[:subject] unless params[:subject].blank?
       if @mail.valid?
-        SendEmailPlugin::Sender.send_message(request.referer, @context_url, @mail).deliver
+        @referer = request.referer
+        SendEmailPlugin::Sender.send_message(@referer, @context_url, @mail).deliver
         if request.xhr?
           render :text => _('Message sent')
         else
@@ -16,9 +16,9 @@ class SendEmailPlugin &lt; Noosfero::Plugin
   def parse_content(html, source)
     if context.profile
-      html.gsub!(/\{sendemail\}/, "/profile/#{context.profile.identifier}/plugin/send_email/deliver")
+      html.gsub!(/({|%7[Bb])sendemail(}|%7[Dd])/, "/profile/#{context.profile.identifier}/plugin/send_email/deliver")
     else
-      html.gsub!(/\{sendemail\}/, '/plugin/send_email/deliver')
+      html.gsub!(/({|%7[Bb])sendemail(}|%7[Dd])/, '/plugin/send_email/deliver')
     end
     [html, source]
   end
@@ -10,12 +10,11 @@ class SendEmailPlugin::Mail
   validate :recipients_format
   def initialize(attributes = {:subject => 'New mail'})
-    @environment = attributes[:environment]
-    @from = attributes[:from]
-    @to = attributes[:to]
-    @subject = attributes[:subject]
-    @message = attributes[:message]
-    @params = attributes[:params]
+    if attributes
+      attributes.each do |attr,value|
+        self.send("#{attr}=", value)
+      end
+    end
   end
   def recipients_format
@@ -36,7 +35,7 @@ class SendEmailPlugin::Mail
   end
   def params=(value = {})
-    [:action, :controller, :to, :message, :subject, :from].each{|k| value.delete(k)}
+    [:action, :controller, :to, :message, :subject, :from, :commit].each{|k| value.delete(k)}
     @params = value
   end
@@ -9,7 +9,6 @@ class SendEmailPlugin::Sender &lt; Noosfero::Plugin::MailerBase
     mail(
       to: mail.to,
       from: mail.from,
-      body: mail.params,
       subject: "[#{mail.environment.name}] #{mail.subject}"
     )
   end
@@ -54,6 +54,13 @@ def run_common_tests
     post :deliver, @extra_args.merge(:to => 'john@example.com', :message => 'Hi john', :subject => 'Hello john')
     assert_equal '[Colivre.net] Hello john', ActionMailer::Base.deliveries.first.subject
   end
+
+  should 'deliver mail with message from view' do
+    Environment.any_instance.stubs(:send_email_plugin_allow_to).returns('john@example.com')
+    post :deliver, @extra_args.merge(:to => 'john@example.com', :message => 'Hi john', :subject => 'Hello john')
+    assert_match /Contact from/, ActionMailer::Base.deliveries.first.body.to_s
+  end
+
 end
 class SendEmailPluginProfileControllerTest < ActionController::TestCase
@@ -15,12 +15,14 @@ class SendEmailPluginSenderTest &lt; ActiveSupport::TestCase
   end
   should 'be able to deliver mail' do
+    @mail.expects(:params).returns({})
     response = SendEmailPlugin::Sender.send_message("http://localhost/contact", 'http//profile', @mail)
     assert_equal 'noreply@localhost', response.from.join
     assert_equal "[Noosfero] #{@mail.subject}", response.subject
   end
   should 'deliver mail to john@example.com' do
+    @mail.expects(:params).returns({})
     response = SendEmailPlugin::Sender.send_message("http://localhost/contact", 'http//profile', @mail)
     assert_equal ['john@example.com'], response.to
   end
@@ -26,4 +26,12 @@ class SendEmailPluginTest &lt; ActiveSupport::TestCase
     assert_match /profile\/#{@plugin.context.profile.identifier}\/plugin\/send_email\/deliver/, @plugin.parse_content("expand this macro {sendemail}", nil).first
   end
+  should 'expand macro used on form on profile context' do
+    profile = fast_create(Community)
+    @plugin.context.stubs(:profile).returns(profile)
+    article = RawHTMLArticle.create!(:name => 'Raw HTML', :body => "<form action='{sendemail}'></form>", :profile => profile)
+
+    assert_match /profile\/#{profile.identifier}\/plugin\/send_email\/deliver/, @plugin.parse_content(article.to_html, nil).first
+  end
+
 end
@@ -1,8 +0,0 @@
-<%= _('Contact from %s') % @referer %>
-
-<%= word_wrap(@message || @mail.message) %>
-<% (@params || @mail.params).each_pair do |key, value| %>
-<%= key %>: <%= word_wrap(value) %>
-<% end %>
----
-<%= url_for @context_url %>
@@ -0,0 +1,8 @@
+<%= _('Contact from %s') % @referer %>
+
+<%= word_wrap(@message || @mail.message) %>
+<% (@params || @mail.params).each_pair do |key, value| %>
+<%= key %>: <%= word_wrap(value) %>
+<% end %>
+---
+<%= url_for @context_url %>
@@ -2,7 +2,7 @@
 <table class='sendemail-plugin-message-sent'>
   <tr><td class='label'><strong><%= c_('Subject') %>:</strong></td><td class='value'><em><%=h @mail.subject %></em></td></tr>
-  <tr><td class='label'><strong><%= c_('Message') %>:</strong></td><td class='value'><pre><%=h render :file => 'send_email_plugin/sender/message' %></pre></td></tr>
+  <tr><td class='label'><strong><%= c_('Message') %>:</strong></td><td class='value'><pre><%=h render :file => 'send_email_plugin/sender/send_message' %></pre></td></tr>
 </table>
 <p><%= button :back, c_('Back'), :back %></p>
	@@ -16,9 +16,9 @@ class SendEmailPlugin < Noosfero::Plugin		@@ -16,9 +16,9 @@ class SendEmailPlugin < Noosfero::Plugin
16		16
17	def parse_content(html, source)	17	def parse_content(html, source)
18	if context.profile	18	if context.profile
19	- html.gsub!(/\{sendemail\}/, "/profile/#{context.profile.identifier}/plugin/send_email/deliver")	19	+ html.gsub!(/({\|%7[Bb])sendemail(}\|%7[Dd])/, "/profile/#{context.profile.identifier}/plugin/send_email/deliver")
20	else	20	else
21	- html.gsub!(/\{sendemail\}/, '/plugin/send_email/deliver')	21	+ html.gsub!(/({\|%7[Bb])sendemail(}\|%7[Dd])/, '/plugin/send_email/deliver')
22	end	22	end
23	[html, source]	23	[html, source]
24	end	24	end
	@@ -54,6 +54,13 @@ def run_common_tests		@@ -54,6 +54,13 @@ def run_common_tests
54	post :deliver, @extra_args.merge(:to => 'john@example.com', :message => 'Hi john', :subject => 'Hello john')	54	post :deliver, @extra_args.merge(:to => 'john@example.com', :message => 'Hi john', :subject => 'Hello john')
55	assert_equal '[Colivre.net] Hello john', ActionMailer::Base.deliveries.first.subject	55	assert_equal '[Colivre.net] Hello john', ActionMailer::Base.deliveries.first.subject
56	end	56	end
		57	+
		58	+ should 'deliver mail with message from view' do
		59	+ Environment.any_instance.stubs(:send_email_plugin_allow_to).returns('john@example.com')
		60	+ post :deliver, @extra_args.merge(:to => 'john@example.com', :message => 'Hi john', :subject => 'Hello john')
		61	+ assert_match /Contact from/, ActionMailer::Base.deliveries.first.body.to_s
		62	+ end
		63	+
57	end	64	end
58		65
59	class SendEmailPluginProfileControllerTest < ActionController::TestCase	66	class SendEmailPluginProfileControllerTest < ActionController::TestCase
	@@ -26,4 +26,12 @@ class SendEmailPluginTest < ActiveSupport::TestCase		@@ -26,4 +26,12 @@ class SendEmailPluginTest < ActiveSupport::TestCase
26	assert_match /profile\/#{@plugin.context.profile.identifier}\/plugin\/send_email\/deliver/, @plugin.parse_content("expand this macro {sendemail}", nil).first	26	assert_match /profile\/#{@plugin.context.profile.identifier}\/plugin\/send_email\/deliver/, @plugin.parse_content("expand this macro {sendemail}", nil).first
27	end	27	end
28		28
		29	+ should 'expand macro used on form on profile context' do
		30	+ profile = fast_create(Community)
		31	+ @plugin.context.stubs(:profile).returns(profile)
		32	+ article = RawHTMLArticle.create!(:name => 'Raw HTML', :body => "<form action='{sendemail}'></form>", :profile => profile)
		33	+
		34	+ assert_match /profile\/#{profile.identifier}\/plugin\/send_email\/deliver/, @plugin.parse_content(article.to_html, nil).first
		35	+ end
		36	+
29	end	37	end
	@@ -1,8 +0,0 @@	@@ -1,8 +0,0 @@
1	-<%= _('Contact from %s') % @referer %>
2	-
3	-<%= word_wrap(@message \|\| @mail.message) %>
4	-<% (@params \|\| @mail.params).each_pair do \|key, value\| %>
5	-<%= key %>: <%= word_wrap(value) %>
6	-<% end %>
7	----
8	-<%= url_for @context_url %>
@@ -0,0 +1,8 @@		@@ -0,0 +1,8 @@
	1	+<%= _('Contact from %s') % @referer %>
	2	+
	3	+<%= word_wrap(@message \|\| @mail.message) %>
	4	+<% (@params \|\| @mail.params).each_pair do \|key, value\| %>
	5	+<%= key %>: <%= word_wrap(value) %>
	6	+<% end %>
	7	+---
	8	+<%= url_for @context_url %>
	@@ -2,7 +2,7 @@		@@ -2,7 +2,7 @@
2		2
3	<table class='sendemail-plugin-message-sent'>	3	<table class='sendemail-plugin-message-sent'>
4	<tr><td class='label'><strong><%= c_('Subject') %>:</strong></td><td class='value'><em><%=h @mail.subject %></em></td></tr>	4	<tr><td class='label'><strong><%= c_('Subject') %>:</strong></td><td class='value'><em><%=h @mail.subject %></em></td></tr>
5	- <tr><td class='label'><strong><%= c_('Message') %>:</strong></td><td class='value'><pre><%=h render :file => 'send_email_plugin/sender/message' %></pre></td></tr>	5	+ <tr><td class='label'><strong><%= c_('Message') %>:</strong></td><td class='value'><pre><%=h render :file => 'send_email_plugin/sender/send_message' %></pre></td></tr>
6	</table>	6	</table>
7		7
8	<p><%= button :back, c_('Back'), :back %></p>	8	<p><%= button :back, c_('Back'), :back %></p>