Download as
Browse Code »

Commit 1cfc5e1db92a7dae8d8e34723443a453575e208c

Authored by Antonio Terceiro
1 parent ff995715
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

Fix String#to_slug to work with multi-byte UTF-8 characters

Showing 2 changed files with 5 additions and 1 deletions   Show diff stats
lib/noosfero/core_ext/string.rb
  Diff comments   View file @1cfc5e1
@@ -37,7 +37,7 @@ class String @@ -37,7 +37,7 @@ class String
37 end 37 end
38 38
39 def to_slug 39 def to_slug
40 - transliterate.downcase.gsub(/[^a-z0-9~\s:;+=_."'`-]/, '').gsub(/[\s:;+=_"'`-]+/, '-').gsub(/-$/, '').gsub(/^-/, '').to_s 40 + transliterate.downcase.gsub(/[^\w~\s:;+=_."'`-]/, '').gsub(/[\s:;+=_"'`-]+/, '-').gsub(/-$/, '').gsub(/^-/, '').to_s
41 end 41 end
42 42
43 end 43 end
test/unit/string_core_ext_test.rb
  Diff comments   View file @1cfc5e1
@@ -24,6 +24,10 @@ class StringCoreExtTest < Test::Unit::TestCase @@ -24,6 +24,10 @@ class StringCoreExtTest < Test::Unit::TestCase
24 assert_equal 'a.b', 'a.b'.to_slug 24 assert_equal 'a.b', 'a.b'.to_slug
25 end 25 end
26 26
  27 + should 'handle multy-byte UTF-8 characters properly' do
  28 + assert_equal '日本語ローカライズチーム-home', '日本語ローカライズチーム_HOME'.to_slug
  29 + end
  30 +
27 # tests for String#transliterate 31 # tests for String#transliterate
28 should 'transliterate' do 32 should 'transliterate' do
29 assert_equal 'aaaaaaAAAAAeeeeEEOOoocaaaiIIiuuyYnNcC', 'ªáàäâåÁÀÄÂÅéèëêÊËÖÔöôçäàâîÏÎïûüÿŸñÑçÇ'.transliterate 33 assert_equal 'aaaaaaAAAAAeeeeEEOOoocaaaiIIiuuyYnNcC', 'ªáàäâåÁÀÄÂÅéèëêÊËÖÔöôçäàâîÏÎïûüÿŸñÑçÇ'.transliterate