Download as
Browse Code »

Commit 1f15609ca27213103cbde9405328e48489abeacc

Authored by AntonioTerceiro
1 parent 7403a597
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

ActionItem42: refactoring: moving method up 


git-svn-id: https://svn.colivre.coop.br/svn/noosfero/trunk@1379 3f533792-8f58-4932-b0fe-aaf55b0a4547
Showing 4 changed files with 14 additions and 16 deletions   Show diff stats
app/models/community.rb
  Diff comments   View file @1f15609
... ... @@ -7,11 +7,4 @@ class Community < Organization
7 7 self.identifier = value.to_slug
8 8 end
9 9  
10   - # FIXME should't this method be in Profile class?
11   - #
12   - # Adds a person as member of this Community (FIXME).
13   - def add_member(person)
14   - self.affiliate(person, Profile::Roles.member)
15   - end
16   -
17 10 end
... ...
app/models/profile.rb
  Diff comments   View file @1f15609
... ... @@ -247,4 +247,9 @@ class Profile < ActiveRecord::Base
247 247 feed.save!
248 248 end
249 249  
  250 + # Adds a person as member of this Profile.
  251 + def add_member(person)
  252 + self.affiliate(person, Profile::Roles.member)
  253 + end
  254 +
250 255 end
... ...
test/unit/community_test.rb
  Diff comments   View file @1f15609
... ... @@ -18,15 +18,6 @@ class CommunityTest < Test::Unit::TestCase
18 18 assert_equal 'the description of the community', c.description
19 19 end
20 20  
21   - should 'allow to add new members' do
22   - c = Community.create!(:name => 'my test community')
23   - p = create_user('mytestuser').person
24   -
25   - c.add_member(p)
26   -
27   - assert c.members.include?(p), "Community should add the new member"
28   - end
29   -
30 21 should 'create default set of blocks' do
31 22 c = Community.create!(:name => 'my new community')
32 23  
... ...
test/unit/profile_test.rb
  Diff comments   View file @1f15609
... ... @@ -325,6 +325,15 @@ class ProfileTest < Test::Unit::TestCase
325 325 assert_kind_of RssFeed, profile.articles.find_by_path('feed')
326 326 end
327 327  
  328 + should 'allow to add new members' do
  329 + c = Profile.create!(:name => 'my test profile', :identifier => 'mytestprofile')
  330 + p = create_user('mytestuser').person
  331 +
  332 + c.add_member(p)
  333 +
  334 + assert c.members.include?(p), "Profile should add the new member"
  335 + end
  336 +
328 337  
329 338 private
330 339  
... ...