Download as
Browse Code »

Commit 2a1c3797b76fbee7208710eba8b12318ed9d4d88

Authored by Larissa Reis
1 parent 93103d85
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

Fixes the hidden tag that overwrited product qualifiers 

  An hidden tag is used to update qualifiers_list in products even when
  said qualifiers_list is empty, so it would behave accordingly with the
  way the qualifiers are added dinamically using javascript and ajax
  (that is, the list represents the content of a product's qualifiers,
  so an empty list means that whatever qualifiers that the product had
  before should be removed). But this tag was overwriting the qualifiers
  and certifiers added by the user, thus making rails believe that the
  qualifiers list was always empty.

  I've changed the hidden tag to have a default value 'nil' (which is
  actually a string, but it works; I couldn't find a way to put an
  actual nil value), and when the qualifiers list is updated the method
  inside the model ignores qualifiers whose id value are 'nil'.

(ActionItem2328)
Showing 2 changed files with 2 additions and 2 deletions   Show diff stats
app/models/product.rb
  Diff comments   View file @2a1c379
... ... @@ -155,7 +155,7 @@ class Product < ActiveRecord::Base
155 155 def qualifiers_list=(qualifiers)
156 156 self.product_qualifiers.destroy_all
157 157 qualifiers.each do |qualifier_id, certifier_id|
158   - self.product_qualifiers.create(:qualifier_id => qualifier_id, :certifier_id => certifier_id)
  158 + self.product_qualifiers.create(:qualifier_id => qualifier_id, :certifier_id => certifier_id) if qualifier_id != 'nil'
159 159 end
160 160 end
161 161  
... ...
app/views/manage_products/_edit_info.rhtml
  Diff comments   View file @2a1c379
... ... @@ -50,7 +50,7 @@
50 50 _('Add new qualifier'),
51 51 "new_qualifier_row('#product-qualifiers-list', '#{escape_javascript(select_qualifiers(@product))}')"
52 52 ) %>
53   - <%= hidden_field_tag "product[qualifiers_list]" %>
  53 + <%= hidden_field_tag "product[qualifiers_list][nil]" %>
54 54 <% end %>
55 55  
56 56 <%= hidden_field_tag 'info-bar-update-url', @product.price_composition_bar_display_url, :class => 'bar-update-url' %>
... ...