[Mezuro] refactoring name format in module result view

João M. M. da Silva + Jefferson Fernandes · Paulo Meireles
1 parent 2a1fac14
Showing 3 changed files with 17 additions and 7 deletions Show diff stats
plugins/mezuro/lib/mezuro_plugin/helpers/content_viewer_helper.rb
plugins/mezuro/test/unit/mezuro_plugin/helpers/content_viewer_helper_test.rb
plugins/mezuro/views/content_viewer/_module_result.rhtml
@@ -23,8 +23,12 @@ class MezuroPlugin::Helpers::ContentViewerHelper
   end
   def self.get_periodicity_option(index)
-   options = [["Not Periodically", 0], ["1 day", 1], ["2 days", 2], ["Weekly", 7], ["Biweeky", 15], ["Monthly", 30]]
-   selected_option = options.find { |option| option.last == index.to_i }
-   selected_option.first
+    options = [["Not Periodically", 0], ["1 day", 1], ["2 days", 2], ["Weekly", 7], ["Biweeky", 15], ["Monthly", 30]]
+    selected_option = options.find { |option| option.last == index.to_i }
+    selected_option.first
+  end
+  
+  def self.format_name(metric_result)
+    metric_result.metric.name.delete("() ")
   end
 end
 require "test_helper"
+require "#{RAILS_ROOT}/plugins/mezuro/test/fixtures/metric_result_fixtures"
 class ContentViewerHelperTest < ActiveSupport::TestCase
@@ -11,4 +12,9 @@ class ContentViewerHelperTest &lt; ActiveSupport::TestCase
   should 'create the periodicity options array' do
     assert_equal [["Not Periodically", 0], ["1 day", 1], ["2 days", 2], ["Weekly", 7], ["Biweeky", 15], ["Monthly", 30]], MezuroPlugin::Helpers::ContentViewerHelper.create_periodicity_options
   end
+  
+  should 'format metric name for module result' do
+    metric_result = MetricResultFixtures.amloc_result
+    assert_equal 'AverageMethodLOC', MezuroPlugin::Helpers::ContentViewerHelper.format_name(metric_result)
+  end
 end
@@ -19,15 +19,15 @@
       <% range = metric_result.range %>
       <% if !range.nil? %>
         <tr>
-          <td><a href="#" data-show=".<%= metric_result.metric.name.delete("() ")%>"><%= metric_result.metric.name %></a></td>
+          <td><a href="#" data-show=".<%= MezuroPlugin::Helpers::ContentViewerHelper.format_name(metric_result) %>"><%= metric_result.metric.name %></a></td>
           <td><%= MezuroPlugin::Helpers::ContentViewerHelper.format_grade(metric_result.value) %></td>
           <td><%= metric_result.weight %></td>
           <td style="background-color: #<%= range.color[2..-1] %>"><%= range.label %></td>
         </tr>	  
-        <tr class="<%= metric_result.metric.name.delete("() ")%>" style="display: none;">
+        <tr class="<%= MezuroPlugin::Helpers::ContentViewerHelper.format_name(metric_result) %>" style="display: none;">
           <td colspan="3">
-            <div id='historical-<%= metric_result.metric.name.delete("() ") %>'>
-              <a href="#" show-metric-history="<%= metric_result.metric.name.delete("() ") %>" data-module-name="<%= the_module.name %>" data-metric-name="<%= metric_result.metric.name.delete("() ") %>"> <p style="text-indent: 3em;"> Get Historical Values </p> </a>
+            <div id='historical-<%= MezuroPlugin::Helpers::ContentViewerHelper.format_name(metric_result) %>'>
+              <a href="#" show-metric-history="<%= MezuroPlugin::Helpers::ContentViewerHelper.format_name(metric_result) %>" data-module-name="<%= the_module.name %>" data-metric-name="<%= MezuroPlugin::Helpers::ContentViewerHelper.format_name(metric_result) %>"> <p style="text-indent: 3em;"> Get Historical Values </p> </a>
             </div>
           </td>
           <td align="right">