Move labelled_form_for to new api format

Rodrigo Souto
1 parent 0d5e3192
Showing 31 changed files with 35 additions and 37 deletions Show diff stats
app/controllers/admin/environment_role_manager_controller.rb
app/helpers/application_helper.rb
app/views/account/_login_form.html.erb
app/views/account/_signup_form.html.erb
app/views/account/login.html.erb
app/views/account/login_block.html.erb
app/views/admin_panel/message_for_disabled_enterprise.html.erb
app/views/admin_panel/set_portal_news_amount.html.erb
app/views/admin_panel/site_info.html.erb
app/views/categories/_form.html.erb
app/views/cms/destroy.html.erb
app/views/cms/edit.html.erb
app/views/cms/suggest_an_article.html.erb
app/views/contact/new.html.erb
app/views/enterprise_registration/basic_information.html.erb
app/views/enterprise_validation/edit_validation_info.html.erb
app/views/environment_role_manager/change_role.html.erb
app/views/environment_role_manager/make_admin.html.erb
app/views/features/_manage_community_fields.html.erb
app/views/features/_manage_enterprise_fields.html.erb
 class EnvironmentRoleManagerController < AdminController
   protect 'manage_environment_roles', :environment
-  
+
   def index
     @admins = Person.find(:all, :conditions => ['role_assignments.resource_type = ?', 'Environment'], :include => :role_assignments )
   end
@@ -8,7 +8,7 @@ class EnvironmentRoleManagerController &lt; AdminController
   def change_roles
     @admin = Person.find(params[:id])
     @roles = Role.find(:all).select{ |r| r.has_kind?(:environment) }
-  end  
+  end
   def update_roles
     @roles = params[:roles] ? Role.find(params[:roles]) : []
@@ -20,7 +20,7 @@ class EnvironmentRoleManagerController &lt; AdminController
     end
     redirect_to :action => :index
   end
-  
+
   def change_role
     @roles = Role.find(:all).select{ |r| r.has_kind?(:environment) }
     @admin = Person.find(params[:id])
@@ -805,8 +805,7 @@ module ApplicationHelper
     fields_for(name, object, { :builder => NoosferoFormBuilder }.merge(options), &proc)
   end
-  def labelled_form_for(name, object = nil, options = {}, &proc)
-    # FIXME remove the =object= argument and adapt the calling code
+  def labelled_form_for(name, options = {}, &proc)
     form_for(name, { :builder => NoosferoFormBuilder }.merge(options), &proc)
   end
-<%= labelled_form_for :user, @user,
+<%= labelled_form_for :user,
    :url => { :controller => 'account', :action => (params[:enterprise_code] ? 'activate_enterprise' : 'login') }  do |f| %>
 <%= f.text_field :login,
@@ -11,7 +11,7 @@
 <%= error_messages_for :user, :person, :header_message => _('The account could not be created') %>
-<%= labelled_form_for :user, @user, :html => { :multipart => true, :id => 'signup-form', :honeypot => true } do |f| %>
+<%= labelled_form_for :user, :html => { :multipart => true, :id => 'signup-form', :honeypot => true } do |f| %>
 <input type="hidden" id="signup_time_key" name="signup_time_key" />
 <script type="text/javascript">
@@ -7,7 +7,7 @@
 <%= @message %>
-<%= labelled_form_for :user, @user, :url => login_url do |f| %>
+<%= labelled_form_for :user, :url => login_url do |f| %>
      <%= f.text_field :login, :id => 'main_user_login', :onchange => 'this.value = convToValidLogin( this.value )', :value => params[:userlogin] %>
@@ -8,8 +8,8 @@
 <%
   @user ||= User.new
 %>
-    
-    <%= labelled_form_for :user, @user, :url => login_url do |f| %>
+
+    <%= labelled_form_for :user, :url => login_url do |f| %>
       <%= f.text_field :login, :onchange => 'this.value = convToValidLogin( this.value )' %>
@@ -2,7 +2,7 @@
 <%= render :file => 'shared/tiny_mce' %>
-<%= labelled_form_for :environment, @environment, :url => {:action => 'site_info'} do |f| %>
+<%= labelled_form_for :environment, :url => {:action => 'site_info'} do |f| %>
   <%= f.text_area :message_for_disabled_enterprise, :cols => 40, :style => 'width: 90%' %>
 <h1><%= _('News amount by folder') %></h1>
-<%= labelled_form_for :environment, @environment do |f| %>
+<%= labelled_form_for :environment do |f| %>
   <%= labelled_form_field _('Number of news'), select(:environment, :news_amount_by_folder, (1..10).to_a) %>
@@ -4,7 +4,7 @@
 <%= render :file => 'shared/tiny_mce' %>
-<%= labelled_form_for :environment, @environment do |f| %>
+<%= labelled_form_for :environment do |f| %>
   <% tabs = [] %>
   <% tabs << {:title => _('Site info'), :id => 'site-info',
     :content => (render :partial => 'site_info', :locals => {:f => f})} %>
 <%= error_messages_for 'category' %>
-<%= labelled_form_for 'category', @category, :html => { :multipart => true} do |f| %>
+<%= labelled_form_for 'category', :html => { :multipart => true} do |f| %>
   <%= required_fields_message %>
@@ -2,7 +2,7 @@
 <%= error_messages_for 'article' %>
-<%= labelled_form_for 'article', @article, :url => { :action => 'destroy' }, :method => 'post' do |f| %>
+<%= labelled_form_for 'article', :url => { :action => 'destroy' }, :method => 'post' do |f| %>
   <strong>
     <% if @article.folder? %>
 <%= error_messages_for 'article' %>
 <div class='<%= (environment.enabled?('media_panel') ? 'with_media_panel' : 'no_media_panel') %>'>
-<%= labelled_form_for 'article', @article, :html => { :multipart => true, :class => @type } do |f| %>
+<%= labelled_form_for 'article', :html => { :multipart => true, :class => @type } do |f| %>
   <%= hidden_field_tag("type", @type) if @type %>
@@ -4,7 +4,7 @@
 <%= render :file => 'shared/tiny_mce' %>
-<%= labelled_form_for 'task', @task do |f| %>
+<%= labelled_form_for 'task' do |f| %>
   <%= required labelled_form_field(_('Title'), text_field(:task, 'article_name', :size => 50)) %>
@@ -8,7 +8,7 @@
 <%= error_messages_for 'contact' %>
-<%= labelled_form_for :contact, @contact do |f| %>
+<%= labelled_form_for :contact do |f| %>
   <%= hidden_field_tag(:confirm, 'false') %>
   <%= required_fields_message %>
@@ -18,7 +18,7 @@
   <%= required_fields_message %>
-  <%= labelled_form_for(:create_enterprise, @create_enterprise) do |f| %>
+  <%= labelled_form_for :create_enterprise do |f| %>
     <%= required f.text_field 'name', :onchange => "updateUrlField(this, 'create_enterprise_identifier')", :size => 40 %>
     <%= required labelled_form_field(_('Address'), content_tag('code', environment.top_url + "/" + text_field(:create_enterprise, 'identifier', :size => 26))) %>
     <%= render :partial => 'shared/organization_custom_fields', :locals => { :f => f, :object_name => :create_enterprise, :profile => @create_enterprise } %>
@@ -2,7 +2,7 @@
 <%= error_messages_for :info %>
-<%= labelled_form_for :info, @info do |f| %>
+<%= labelled_form_for :info do |f| %>
   <%= f.text_area(:validation_methodology, :cols => 50, :rows => 10) %>
   <%= f.text_area(:restrictions, :cols => 50, :rows => 7) %>
   <% button_bar do %>
 <%= _('Changing role of %s') % @admin.name %>
-<%= labelled_form_for :member, @admin, :url => {:action => 'update_roles'} do |f| %>
-  
+<%= labelled_form_for :admin, :url => {:action => 'update_roles'} do |f| %>
   <%= _('Roles:') %> <br>
   <% @roles.each do |r| %>
     <%= labelled_form_field(r.name, (check_box_tag "roles[]", r.id, @admin.role_assignments.map{|ra|ra.role}.include?(r))) %>
 <h2> <% _('Make new admin') %> </h2>
-<%= labelled_form_for :person, @person, :url => {:action => 'update_roles'} do |f| %>
+<%= labelled_form_for :person, :url => {:action => 'update_roles'} do |f| %>
   <%= _('Admin') %> <br>
   <% @people.each do |p| %>
     <%= labelled_form_field(p.name, (radio_button_tag "person", p.id)) %>
-<%= labelled_form_for(:environment, @environment, :url => {:action => 'manage_community_fields'}) do |f| %>
+<%= labelled_form_for(:environment, :url => {:action => 'manage_community_fields'}) do |f| %>
 <table id='community_fields_conf'>
   <tr>
-<%= labelled_form_for(:environment, @environment, :url => {:action => 'manage_enterprise_fields'}) do |f| %>
+<%= labelled_form_for(:environment, :url => {:action => 'manage_enterprise_fields'}) do |f| %>
 <table id='enterprise_fields_conf'>
   <tr>
-<%= labelled_form_for(:environment, @environment, :url => {:action => 'manage_person_fields'}) do |f| %>
+<%= labelled_form_for(:environment, :url => {:action => 'manage_person_fields'}) do |f| %>
 <table id='person_fields_conf'>
   <tr>
@@ -8,7 +8,7 @@
 Check all the features you want to enable for your environment, uncheck all the ones you don\'t want, and use the <em>"Save changes" button</em> to confirm your changes.') %>
 </p>
-<%= labelled_form_for(:environment, @environment, :url => {:action => 'update'}) do |f| %>
+<%= labelled_form_for(:environment, :url => {:action => 'update'}) do |f| %>
 <table>
   <tr>
@@ -10,7 +10,7 @@
 <div>
-<%= labelled_form_for :community, @community, :html => { :multipart => true } do |f| %>
+<%= labelled_form_for :community, :html => { :multipart => true } do |f| %>
   <%= required_fields_message %>
@@ -4,7 +4,7 @@
 <%= _('Select which plugins you want to enable in your environment') %>
 </p>
-<%= labelled_form_for(:environment, @environment, :url => {:action => 'update'}) do |f| %>
+<%= labelled_form_for(:environment, :url => {:action => 'update'}) do |f| %>
   <table>
     <% @active_plugins.sort_by(&:plugin_name).each do |plugin|   %>
 <h1><%= _('Profile settings for %s') % profile.name %></h1>
-<%= error_messages_for :profile %>
+<%= error_messages_for :profile_data %>
-<%= labelled_form_for :profile_data, @profile, :html => { :id => 'profile-data', :multipart => true } do |f| %>
+<%= labelled_form_for :profile_data, :html => { :id => 'profile-data', :multipart => true } do |f| %>
   <% if user.has_permission?('manage_environment_templates', profile.environment) %>
     <div id="profile-is-template">
 <h3> <%= _('Changing role of %s') % @member.name %> </h3>
-<%= labelled_form_for :member, @member, :url => {:action => 'update_roles'} do |f| %>
+<%= labelled_form_for :member, :url => {:action => 'update_roles'} do |f| %>
   <%= _('Roles:') %> <br>
   <% @roles.each do |r| %>
 <%= error_messages_for :role %>
-<%= labelled_form_for :role, role, :url => (mode == :edit) ? {:action => 'update', :id => role} : {:action => 'create'} do |f| %>
+<%= labelled_form_for :role, :url => (mode == :edit) ? {:action => 'update', :id => role} : {:action => 'create'} do |f| %>
   <%= required_fields_message %>
 <h1><%= @ticket.target ? _('New request for %s') % @ticket.target.name : _('New request') %></h1>
 <%# FIXME: put style in css %>
-<%= labelled_form_for :ticket, @ticket do |f| %>
+<%= labelled_form_for :ticket do |f| %>
   <% if @ticket.target %>
     <%= f.hidden_field :target_id  %>
   <% else %>
 <%= error_messages_for :contract %>
-<%= labelled_form_for :contract, @contract, :html => {:id => 'bsc-plugin-sales-form'} do |f| %>
+<%= labelled_form_for :contract, :html => {:id => 'bsc-plugin-sales-form'} do |f| %>
   <%= hidden_field_tag :contract_id, @contract.id %>
   <%= required f.text_field(:client_name) %>
   <%= labelled_form_field(_('Client type'), f.select(:client_type, BscPlugin::Contract::ClientType.types.map{|type| [BscPlugin::Contract::ClientType.names[type], type]}))%>
@@ -4,7 +4,7 @@
 <%= required_fields_message %>
-<%= labelled_form_for(:create_enterprise, @create_enterprise) do |f| %>
+<%= labelled_form_for(:create_enterprise) do |f| %>
   <%= required f.text_field 'name', :onchange => "updateUrlField(this, 'create_enterprise_identifier')", :size => 40 %>
   <%= render :partial => 'shared/organization_custom_fields', :locals => { :f => f, :object_name => :create_enterprise, :profile => @create_enterprise } %>
 <h1><%= _("Ldap Management") %> </h1>
-<%= labelled_form_for(:environment, @environment, :url => {:action => 'update'}) do |f| %>
+<%= labelled_form_for(:environment, :url => {:action => 'update'}) do |f| %>
 <table>
   <tr>
1	class EnvironmentRoleManagerController < AdminController	1	class EnvironmentRoleManagerController < AdminController
2	protect 'manage_environment_roles', :environment	2	protect 'manage_environment_roles', :environment
3	-	3	+
4	def index	4	def index
5	@admins = Person.find(:all, :conditions => ['role_assignments.resource_type = ?', 'Environment'], :include => :role_assignments )	5	@admins = Person.find(:all, :conditions => ['role_assignments.resource_type = ?', 'Environment'], :include => :role_assignments )
6	end	6	end
	@@ -8,7 +8,7 @@ class EnvironmentRoleManagerController < AdminController		@@ -8,7 +8,7 @@ class EnvironmentRoleManagerController < AdminController
8	def change_roles	8	def change_roles
9	@admin = Person.find(params[:id])	9	@admin = Person.find(params[:id])
10	@roles = Role.find(:all).select{ \|r\| r.has_kind?(:environment) }	10	@roles = Role.find(:all).select{ \|r\| r.has_kind?(:environment) }
11	- end	11	+ end
12		12
13	def update_roles	13	def update_roles
14	@roles = params[:roles] ? Role.find(params[:roles]) : []	14	@roles = params[:roles] ? Role.find(params[:roles]) : []
	@@ -20,7 +20,7 @@ class EnvironmentRoleManagerController < AdminController		@@ -20,7 +20,7 @@ class EnvironmentRoleManagerController < AdminController
20	end	20	end
21	redirect_to :action => :index	21	redirect_to :action => :index
22	end	22	end
23	-	23	+
24	def change_role	24	def change_role
25	@roles = Role.find(:all).select{ \|r\| r.has_kind?(:environment) }	25	@roles = Role.find(:all).select{ \|r\| r.has_kind?(:environment) }
26	@admin = Person.find(params[:id])	26	@admin = Person.find(params[:id])
	@@ -805,8 +805,7 @@ module ApplicationHelper		@@ -805,8 +805,7 @@ module ApplicationHelper
805	fields_for(name, object, { :builder => NoosferoFormBuilder }.merge(options), &proc)	805	fields_for(name, object, { :builder => NoosferoFormBuilder }.merge(options), &proc)
806	end	806	end
807		807
808	- def labelled_form_for(name, object = nil, options = {}, &proc)
809	- # FIXME remove the =object= argument and adapt the calling code	808	+ def labelled_form_for(name, options = {}, &proc)
810	form_for(name, { :builder => NoosferoFormBuilder }.merge(options), &proc)	809	form_for(name, { :builder => NoosferoFormBuilder }.merge(options), &proc)
811	end	810	end
812		811
1	-<%= labelled_form_for :user, @user,	1	+<%= labelled_form_for :user,
2	:url => { :controller => 'account', :action => (params[:enterprise_code] ? 'activate_enterprise' : 'login') } do \|f\| %>	2	:url => { :controller => 'account', :action => (params[:enterprise_code] ? 'activate_enterprise' : 'login') } do \|f\| %>
3		3
4	<%= f.text_field :login,	4	<%= f.text_field :login,
	@@ -11,7 +11,7 @@		@@ -11,7 +11,7 @@
11		11
12	<%= error_messages_for :user, :person, :header_message => _('The account could not be created') %>	12	<%= error_messages_for :user, :person, :header_message => _('The account could not be created') %>
13		13
14	-<%= labelled_form_for :user, @user, :html => { :multipart => true, :id => 'signup-form', :honeypot => true } do \|f\| %>	14	+<%= labelled_form_for :user, :html => { :multipart => true, :id => 'signup-form', :honeypot => true } do \|f\| %>
15		15
16	<input type="hidden" id="signup_time_key" name="signup_time_key" />	16	<input type="hidden" id="signup_time_key" name="signup_time_key" />
17	<script type="text/javascript">	17	<script type="text/javascript">
	@@ -7,7 +7,7 @@		@@ -7,7 +7,7 @@
7		7
8	<%= @message %>	8	<%= @message %>
9		9
10	-<%= labelled_form_for :user, @user, :url => login_url do \|f\| %>	10	+<%= labelled_form_for :user, :url => login_url do \|f\| %>
11		11
12	<%= f.text_field :login, :id => 'main_user_login', :onchange => 'this.value = convToValidLogin( this.value )', :value => params[:userlogin] %>	12	<%= f.text_field :login, :id => 'main_user_login', :onchange => 'this.value = convToValidLogin( this.value )', :value => params[:userlogin] %>
13		13
	@@ -2,7 +2,7 @@		@@ -2,7 +2,7 @@
2		2
3	<%= render :file => 'shared/tiny_mce' %>	3	<%= render :file => 'shared/tiny_mce' %>
4		4
5	-<%= labelled_form_for :environment, @environment, :url => {:action => 'site_info'} do \|f\| %>	5	+<%= labelled_form_for :environment, :url => {:action => 'site_info'} do \|f\| %>
6		6
7	<%= f.text_area :message_for_disabled_enterprise, :cols => 40, :style => 'width: 90%' %>	7	<%= f.text_area :message_for_disabled_enterprise, :cols => 40, :style => 'width: 90%' %>
8		8
1	<h1><%= _('News amount by folder') %></h1>	1	<h1><%= _('News amount by folder') %></h1>
2		2
3	-<%= labelled_form_for :environment, @environment do \|f\| %>	3	+<%= labelled_form_for :environment do \|f\| %>
4		4
5	<%= labelled_form_field _('Number of news'), select(:environment, :news_amount_by_folder, (1..10).to_a) %>	5	<%= labelled_form_field _('Number of news'), select(:environment, :news_amount_by_folder, (1..10).to_a) %>
6		6
	@@ -4,7 +4,7 @@		@@ -4,7 +4,7 @@
4		4
5	<%= render :file => 'shared/tiny_mce' %>	5	<%= render :file => 'shared/tiny_mce' %>
6		6
7	-<%= labelled_form_for :environment, @environment do \|f\| %>	7	+<%= labelled_form_for :environment do \|f\| %>
8	<% tabs = [] %>	8	<% tabs = [] %>
9	<% tabs << {:title => _('Site info'), :id => 'site-info',	9	<% tabs << {:title => _('Site info'), :id => 'site-info',
10	:content => (render :partial => 'site_info', :locals => {:f => f})} %>	10	:content => (render :partial => 'site_info', :locals => {:f => f})} %>
1	<%= error_messages_for 'category' %>	1	<%= error_messages_for 'category' %>
2		2
3	-<%= labelled_form_for 'category', @category, :html => { :multipart => true} do \|f\| %>	3	+<%= labelled_form_for 'category', :html => { :multipart => true} do \|f\| %>
4		4
5	<%= required_fields_message %>	5	<%= required_fields_message %>
6		6
	@@ -2,7 +2,7 @@		@@ -2,7 +2,7 @@
2		2
3	<%= error_messages_for 'article' %>	3	<%= error_messages_for 'article' %>
4		4
5	-<%= labelled_form_for 'article', @article, :url => { :action => 'destroy' }, :method => 'post' do \|f\| %>	5	+<%= labelled_form_for 'article', :url => { :action => 'destroy' }, :method => 'post' do \|f\| %>
6		6
7	<strong>	7	<strong>
8	<% if @article.folder? %>	8	<% if @article.folder? %>