Download as
Browse Code »

Commit 33c7f4542be626b205e6f78219d3676eb1282d0a

Authored by Daniela Feitosa
1 parent 5a1f2908
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

Added missing test and translation markup 

(ActionItem2837)
Showing 3 changed files with 16 additions and 2 deletions   Show diff stats
plugins/community_track/lib/community_track_plugin/step.rb
  Diff comments   View file @33c7f45
... ... @@ -7,7 +7,7 @@ class CommunityTrackPlugin::Step < Folder
7 7 acts_as_list :scope => :parent
8 8  
9 9 def belong_to_track
10   - errors.add(:parent, "Step not allowed at this parent.") if !parent.kind_of?(CommunityTrackPlugin::Track)
  10 + errors.add(:parent, _("Step not allowed at this parent.")) unless parent.kind_of?(CommunityTrackPlugin::Track)
11 11 end
12 12  
13 13 validate :belong_to_track
... ...
plugins/community_track/lib/community_track_plugin/track.rb
  Diff comments   View file @33c7f45
... ... @@ -49,8 +49,8 @@ class CommunityTrackPlugin::Track < Folder
49 49 "community-track-plugin-track"
50 50 end
51 51  
52   - #FIXME make this test
53 52 def first_paragraph
  53 + return '' if body.blank?
54 54 paragraphs = Hpricot(body).search('p')
55 55 paragraphs.empty? ? '' : paragraphs.first.to_html
56 56 end
... ...
plugins/community_track/test/unit/community_track_plugin/track_test.rb
  Diff comments   View file @33c7f45
... ... @@ -110,4 +110,18 @@ class TrackTest < ActiveSupport::TestCase
110 110 assert_equal [hidden_step], @track.hidden_steps
111 111 end
112 112  
  113 + should 'get first paragraph' do
  114 + @track.body = '<p>First</p><p>Second</p>'
  115 + assert_equal '<p>First</p>', @track.first_paragraph
  116 + end
  117 +
  118 + should 'provide first_paragraph even if body was not given' do
  119 + assert_equal '', @track.first_paragraph
  120 + end
  121 +
  122 + should 'provide first_paragraph even if body is nil' do
  123 + @track.body = nil
  124 + assert_equal '', @track.first_paragraph
  125 + end
  126 +
113 127 end
... ...