[Mezuro] handle exceptions in base_tool

João M. M. da Silva + Alessandro Palmeira · Paulo Meireles
1 parent d23a42e4
Showing 2 changed files with 13 additions and 3 deletions Show diff stats
plugins/mezuro/controllers/mezuro_plugin_myprofile_controller.rb
plugins/mezuro/lib/kalibro/base_tool.rb
@@ -6,12 +6,14 @@ class MezuroPluginMyprofileController &lt; ProfileController
   def choose_base_tool
     @configuration_content = profile.articles.find(params[:id])
     @base_tools = Kalibro::BaseTool.all_names
+    @base_tools = [] if @base_tools.first.is_a? Exception
   end
   def choose_metric
     @configuration_content = profile.articles.find(params[:id])
     @base_tool = params[:base_tool]
-    @supported_metrics = Kalibro::BaseTool.find_by_name(@base_tool).supported_metrics
+    base_tool = Kalibro::BaseTool.find_by_name(@base_tool)
+    @supported_metrics = base_tool.nil? ? [] : base_tool.supported_metrics 
   end
   def new_metric_configuration
@@ -3,11 +3,19 @@ class Kalibro::BaseTool &lt; Kalibro::Model
   attr_accessor :name, :description, :supported_metric
   def self.all_names
-    request("BaseTool", :get_base_tool_names)[:base_tool_name].to_a
+    begin
+      request("BaseTool", :get_base_tool_names)[:base_tool_name].to_a
+    rescue Exception => exception
+      [exception]
+    end
   end
   def self.find_by_name(base_tool_name)
-    new request("BaseTool", :get_base_tool, {:base_tool_name => base_tool_name})[:base_tool]
+    begin
+      new request("BaseTool", :get_base_tool, {:base_tool_name => base_tool_name})[:base_tool]
+    rescue Exception
+      nil
+    end
   end
   def supported_metric=(value)