Download as
Browse Code »

Commit 3d76539d2ff554dc23824e71b3475c1356eea5f1

Authored by Rodrigo Souto
Committed by Joenio Costa
1 parent 16d7dc3c
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

Raising 'not found' page while accessing an unexistent topic in a section 

(ActionItem1397)
Showing 2 changed files with 14 additions and 1 deletions   Show diff stats
app/models/doc_section.rb
  Diff comments   View file @3d76539
@@ -5,7 +5,12 @@ class DocSection < DocItem @@ -5,7 +5,12 @@ class DocSection < DocItem
5 end 5 end
6 6
7 def find(id) 7 def find(id)
8 - items.find {|item| item.id == id } 8 + topic = items.find {|item| item.id == id }
  9 + if topic
  10 + topic
  11 + else
  12 + raise DocItem::NotFound
  13 + end
9 end 14 end
10 15
11 def self.all(language = 'en', force = false) 16 def self.all(language = 'en', force = false)
test/unit/doc_section_test.rb
  Diff comments   View file @3d76539
@@ -97,4 +97,12 @@ class DocSectionTest < ActiveSupport::TestCase @@ -97,4 +97,12 @@ class DocSectionTest < ActiveSupport::TestCase
97 end 97 end
98 end 98 end
99 99
  100 + should 'raise DocTopic::NotFound when trying to find an unexisting topic inside a section' do
  101 + section = DocSection.all.first
  102 + assert_raise DocItem::NotFound do
  103 + section.find('unexisting')
  104 + end
  105 + end
  106 +
  107 +
100 end 108 end