adding tests for community api

Leandro Santos · Rodrigo Souto
1 parent 48598ab3
Showing 3 changed files with 25 additions and 7 deletions Show diff stats
lib/api/v1/communities.rb
test/unit/api/communities_test.rb
test/unit/api/test_helper.rb
@@ -29,8 +29,11 @@ module API
       end
       resource :people do
+
         segment '/:person_id' do
+
           resource :communities do
+
             get do
               person = environment.people.find(params[:person_id])
               communities = select_filtered_collection_of(person, 'communities', params)
@@ -38,13 +41,8 @@ module API
               present communities, :with => Entities::Community
             end
-#            get ':id' do
-#              person = environment.people.find(params[:person_id])
-#              article = find_article(person.articles, params[:id])
-#              present article, :with => Entities::Article
-#            end
-
           end
+
         end
       end
@@ -31,6 +31,25 @@ class CommunitiesTest &lt; ActiveSupport::TestCase
     assert_equal [community1.id], json['communities'].map {|c| c['id']}
   end
+  should 'not list private communities without permission' do
+    community1 = fast_create(Community)
+    fast_create(Community, :public_profile => false)
+
+    get "/api/v1/communities?#{params.to_query}"
+    json = JSON.parse(last_response.body)
+    assert_equal [community1.id], json['communities'].map {|c| c['id']}
+  end
+
+  should 'list private community for members' do
+    c1 = fast_create(Community)
+    c2 = fast_create(Community, :public_profile => false)
+    c1.add_member(person)
+
+    get "/api/v1/communities?#{params.to_query}"
+    json = JSON.parse(last_response.body)
+    assert_equivalent [c1.id, c2.id], json['communities'].map {|c| c['id']}
+  end
+
   should 'not get invisible community' do
     community = fast_create(Community, :visible => false)
@@ -11,12 +11,13 @@ class ActiveSupport::TestCase
   def login_api
     @user = User.create!(:login => 'testapi', :password => 'testapi', :password_confirmation => 'testapi', :email => 'test@test.org', :environment => Environment.default)
     @user.activate
+    @person = @user.person
     post "/api/v1/login?login=testapi&password=testapi"
     json = JSON.parse(last_response.body)
     @private_token = json["private_token"]
     @params = {:private_token => @private_token}
   end
-  attr_accessor :private_token, :user, :params
+  attr_accessor :private_token, :user, :person, :params
 end
	@@ -31,6 +31,25 @@ class CommunitiesTest < ActiveSupport::TestCase		@@ -31,6 +31,25 @@ class CommunitiesTest < ActiveSupport::TestCase
31	assert_equal [community1.id], json['communities'].map {\|c\| c['id']}	31	assert_equal [community1.id], json['communities'].map {\|c\| c['id']}
32	end	32	end
33		33
		34	+ should 'not list private communities without permission' do
		35	+ community1 = fast_create(Community)
		36	+ fast_create(Community, :public_profile => false)
		37	+
		38	+ get "/api/v1/communities?#{params.to_query}"
		39	+ json = JSON.parse(last_response.body)
		40	+ assert_equal [community1.id], json['communities'].map {\|c\| c['id']}
		41	+ end
		42	+
		43	+ should 'list private community for members' do
		44	+ c1 = fast_create(Community)
		45	+ c2 = fast_create(Community, :public_profile => false)
		46	+ c1.add_member(person)
		47	+
		48	+ get "/api/v1/communities?#{params.to_query}"
		49	+ json = JSON.parse(last_response.body)
		50	+ assert_equivalent [c1.id, c2.id], json['communities'].map {\|c\| c['id']}
		51	+ end
		52	+
34	should 'not get invisible community' do	53	should 'not get invisible community' do
35	community = fast_create(Community, :visible => false)	54	community = fast_create(Community, :visible => false)
36		55