Download as
Browse Code »

Commit 3ec38214b97d1c65da67881636a517136aaea621

Authored by Daniela Feitosa
1 parent ea021e7f
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

curriculum_lattes_plugin: avoid affecting core 

When plugin is not enabled on environment, the plugin extensions can't affect
other features
Showing 2 changed files with 41 additions and 3 deletions   Show diff stats
plugins/lattes_curriculum/lib/ext/person.rb
  Diff comments   View file @3ec3821
... ... @@ -4,16 +4,28 @@ class Person
4 4  
5 5 attr_accessible :lattes_url, :academic_info_attributes
6 6  
7   - has_one :academic_info, :dependent=>:delete
  7 + has_one :academic_info
  8 +
  9 + after_destroy do |person|
  10 + if !person.environment.nil? &&
  11 +person.environment.plugin_enabled?(LattesCurriculumPlugin) &&
  12 +!person.academic_info.nil?
  13 + person.academic_info.destroy
  14 + end
  15 + end
8 16  
9 17 accepts_nested_attributes_for :academic_info
10 18  
11 19 def lattes_url
12   - self.academic_info.nil? ? nil : self.academic_info.lattes_url
  20 + if self.environment && self.environment.plugin_enabled?(LattesCurriculumPlugin)
  21 + self.academic_info.nil? ? nil : self.academic_info.lattes_url
  22 + end
13 23 end
14 24  
15 25 def lattes_url= value
16   - self.academic_info.lattes_url = value unless self.academic_info.nil?
  26 + if self.environment && self.environment.plugin_enabled?(LattesCurriculumPlugin)
  27 + self.academic_info.lattes_url = value unless self.academic_info.nil?
  28 + end
17 29 end
18 30  
19 31 FIELDS << "lattes_url"
... ...
plugins/lattes_curriculum/test/unit/person_test.rb 0 → 100644
  Diff comments   View file @3ec3821
... ... @@ -0,0 +1,26 @@
  1 +require "test_helper"
  2 +
  3 +class PersonTest < ActiveSupport::TestCase
  4 +
  5 + def setup
  6 + @environment = Environment.default
  7 + @environment.enable_plugin(LattesCurriculumPlugin)
  8 + end
  9 +
  10 + attr_reader :environment
  11 +
  12 + should 'destroy academic info if person is removed' do
  13 + person = fast_create(Person)
  14 + academic_info = fast_create(AcademicInfo, :person_id => person.id,
  15 +:lattes_url => 'http://lattes.cnpq.br/2193972715230')
  16 +
  17 + assert_difference 'AcademicInfo.count', -1 do
  18 + person.destroy
  19 + end
  20 + end
  21 +
  22 + should 'add lattes_url field to Person' do
  23 + assert_includes Person.fields, 'lattes_url'
  24 + end
  25 +
  26 +end
... ...