Download as
Browse Code »

Commit 438e2c7d1f235ed9240547ed5fb3b3b0a91e5536

Authored by Braulio Bhavamitra
1 parent f22a56c9
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

geo_ref: always mock external requests 

As talked with terceiro, it is not a good idea to depend on ENV vars
Showing 1 changed file with 4 additions and 4 deletions   Show diff stats
test/unit/geo_ref_test.rb
  Diff comments   View file @438e2c7
... ... @@ -38,17 +38,17 @@ class GeoRefTest < ActiveSupport::TestCase
38 38  
39 39 should 'get lat/lng from address' do
40 40 Rails.cache.clear
41   - Noosfero::GeoRef.stubs(:location_to_georef).with('Salvador, Bahia, BR').returns([-12, -38, :SUCCESS]) if ENV['CI']
  41 + Noosfero::GeoRef.stubs(:location_to_georef).with('Salvador, Bahia, BR').returns([-12, -38, :SUCCESS])
42 42 ll = Noosfero::GeoRef.location_to_georef 'Salvador, Bahia, BR'
43 43 assert_equal [-12, -38, :SUCCESS], round_ll(ll)
44 44 end
45 45  
46 46 should 'get and cache lat/lng from address' do
47 47 Rails.cache.clear
48   - Noosfero::GeoRef.stubs(:location_to_georef).with('Curitiba, Paraná, BR').returns([-25, -49, :SUCCESS]) if ENV['CI']
  48 + Noosfero::GeoRef.stubs(:location_to_georef).with('Curitiba, Paraná, BR').returns([-25, -49, :SUCCESS])
49 49 ll = Noosfero::GeoRef.location_to_georef 'Curitiba, Paraná, BR'
50 50 assert_equal [-25, -49, :SUCCESS], round_ll(ll)
51   - Noosfero::GeoRef.stubs(:location_to_georef).with('Curitiba, Paraná, BR').returns([-25, -49, :SUCCESS, :CACHE]) if ENV['CI']
  51 + Noosfero::GeoRef.stubs(:location_to_georef).with('Curitiba, Paraná, BR').returns([-25, -49, :SUCCESS, :CACHE])
52 52 ll = Noosfero::GeoRef.location_to_georef 'Curitiba, Paraná, BR'
53 53 assert_equal [-25, -49, :SUCCESS, :CACHE], round_ll(ll)
54 54 end
... ... @@ -57,7 +57,7 @@ class GeoRefTest < ActiveSupport::TestCase
57 57 Rails.cache.clear
58 58 orig_env = ENV['RAILS_ENV']
59 59 ENV['RAILS_ENV'] = 'X' # cancel throw for test mode on process_rest_req.
60   - Noosfero::GeoRef.stubs(:location_to_georef).with('Nowhere, Nocountry, XYZ').returns([0, 0, :ZERO_RESULTS]) if ENV['CI']
  60 + Noosfero::GeoRef.stubs(:location_to_georef).with('Nowhere, Nocountry, XYZ').returns([0, 0, :ZERO_RESULTS])
61 61 ll = Noosfero::GeoRef.location_to_georef 'Nowhere, Nocountry, XYZ'
62 62 ENV['RAILS_ENV'] = orig_env # restore value to do not mess with other tests.
63 63 assert_equal [0, 0, :ZERO_RESULTS], round_ll(ll)
... ...